-
Notifications
You must be signed in to change notification settings - Fork 1
Implementation Plan: T5-P3-A3-WP3 Produce Merge-Blocking CI Tests for Codex Deterministic Conformance #4149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Trecek
merged 4 commits into
develop
from
t5-p3-a3-wp3-produce-merge-blocking-ci-tests-no-live-cli-req/4011-2
Jun 29, 2026
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
e457043
feat(T5-P3-A3-WP3): add Codex deterministic conformance tests
Trecek fcd868d
fix: add dotted-name event fixture files for CodexEventType conformanβ¦
Trecek e891c3d
fix(review): replace silent else-float fallback with explicit MCP keyβ¦
Trecek 6532918
fix(review): add missing model_auto_compact_token_limit assertion in β¦
Trecek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 changes: 26 additions & 0 deletions
26
tests/execution/backends/fixtures/codex_ndjson/event_item.completed.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| { | ||
| "$schema": "http://json-schema.org/draft-07/schema#", | ||
| "additionalProperties": false, | ||
| "properties": { | ||
| "item": { | ||
| "properties": { | ||
| "type": { | ||
| "type": "string" | ||
| } | ||
| }, | ||
| "required": [ | ||
| "type" | ||
| ], | ||
| "type": "object" | ||
| }, | ||
| "type": { | ||
| "const": "item.completed", | ||
| "type": "string" | ||
| } | ||
| }, | ||
| "required": [ | ||
| "type", | ||
| "item" | ||
| ], | ||
| "type": "object" | ||
| } |
14 changes: 14 additions & 0 deletions
14
tests/execution/backends/fixtures/codex_ndjson/event_item.started.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| { | ||
| "$schema": "http://json-schema.org/draft-07/schema#", | ||
| "additionalProperties": false, | ||
| "properties": { | ||
| "type": { | ||
| "const": "item.started", | ||
| "type": "string" | ||
| } | ||
| }, | ||
| "required": [ | ||
| "type" | ||
| ], | ||
| "type": "object" | ||
| } |
14 changes: 14 additions & 0 deletions
14
tests/execution/backends/fixtures/codex_ndjson/event_item.updated.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| { | ||
| "$schema": "http://json-schema.org/draft-07/schema#", | ||
| "additionalProperties": false, | ||
| "properties": { | ||
| "type": { | ||
| "const": "item.updated", | ||
| "type": "string" | ||
| } | ||
| }, | ||
| "required": [ | ||
| "type" | ||
| ], | ||
| "type": "object" | ||
| } |
18 changes: 18 additions & 0 deletions
18
tests/execution/backends/fixtures/codex_ndjson/event_thread.started.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| { | ||
| "$schema": "http://json-schema.org/draft-07/schema#", | ||
| "additionalProperties": false, | ||
| "properties": { | ||
| "thread_id": { | ||
| "type": "string" | ||
| }, | ||
| "type": { | ||
| "const": "thread.started", | ||
| "type": "string" | ||
| } | ||
| }, | ||
| "required": [ | ||
| "type", | ||
| "thread_id" | ||
| ], | ||
| "type": "object" | ||
| } |
18 changes: 18 additions & 0 deletions
18
tests/execution/backends/fixtures/codex_ndjson/event_turn.completed.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| { | ||
| "$schema": "http://json-schema.org/draft-07/schema#", | ||
| "additionalProperties": false, | ||
| "properties": { | ||
| "type": { | ||
| "const": "turn.completed", | ||
| "type": "string" | ||
| }, | ||
| "usage": { | ||
| "type": "object" | ||
| } | ||
| }, | ||
| "required": [ | ||
| "type", | ||
| "usage" | ||
| ], | ||
| "type": "object" | ||
| } |
36 changes: 36 additions & 0 deletions
36
tests/execution/backends/fixtures/codex_ndjson/event_turn.failed.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| { | ||
| "$schema": "http://json-schema.org/draft-07/schema#", | ||
| "additionalProperties": false, | ||
| "properties": { | ||
| "error": { | ||
| "oneOf": [ | ||
| { | ||
| "properties": { | ||
| "code": { | ||
| "type": "string" | ||
| }, | ||
| "message": { | ||
| "type": "string" | ||
| } | ||
| }, | ||
| "required": [ | ||
| "message" | ||
| ], | ||
| "type": "object" | ||
| }, | ||
| { | ||
| "type": "string" | ||
| } | ||
| ] | ||
| }, | ||
| "type": { | ||
| "const": "turn.failed", | ||
| "type": "string" | ||
| } | ||
| }, | ||
| "required": [ | ||
| "type", | ||
| "error" | ||
| ], | ||
| "type": "object" | ||
| } |
14 changes: 14 additions & 0 deletions
14
tests/execution/backends/fixtures/codex_ndjson/event_turn.started.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| { | ||
| "$schema": "http://json-schema.org/draft-07/schema#", | ||
| "additionalProperties": false, | ||
| "properties": { | ||
| "type": { | ||
| "const": "turn.started", | ||
| "type": "string" | ||
| } | ||
| }, | ||
| "required": [ | ||
| "type" | ||
| ], | ||
| "type": "object" | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[warning] cohesion: The
update_fixturesfixture is defined only intests/execution/backends/conftest.pybut--update-fixturesCLI option is registered in the top-leveltests/conftest.py. If future tests outsidetests/execution/backends/need this fixture, it will be unavailable. Consider co-locating the fixture at the top-levelconftest.pyalongside the option registration.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Valid observation β flagged for design decision. The --update-fixtures CLI option is registered in the top-level tests/conftest.py per pytest requirements, while the update_fixtures fixture wrapping it is defined only in tests/execution/backends/conftest.py β intentional co-location with its sole consumer. Moving the fixture to the top-level conftest is a valid future-proofing step if the option is expected to become reusable, but requires a human decision on whether this is expected to remain backends-only.