Skip to content

Implementation Plan: T5-P5-A3-WP3 Make the INVARIANT_REGISTRY Reflect Actual Enforcement Reality#4152

Merged
Trecek merged 1 commit into
developfrom
t5-p5-a3-wp3-make-the-invariant-registry-reflect-the-actual/4035
Jun 29, 2026
Merged

Implementation Plan: T5-P5-A3-WP3 Make the INVARIANT_REGISTRY Reflect Actual Enforcement Reality#4152
Trecek merged 1 commit into
developfrom
t5-p5-a3-wp3-make-the-invariant-registry-reflect-the-actual/4035

Conversation

@Trecek

@Trecek Trecek commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

Summary

Update two INVARIANT_REGISTRY entries — recipe-read-headless and write-path-prefix — to have enforcement_layer="server-side" instead of "hook-deny". This reflects the actual enforcement reality: P5-A3-WP1 (commit c9ed35e3d, PR #4105) added server-side guards _check_recipe_read_prohibition() and _check_write_target_boundary() in server/_guards.py, which are injected into run_cmd and run_python tool handlers in server/tools/tools_execution.py. The registry entries still say "hook-deny" — this WP updates them to match reality. Add two pin tests asserting the new values.

Implementation Plan

Plan file: /home/talon/projects/autoskillit-runs/impl-20260628-200621-936012/.autoskillit/temp/make-plan/t5-p5-a3-wp3-invariant-registry-enforcement-layer_plan_2026-06-28_201500.md

Closes #4035

🤖 Generated with Claude Code via AutoSkillit

Token Usage Summary

Step Model count uncached output cache_read peak_ctx turns cache_write time
plan* opus[1m] 1 46 4.9k 563.1k 73.4k 22 76.1k 4m 37s
verify* sonnet 1 44 3.8k 161.4k 41.5k 15 23.7k 1m 53s
implement* MiniMax-M3 1 59.2k 4.3k 1.3M 0 59 0 2m 5s
audit_impl* sonnet 1 52 3.4k 198.4k 39.2k 13 23.5k 2m 13s
prepare_pr* MiniMax-M3 1 39.7k 1.9k 146.6k 0 12 0 26s
compose_pr* MiniMax-M3 1 36.0k 1.4k 140.8k 0 12 0 38s
review_pr* sonnet 3 382 32.5k 2.1M 56.0k 109 112.3k 10m 11s
Total 135.4k 52.2k 4.6M 73.4k 235.5k 22m 5s

* Step used a non-Anthropic provider; caching behavior may differ.

Token Efficiency

Step LoC Changed cache_read/LoC cache_write/LoC output/LoC
plan 0
verify 0
implement 18 74595.6 0.0 241.4
audit_impl 0
prepare_pr 0
compose_pr 0
review_pr 0
Total 18 256762.6 13083.8 2901.3

Model Usage Breakdown

Model steps uncached output cache_read cache_write time
opus[1m] 1 46 4.9k 563.1k 76.1k 4m 37s
sonnet 3 478 39.7k 2.4M 159.4k 14m 18s
MiniMax-M3 3 134.9k 7.7k 1.6M 0 3m 9s

… guards

Change `recipe-read-headless` and `write-path-prefix` entries from
`enforcement_layer="hook-deny"` to `enforcement_layer="server-side"` to
reflect the actual enforcement reality: P5-A3-WP1 (commit c9ed35e)
added `_check_recipe_read_prohibition()` and `_check_write_target_boundary()`
in `server/_guards.py`, which are injected into `run_cmd` and `run_python`
tool handlers.

Add two pin tests asserting the new `server-side` values for both entries.

@Trecek Trecek left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoSkillit PR Review — Verdict: approved

@Trecek Trecek added this pull request to the merge queue Jun 29, 2026
Merged via the queue into develop with commit 72be9b4 Jun 29, 2026
3 checks passed
@Trecek Trecek deleted the t5-p5-a3-wp3-make-the-invariant-registry-reflect-the-actual/4035 branch June 29, 2026 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant