Demote post_run_diagnostics to Config-as-Default & Complete Feedback Contract#4183
Merged
Trecek merged 3 commits intoJul 5, 2026
Conversation
…ty-feedback contract - Remove post_run_diagnostics from CONFIG_AUTHORITY_KEYS, SERVER_AUTHORITATIVE_CONFIG_PATHS, and SERVER_AUTHORITATIVE_KEY_HINTS - Add CONFIG_DEFAULT_INGREDIENTS frozenset and build_config_default_layer() function - Inject config-default layer at base priority in all three merge sites (open_kitchen, load_recipe, get_recipe) - Add hint parity to build_authority_clobber_warnings — mirror the rejection envelope hint pattern - Add sous-chef warning relay rule for open_kitchen warnings - Remove authority: config from post_run_diagnostics in all four recipe YAMLs - Add diagnostic routing to implementation-groups.yaml terminal paths (run_diagnostic, run_diagnostic_error, run_diagnostic_unconfirmed, run_diagnostic_no_ci) - Update docstrings and sous-chef do-not-lock list - Add per-run enablement section to diagnostics.md - Regenerate contract cards and compiled recipe JSON - Migrate existing test examples; add T1-T7 for new behavior
- Add post_run_diagnostics back to _PATCHED_DEFAULTS (config-default layer needs it) - Fix test_load_recipe_emits_authority_warning to match actual server value 'develop' - Update tools_kitchen.py atomic_write line numbers in schema version allowlist - Bump tools_kitchen.py line limit exemption to 1395 - Update register_clone_unconfirmed routing assertion to run_diagnostic_unconfirmed - Refresh recipe diagram hashes for implementation, implementation-groups, merge-prs, remediation Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove two comments (L1156-1157 and L1160) that restate intent already captured by assertions and docstrings, per project no-comment convention. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Trecek
force-pushed
the
per-run-post-run-diagnostics-enablement-demote-to-config-as/4180
branch
from
ebe1a15 to
14679d9
Compare
Trecek
deleted the
per-run-post-run-diagnostics-enablement-demote-to-config-as/4180
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This plan demotes
post_run_diagnosticsfrom a server-authoritative ingredient to a config-as-default ingredient. After this change: (1) an explicitopen_kitchenoverride forpost_run_diagnosticswins over the config value, (2) absent an override the config valuediagnostics.post_run_analysisremains the default source, (3) the key becomes lockable vialock_ingredients, (4) clobber warnings for remaining authoritative keys gain hint parity with the lock-rejection envelope, (5) a sous-chef rule requires the orchestrator to relayopen_kitchenwarnings, and (6)implementation-groups.yamlterminal paths gainrun_diagnostic*step parity withimplementation.yaml.Requirements
ING — ingredient authority
open_kitchenoverride forpost_run_diagnosticsmust win over the config-derived value (the key must no longer be a member ofSERVER_AUTHORITATIVE_INGREDIENTS).post_run_diagnosticsmust continue to resolve fromdiagnostics.post_run_analysis(config remains the default source; the shipped default staysfalse).post_run_diagnosticswithauthority: configmust drop that authority marker so validation and admission match the new behavior.lock_ingredientsmust accept lockingpost_run_diagnostics, and the lock must be enforced by the existing lock/trace mechanism like any other lockable ingredient.open_kitchendocstring and the sous-chef server-authoritative do-not-lock list must no longer namepost_run_diagnosticsamong the authoritative examples.FDB — feedback parity (remaining authoritative keys)
open_kitchenclobber warning for a server-authoritative key must include that key'sSERVER_AUTHORITATIVE_KEY_HINTSline when one exists, matching thelock_ingredientsrejection envelope.SKL — consumption contract
open_kitchenreturns a non-emptywarningsarray, each warning is relayed to the user in the orchestrator's next response before the pipeline proceeds (an immediate-action rule; no deferred-action obligations).PAR — parity and documentation
run_diagnostic*steps gated onpost_run_diagnosticswith parity to implementation.yaml (today it declares the ingredient but contains zero diagnostic steps, so the feature can never fire there).diagnostics.post_run_analysisand the per-run override behavior must be documented in docs/.TEST — co-update surface
open_kitchen(overrides={"post_run_diagnostics": "true"})with configfalseresolves the ingredient totrue, and that with no override the config value is used.post_run_diagnosticsas their server-authoritative example (authority-feedback and frozenset-membership tests from Ingredient authority feedback contract: silent-clobber vs hard-reject asymmetry + non-actionable lock_ingredients rejection stalls Codex pipelines #4169/PR Rectify: Ingredient Authority Feedback Contract — Silent-Clobber vs Hard-Reject Asymmetry #4170 and Rectify: Defense-in-Depth — Server-Authoritative Ingredient Override Registry #3185) must be migrated to a remaining authoritative key (e.g.,base_branch) without losing coverage.register_clone_*terminal in the three implementation-family recipes routes through arun_diagnostic*step gated onpost_run_diagnostics.Closes #4180
Implementation Plan
Plan file:
/home/talon/projects/autoskillit-runs/impl-20260704-151702-234347/.autoskillit/temp/make-plan/demote_post_run_diagnostics_plan_2026-07-04_160500.md🤖 Generated with Claude Code via AutoSkillit
Token Usage Summary
* Step used a non-Anthropic provider; caching behavior may differ.
Token Efficiency
Model Usage Breakdown