ci(release): make publish version step idempotent#4
Merged
Conversation
The publish job ran 'npm version <v> --no-git-tag-version' unconditionally, which fails with 'Version not changed' when package.json is already at the target version (e.g. when a version bump was committed alongside a fix). Skip the bump when the version already matches, mirroring the guard the update-version job already uses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The 0.1.7 release failed at the Set package version step:
The version bump to 0.1.7 was committed alongside the bare-body fix (5bc4d0b), so
package.jsononmainwas already at 0.1.7 when the release ran. The publish job'snpm version 0.1.7 --no-git-tag-versiontreats a no-op set as an error and fails the whole publish.Fix
Skip the bump when
package.jsonis already at the target version, mirroring thegit diff --quietguard theupdate-versionjob already uses. After this merges, re-running the 0.1.7 release will publish cleanly.Going forward
Keep version bumps out of feature/fix commits — let the release workflow own them.