Skip to content

Commit 2a7e07f

Browse files
committed
fix: address partner add-on review
1 parent e0bc307 commit 2a7e07f

6 files changed

Lines changed: 15 additions & 6 deletions

File tree

packages/create/src/frameworks/react/add-ons/clerk/README.md

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,11 +24,17 @@ server:
2424

2525
```tsx
2626
import { createFileRoute, redirect } from '@tanstack/react-router'
27+
import { createServerFn } from '@tanstack/react-start'
2728
import { auth } from '@clerk/tanstack-react-start/server'
2829

30+
const getAuth = createServerFn({ method: 'GET' }).handler(async () => {
31+
const { userId } = await auth()
32+
return { userId }
33+
})
34+
2935
export const Route = createFileRoute('/dashboard')({
3036
beforeLoad: async () => {
31-
const { userId } = await auth()
37+
const { userId } = await getAuth()
3238
if (!userId) throw redirect({ to: '/' })
3339
},
3440
})
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
22
"dependencies": {
3-
"nitro": "latest"
3+
"nitro": "3.0.260610-beta"
44
}
55
}

packages/create/src/frameworks/react/hosts/railway/package.json.ejs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,6 @@
33
"start": "<%= addOnEnabled.sentry ? 'node --import ./.output/server/instrument.server.mjs .output/server/index.mjs' : 'node .output/server/index.mjs' %>"
44
},
55
"dependencies": {
6-
"nitro": "latest"
6+
"nitro": "3.0.260610-beta"
77
}
88
}
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
22
"dependencies": {
3-
"nitro": "latest"
3+
"nitro": "3.0.260610-beta"
44
}
55
}

packages/create/src/frameworks/solid/hosts/railway/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,6 @@
33
"start": "node .output/server/index.mjs"
44
},
55
"dependencies": {
6-
"nitro": "latest"
6+
"nitro": "3.0.260610-beta"
77
}
88
}

packages/create/tests/partner-addons.test.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,10 @@ describe('partner add-on scaffolds', () => {
158158
const packageJSON = JSON.parse(output.files['package.json'])
159159
const readme = output.files['README.md']
160160

161-
expect(packageJSON.dependencies).toHaveProperty('nitro')
161+
expect(packageJSON.dependencies).toHaveProperty(
162+
'nitro',
163+
'3.0.260610-beta',
164+
)
162165
expect(packageJSON.dependencies).not.toHaveProperty('nitro-nightly')
163166
expect(Object.values(packageJSON.dependencies)).not.toContain(
164167
'npm:nitro-nightly@latest',

0 commit comments

Comments
 (0)