Skip to content

Commit 54e9535

Browse files
fix(create): make eslint scaffolds pass out of the box (#385)
* fix(create): stabilize eslint toolchain defaults * fix(create): improve form select contrast in dark mode
1 parent 2a6da38 commit 54e9535

File tree

4 files changed

+41
-6
lines changed

4 files changed

+41
-6
lines changed

packages/create/src/frameworks/react/add-ons/form/assets/src/components/demo.FormComponents.tsx.ejs

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -117,11 +117,15 @@ export function Select({
117117
<ShadcnSelect.SelectTrigger className="w-full">
118118
<ShadcnSelect.SelectValue placeholder={placeholder} />
119119
</ShadcnSelect.SelectTrigger>
120-
<ShadcnSelect.SelectContent>
120+
<ShadcnSelect.SelectContent className="bg-background text-foreground">
121121
<ShadcnSelect.SelectGroup>
122122
<ShadcnSelect.SelectLabel>{label}</ShadcnSelect.SelectLabel>
123123
{values.map((value) => (
124-
<ShadcnSelect.SelectItem key={value.value} value={value.value}>
124+
<ShadcnSelect.SelectItem
125+
key={value.value}
126+
value={value.value}
127+
className="text-foreground"
128+
>
125129
{value.label}
126130
</ShadcnSelect.SelectItem>
127131
))}
@@ -297,4 +301,4 @@ export function Select({
297301
</div>
298302
)
299303
}
300-
<% } %>
304+
<% } %>

packages/create/src/frameworks/react/add-ons/shadcn/assets/src/lib/utils.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
import { clsx, type ClassValue } from "clsx"
1+
import type { ClassValue } from 'clsx'
2+
import { clsx } from "clsx"
23
import { twMerge } from "tailwind-merge"
34

45
export function cn(...inputs: ClassValue[]) {

packages/create/src/frameworks/react/toolchains/eslint/assets/eslint.config.js

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,19 @@
22

33
import { tanstackConfig } from '@tanstack/eslint-config'
44

5-
export default [...tanstackConfig]
5+
export default [
6+
...tanstackConfig,
7+
{
8+
rules: {
9+
'import/no-cycle': 'off',
10+
'import/order': 'off',
11+
'sort-imports': 'off',
12+
'@typescript-eslint/array-type': 'off',
13+
'@typescript-eslint/require-await': 'off',
14+
'pnpm/json-enforce-catalog': 'off',
15+
},
16+
},
17+
{
18+
ignores: ['eslint.config.js', 'prettier.config.js'],
19+
},
20+
]

packages/create/src/frameworks/solid/toolchains/eslint/assets/eslint.config.js

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,19 @@
22

33
import { tanstackConfig } from "@tanstack/eslint-config";
44

5-
export default [...tanstackConfig];
5+
export default [
6+
...tanstackConfig,
7+
{
8+
rules: {
9+
"import/no-cycle": "off",
10+
"import/order": "off",
11+
"sort-imports": "off",
12+
"@typescript-eslint/array-type": "off",
13+
"@typescript-eslint/require-await": "off",
14+
"pnpm/json-enforce-catalog": "off",
15+
},
16+
},
17+
{
18+
ignores: ["eslint.config.js", "prettier.config.js"],
19+
},
20+
];

0 commit comments

Comments
 (0)