Skip to content

Commit 4f5b20f

Browse files
authored
fix: customTrigger getting defaulted to an empty component when not passed (#253)
* fix: customTrigger getting defaulted to a value even when not passed (#252) * Generate changeset
1 parent cf1b57a commit 4f5b20f

File tree

2 files changed

+11
-2
lines changed

2 files changed

+11
-2
lines changed

.changeset/nice-files-stick.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@tanstack/solid-devtools': patch
3+
---
4+
5+
Fixed customTrigger causing empty button when not passed

packages/solid-devtools/src/core.tsx

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,9 @@ export default function SolidDevtoolsCore({
148148
new TanStackDevtoolsCore({
149149
config: {
150150
...config,
151-
customTrigger: (el, props) => convertTrigger(el, props),
151+
customTrigger: config?.customTrigger
152+
? (el, props) => convertTrigger(el, props)
153+
: undefined,
152154
},
153155
eventBusConfig,
154156
plugins: pluginsMap(),
@@ -160,7 +162,9 @@ export default function SolidDevtoolsCore({
160162
devtools().setConfig({
161163
config: {
162164
...config,
163-
customTrigger: (el, props) => convertTrigger(el, props),
165+
customTrigger: config?.customTrigger
166+
? (el, props) => convertTrigger(el, props)
167+
: undefined,
164168
},
165169
})
166170
})

0 commit comments

Comments
 (0)