Skip to content

Commit c728cfe

Browse files
riccardoperrariccardoperra
committed
chore(angular-devtools): fix examples dependencies and knip issues
1 parent dc62a0d commit c728cfe

File tree

9 files changed

+112
-196
lines changed

9 files changed

+112
-196
lines changed

‎examples/angular/basic/package.json‎

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,18 +18,15 @@
1818
"@angular/platform-browser": "^21.2.0",
1919
"@angular/router": "^21.2.0",
2020
"@tanstack/angular-devtools": "^0.0.1",
21-
"@tanstack/devtools": "workspace:^",
22-
"@tanstack/devtools-event-client": "workspace:*",
21+
"@tanstack/devtools-event-client": "0.4.2",
2322
"rxjs": "~7.8.0",
2423
"tslib": "^2.3.0"
2524
},
2625
"devDependencies": {
2726
"@angular/build": "^21.2.0",
2827
"@angular/cli": "^21.2.0",
2928
"@angular/compiler-cli": "^21.2.0",
30-
"jsdom": "^28.0.0",
3129
"prettier": "^3.8.1",
32-
"typescript": "~5.9.2",
33-
"vitest": "^4.0.8"
30+
"typescript": "~5.9.2"
3431
}
3532
}

‎examples/angular/panel/package.json‎

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -17,21 +17,19 @@
1717
"@angular/forms": "^21.2.0",
1818
"@angular/platform-browser": "^21.2.0",
1919
"@angular/router": "^21.2.0",
20-
"@tanstack/angular-devtools": "workspace:*",
21-
"@tanstack/devtools": "workspace:^",
22-
"@tanstack/devtools-utils": "workspace:*",
23-
"@tanstack/devtools-event-client": "workspace:*",
20+
"@tanstack/angular-devtools": "^0.0.1",
21+
"@tanstack/devtools": "^0.10.13",
22+
"@tanstack/devtools-event-client": "0.4.2",
23+
"@tanstack/devtools-utils": "^0.3.3",
2424
"rxjs": "~7.8.0",
2525
"tslib": "^2.3.0"
2626
},
2727
"devDependencies": {
2828
"@angular/build": "^21.2.0",
2929
"@angular/cli": "^21.2.0",
3030
"@angular/compiler-cli": "^21.2.0",
31-
"jsdom": "^28.0.0",
3231
"ng-packagr": "^21.2.0",
3332
"prettier": "^3.8.1",
34-
"typescript": "~5.9.2",
35-
"vitest": "^4.0.8"
33+
"typescript": "~5.9.2"
3634
}
3735
}

‎examples/angular/with-devtools/package.json‎

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,18 +18,15 @@
1818
"@angular/platform-browser": "^21.2.0",
1919
"@angular/router": "^21.2.0",
2020
"@tanstack/angular-devtools": "^0.0.1",
21-
"@tanstack/devtools": "workspace:^",
22-
"@tanstack/devtools-event-client": "workspace:*",
21+
"@tanstack/devtools-event-client": "0.4.2",
2322
"rxjs": "~7.8.0",
2423
"tslib": "^2.3.0"
2524
},
2625
"devDependencies": {
2726
"@angular/build": "^21.2.0",
2827
"@angular/cli": "^21.2.0",
2928
"@angular/compiler-cli": "^21.2.0",
30-
"jsdom": "^28.0.0",
3129
"prettier": "^3.8.1",
32-
"typescript": "~5.9.2",
33-
"vitest": "^4.0.8"
30+
"typescript": "~5.9.2"
3431
}
3532
}

‎examples/angular/with-devtools/src/app/app.ts‎

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,9 @@
1-
import { ChangeDetectionStrategy, Component } from '@angular/core'
2-
import { createCounter } from './counter'
3-
import { TanStackDevtools } from '@tanstack/angular-devtools'
4-
import { injectDevtoolsPlugins } from '@tanstack/angular-devtools/provider'
1+
import { ChangeDetectionStrategy, Component } from '@angular/core';
2+
import { createCounter } from './counter';
3+
import { injectDevtoolsPlugins } from '@tanstack/angular-devtools/provider';
54

65
@Component({
76
selector: 'app-root',
8-
imports: [TanStackDevtools],
97
template: `
108
<div>
119
<h1>Custom plugins</h1>
@@ -21,11 +19,11 @@ import { injectDevtoolsPlugins } from '@tanstack/angular-devtools/provider'
2119
changeDetection: ChangeDetectionStrategy.OnPush,
2220
})
2321
export class App {
24-
readonly counter = createCounter()
25-
readonly devtoolsPlugins = injectDevtoolsPlugins()
22+
readonly counter = createCounter();
23+
readonly devtoolsPlugins = injectDevtoolsPlugins();
2624

27-
readonly increment = () => this.counter.increment()
28-
readonly decrement = () => this.counter.decrement()
25+
readonly increment = () => this.counter.increment();
26+
readonly decrement = () => this.counter.decrement();
2927

3028
readonly addPlugin = () => {
3129
this.devtoolsPlugins.update((n) => [
@@ -34,6 +32,6 @@ export class App {
3432
name: `Custom devtools ${n.length + 1}`,
3533
render: () => import('./devtools/custom-devtools-panel'),
3634
},
37-
])
38-
}
35+
]);
36+
};
3937
}

‎examples/react/bundling-repro/.wrangler/deploy/config.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
{ "configPath": "../../dist/server/wrangler.json", "auxiliaryWorkers": [] }
1+
{"configPath":"../../dist/server/wrangler.json","auxiliaryWorkers":[]}

‎knip.json‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,12 @@
1313
},
1414
"packages/solid-devtools": {
1515
"ignore": ["**/core.tsx"]
16+
},
17+
"packages/angular-devtools": {
18+
"entry": [
19+
"provider/**/*.ts",
20+
"src/**/*.ts"
21+
]
1622
}
1723
}
1824
}

‎packages/angular-devtools/package.json‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,8 @@
4040
},
4141
"files": [
4242
"dist",
43-
"src"
43+
"src",
44+
"provider"
4445
],
4546
"scripts": {
4647
"clean": "premove ./build ./dist",
@@ -49,17 +50,16 @@
4950
"test:lib:dev": "pnpm test:lib --watch",
5051
"test:types": "tsc",
5152
"test:build": "publint --strict",
52-
"build": "ng-packagr -p ng-package.json -c tsconfig.build.json && rm -rf ./dist/package.json"
53+
"build": "ng-packagr -p ng-package.json -c tsconfig.build.json && rm -rf ./dist/package.json && rm -rf ./dist/provider/package.json"
5354
},
5455
"dependencies": {
5556
"@tanstack/devtools": "workspace:*",
56-
"tslib": "^2.8.1"
57+
"tslib": "^2.3.0"
5758
},
5859
"devDependencies": {
59-
"@analogjs/vite-plugin-angular": "^2.3.1",
60-
"@angular/core": "^21.0.0",
60+
"@angular/core": "^21.2.0",
6161
"ng-packagr": "^21.2.0",
62-
"tslib": "^2.8.1"
62+
"tslib": "^2.3.0"
6363
},
6464
"peerDependencies": {
6565
"@angular/core": ">=21.0.0"

‎packages/angular-devtools/vite.config.ts‎

Lines changed: 12 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
import { defineConfig, mergeConfig } from 'vitest/config'
22
import { tanstackViteConfig } from '@tanstack/vite-config'
3-
import angular from '@analogjs/vite-plugin-angular'
43
import packageJson from './package.json'
5-
import type { UserConfig } from 'vite'
64

75
const config = defineConfig({
86
plugins: [],
@@ -20,36 +18,16 @@ const config = defineConfig({
2018

2119
export default mergeConfig(
2220
config,
23-
mergeConfig(
24-
tanstackViteConfig({
25-
entry: ['./src/index.ts'],
26-
srcDir: './src',
27-
externalDeps: [
28-
/^@angular\/.*/,
29-
'rxjs',
30-
'rxjs/operators',
31-
'zone.js',
32-
'ng-packagr',
33-
],
34-
cjs: false,
35-
}),
36-
{
37-
plugins: [
38-
angular({
39-
jit: false,
40-
}),
41-
],
42-
resolve: {
43-
mainFields: ['module'],
44-
},
45-
build: {
46-
rollupOptions: {
47-
output: {
48-
// Produce a single file bundle
49-
preserveModules: false,
50-
},
51-
},
52-
},
53-
} as UserConfig,
54-
),
21+
tanstackViteConfig({
22+
entry: ['./src/index.ts'],
23+
srcDir: './src',
24+
externalDeps: [
25+
/^@angular\/.*/,
26+
'rxjs',
27+
'rxjs/operators',
28+
'zone.js',
29+
'ng-packagr',
30+
],
31+
cjs: false,
32+
}),
5533
)

0 commit comments

Comments
 (0)