Skip to content

Commit cd9e8ef

Browse files
committed
fix: resolve lint, knip, and sherif issues
- Fix array-type ESLint rule in angular-devtools - Fix import/consistent-type-specifier-style in devtools-utils angular - Sort peerDependencies alphabetically (sherif) - Remove unused devDependencies flagged by knip - Remove angularCompilerOptions from tsconfig (not using ngc)
1 parent 94713c3 commit cd9e8ef

File tree

7 files changed

+19
-166
lines changed

7 files changed

+19
-166
lines changed

packages/angular-devtools/package.json

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -52,11 +52,7 @@
5252
},
5353
"devDependencies": {
5454
"@angular/compiler": "^20.0.0",
55-
"@angular/compiler-cli": "^20.0.0",
56-
"@angular/core": "^20.0.0",
57-
"@angular/platform-browser": "^20.0.0",
58-
"@angular/platform-browser-dynamic": "^20.0.0",
59-
"zone.js": "^0.15.0"
55+
"@angular/core": "^20.0.0"
6056
},
6157
"peerDependencies": {
6258
"@angular/core": ">=19.0.0",

packages/angular-devtools/src/devtools.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ export class TanStackDevtoolsComponent {
3333
private injector = inject(EnvironmentInjector)
3434
private destroyRef = inject(DestroyRef)
3535

36-
private componentRefs: ComponentRef<any>[] = []
36+
private componentRefs: Array<ComponentRef<any>> = []
3737
private devtools: TanStackDevtoolsCore | null = null
3838

3939
constructor() {

packages/angular-devtools/tsconfig.json

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,5 @@
33
"compilerOptions": {
44
"experimentalDecorators": true
55
},
6-
"include": ["src", "eslint.config.js", "vite.config.ts", "tests"],
7-
"angularCompilerOptions": {
8-
"enableI18nLegacyMessageIdFormat": false,
9-
"strictInjectionParameters": true,
10-
"strictInputAccessModifiers": true,
11-
"strictTemplates": true,
12-
"compilationMode": "partial"
13-
}
6+
"include": ["src", "eslint.config.js", "vite.config.ts", "tests"]
147
}

packages/devtools-utils/package.json

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -69,14 +69,17 @@
6969
"@tanstack/devtools-ui": "workspace:^"
7070
},
7171
"peerDependencies": {
72+
"@angular/core": ">=19.0.0",
7273
"@types/react": ">=17.0.0",
7374
"preact": ">=10.0.0",
7475
"react": ">=17.0.0",
7576
"solid-js": ">=1.9.7",
76-
"vue": ">=3.2.0",
77-
"@angular/core": ">=19.0.0"
77+
"vue": ">=3.2.0"
7878
},
7979
"peerDependenciesMeta": {
80+
"@angular/core": {
81+
"optional": true
82+
},
8083
"@types/react": {
8184
"optional": true
8285
},
@@ -91,9 +94,6 @@
9194
},
9295
"vue": {
9396
"optional": true
94-
},
95-
"@angular/core": {
96-
"optional": true
9797
}
9898
},
9999
"files": [
@@ -111,10 +111,6 @@
111111
"build": "vite build && vite build --config vite.config.preact.ts && vite build --config vite.config.vue.ts && vite build --config vite.config.angular.ts && tsup "
112112
},
113113
"devDependencies": {
114-
"@angular/compiler": "^20.0.0",
115-
"@angular/compiler-cli": "^20.0.0",
116-
"@angular/core": "^20.0.0",
117-
"@angular/platform-browser": "^20.0.0",
118114
"tsup": "^8.5.0",
119115
"tsup-preset-solid": "^2.2.0",
120116
"vite-plugin-solid": "^2.11.8"

packages/devtools-utils/src/angular/panel.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@ import {
55
afterNextRender,
66
inject,
77
input,
8-
type Type,
98
} from '@angular/core'
9+
import type { Type } from '@angular/core'
1010

1111
export interface DevtoolsPanelProps {
1212
theme?: 'dark' | 'light' | 'system'

packages/devtools-utils/src/angular/plugin.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
import { Component, type Type } from '@angular/core'
1+
import { Component } from '@angular/core'
2+
import type { Type } from '@angular/core'
23

34
@Component({
45
selector: 'noop-component',

pnpm-lock.yaml

Lines changed: 8 additions & 141 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)