Feat SEO Section (Overview, Heading Structure, Links & JSON LD Preview) #416
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@tanstack/devtools': patch | ||
| --- | ||
|
|
||
| Introduce a new SEO tab in devtools: live head-driven social and SERP previews, structured data (JSON-LD), heading and link analysis, plus an overview that scores and links into each section. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| import { onCleanup, onMount } from 'solid-js' | ||
|
|
||
| const LOCATION_CHANGE_EVENT = 'tanstack-devtools:locationchange' | ||
|
|
||
| type LocationChangeListener = () => void | ||
|
|
||
| const listeners = new Set<LocationChangeListener>() | ||
|
|
||
| let lastHref = '' | ||
| let teardownLocationObservation: (() => void) | undefined | ||
|
|
||
| function emitLocationChangeIfNeeded() { | ||
| const nextHref = window.location.href | ||
| if (nextHref === lastHref) return | ||
| lastHref = nextHref | ||
| listeners.forEach((listener) => listener()) | ||
| } | ||
|
|
||
| function dispatchLocationChangeEvent() { | ||
| window.dispatchEvent(new Event(LOCATION_CHANGE_EVENT)) | ||
| } | ||
|
|
||
| function observeLocationChanges() { | ||
| if (teardownLocationObservation) return | ||
|
|
||
| lastHref = window.location.href | ||
|
|
||
| const originalPushState = window.history.pushState | ||
| const originalReplaceState = window.history.replaceState | ||
|
|
||
| const handleLocationSignal = () => { | ||
| emitLocationChangeIfNeeded() | ||
| } | ||
|
|
||
| window.history.pushState = function (...args) { | ||
| originalPushState.apply(this, args) | ||
| dispatchLocationChangeEvent() | ||
| } | ||
|
|
||
| window.history.replaceState = function (...args) { | ||
| originalReplaceState.apply(this, args) | ||
| dispatchLocationChangeEvent() | ||
| } | ||
|
|
||
| window.addEventListener('popstate', handleLocationSignal) | ||
| window.addEventListener('hashchange', handleLocationSignal) | ||
| window.addEventListener(LOCATION_CHANGE_EVENT, handleLocationSignal) | ||
|
|
||
| teardownLocationObservation = () => { | ||
| window.history.pushState = originalPushState | ||
| window.history.replaceState = originalReplaceState | ||
| window.removeEventListener('popstate', handleLocationSignal) | ||
| window.removeEventListener('hashchange', handleLocationSignal) | ||
| window.removeEventListener(LOCATION_CHANGE_EVENT, handleLocationSignal) | ||
| teardownLocationObservation = undefined | ||
| } | ||
|
Comment on lines
+28
to
+56
There was a problem hiding this comment. Only restore history methods if this hook still owns them. Lines 50-51 unconditionally put back the originals. If something else wraps 🛠️ Suggested fix- window.history.pushState = function (...args) {
+ const pushStateWrapper: History['pushState'] = function (...args) {
originalPushState.apply(this, args)
dispatchLocationChangeEvent()
}
+ window.history.pushState = pushStateWrapper
- window.history.replaceState = function (...args) {
+ const replaceStateWrapper: History['replaceState'] = function (...args) {
originalReplaceState.apply(this, args)
dispatchLocationChangeEvent()
}
+ window.history.replaceState = replaceStateWrapper
...
teardownLocationObservation = () => {
- window.history.pushState = originalPushState
- window.history.replaceState = originalReplaceState
+ if (window.history.pushState === pushStateWrapper) {
+ window.history.pushState = originalPushState
+ }
+ if (window.history.replaceState === replaceStateWrapper) {
+ window.history.replaceState = originalReplaceState
+ }
window.removeEventListener('popstate', handleLocationSignal)
window.removeEventListener('hashchange', handleLocationSignal)
window.removeEventListener(LOCATION_CHANGE_EVENT, handleLocationSignal)🤖 Prompt for AI Agents |
||
| } | ||
|
|
||
| export function useLocationChanges(onChange: () => void) { | ||
| onMount(() => { | ||
| observeLocationChanges() | ||
| listeners.add(onChange) | ||
|
|
||
| onCleanup(() => { | ||
| listeners.delete(onChange) | ||
| if (listeners.size === 0) teardownLocationObservation?.() | ||
| }) | ||
| }) | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't ship a localhost canonical URL.
Line 37 hard-codes
http://localhost:3005, so the published example will canonicalize to the wrong origin outside local dev. That gives crawlers — and this new SEO tab — a false signal. Use the deployed example URL here, or drop the canonical tag from this fixture.🤖 Prompt for AI Agents