Skip to content

Commit 9ec0fc6

Browse files
authored
test(react-query/useSuspenseQueries): remove unnecessary 'act' from background refetch and post-unmount assertions (#10211)
1 parent 4b1febd commit 9ec0fc6

1 file changed

Lines changed: 9 additions & 9 deletions

File tree

packages/react-query/src/__tests__/useSuspenseQueries.test.tsx

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -243,7 +243,7 @@ describe('useSuspenseQueries', () => {
243243
expect(onSuspend).toHaveBeenCalledTimes(1)
244244
expect(onQueriesResolution).toHaveBeenCalledTimes(1)
245245

246-
await act(() => vi.advanceTimersByTimeAsync(100))
246+
await vi.advanceTimersByTimeAsync(100)
247247

248248
expect(onQueriesResolution).toHaveBeenCalledTimes(1)
249249
expect(onQueriesResolution).toHaveBeenLastCalledWith({
@@ -719,10 +719,10 @@ describe('useSuspenseQueries 2', () => {
719719
fireEvent.click(rendered.getByText('hide'))
720720
expect(rendered.getByText('page2')).toBeInTheDocument()
721721
// wait for query to be resolved
722-
await act(() => vi.advanceTimersByTimeAsync(3000))
722+
await vi.advanceTimersByTimeAsync(3000)
723723
expect(queryClient.getQueryData(key)).toBe('data')
724724
// wait for gc
725-
await act(() => vi.advanceTimersByTimeAsync(1000))
725+
await vi.advanceTimersByTimeAsync(1000)
726726
expect(queryClient.getQueryData(key)).toBe(undefined)
727727
})
728728
})
@@ -878,10 +878,10 @@ describe('useSuspenseQueries 2', () => {
878878
expect(rendered.getByText('data2: data2')).toBeInTheDocument()
879879

880880
// key1 stale timer fires, triggering background refetch
881-
await act(() => vi.advanceTimersByTimeAsync(1000))
881+
await vi.advanceTimersByTimeAsync(1000)
882882

883883
// key1 background refetch completes: key1 updates to fresh data
884-
await act(() => vi.advanceTimersByTimeAsync(2000))
884+
await vi.advanceTimersByTimeAsync(2000)
885885

886886
expect(rendered.getByText('data1: data1')).toBeInTheDocument()
887887
expect(rendered.getByText('data2: data2')).toBeInTheDocument()
@@ -931,10 +931,10 @@ describe('useSuspenseQueries 2', () => {
931931
expect(rendered.getByText('data2: cached')).toBeInTheDocument()
932932

933933
// key2 stale timer fires, triggering background refetch
934-
await act(() => vi.advanceTimersByTimeAsync(1000))
934+
await vi.advanceTimersByTimeAsync(1000)
935935

936936
// key2 background refetch completes: key2 updates to fresh data
937-
await act(() => vi.advanceTimersByTimeAsync(1000))
937+
await vi.advanceTimersByTimeAsync(1000)
938938

939939
expect(rendered.getByText('data1: data1')).toBeInTheDocument()
940940
expect(rendered.getByText('data2: data2')).toBeInTheDocument()
@@ -1032,13 +1032,13 @@ describe('useSuspenseQueries 2', () => {
10321032
expect(rendered.getByText('data2: cached2')).toBeInTheDocument()
10331033

10341034
// key2 background refetch completes
1035-
await act(() => vi.advanceTimersByTimeAsync(11))
1035+
await vi.advanceTimersByTimeAsync(11)
10361036

10371037
expect(rendered.getByText('data1: cached1')).toBeInTheDocument()
10381038
expect(rendered.getByText('data2: data2')).toBeInTheDocument()
10391039

10401040
// key1 background refetch completes
1041-
await act(() => vi.advanceTimersByTimeAsync(10))
1041+
await vi.advanceTimersByTimeAsync(10)
10421042

10431043
expect(rendered.getByText('data1: data1')).toBeInTheDocument()
10441044
expect(rendered.getByText('data2: data2')).toBeInTheDocument()

0 commit comments

Comments
 (0)