test(query-devtools/Devtools): add tests for settings menu (#10690)

* test(query-devtools/Devtools): add tests for settings menu

* ci: apply automated fixes

* test(query-devtools/Devtools): fail fast with 'expect' instead of conditional guards on selector lookups

* test(query-devtools/Devtools): coerce 'el.textContent' to string for 'TS18047' under strict 'vue-tsc' build

* test(query-devtools/Devtools): remove redundant 'should render the settings button' covered by other settings menu tests

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

Author: sukvvon

packages/query-devtools/src/__tests__/Devtools.test.tsx

@@ -34,19 +34,6 @@ describe('Devtools', () => {
   beforeEach(() => {
     vi.useFakeTimers()
     previousRootFontSize = document.documentElement.style.fontSize
-    // jsdom doesn't implement `PointerEvent`; the DropdownMenu trigger checks
-    // `e.pointerType !== 'touch'` on pointerdown to decide whether to open,
-    // so we polyfill it as a thin wrapper around `MouseEvent`.
-    if (typeof window.PointerEvent === 'undefined') {
-      class FakePointerEvent extends MouseEvent {
-        pointerType: string
-        constructor(type: string, init: PointerEventInit = {}) {
-          super(type, init)
-          this.pointerType = init.pointerType ?? 'mouse'
-        }
-      }
-      vi.stubGlobal('PointerEvent', FakePointerEvent)
-    }
     vi.stubGlobal('localStorage', {
       getItem: (key: string) =>
         Object.prototype.hasOwnProperty.call(storage, key)
@@ -804,4 +791,152 @@ describe('Devtools', () => {
       expect(afterSecondToggle).toBe(afterFirstToggle === '1' ? '-1' : '1')
     })
   })
+
+  describe('settings menu', () => {
+    it('should show "Position" sub-trigger when the settings menu is opened', () => {
+      const rendered = renderDevtools({ initialIsOpen: true })
+
+      fireEvent.keyDown(rendered.getByLabelText('Open settings menu'), {
+        key: 'Enter',
+      })
+
+      // The menu is rendered through a Portal mounted on `document.body`,
+      // outside `rendered.container`, so look it up via `document` directly.
+      expect(
+        document.querySelector('.tsqd-settings-menu-sub-trigger-position'),
+      ).not.toBeNull()
+    })
+
+    it('should open "Position" sub-menu when the sub-trigger is activated', () => {
+      const rendered = renderDevtools({ initialIsOpen: true })
+
+      fireEvent.keyDown(rendered.getByLabelText('Open settings menu'), {
+        key: 'Enter',
+      })
+
+      const subTrigger = document.querySelector<HTMLElement>(
+        '.tsqd-settings-menu-sub-trigger-position',
+      )
+      expect(subTrigger).not.toBeNull()
+      fireEvent.keyDown(subTrigger!, { key: 'ArrowRight' })
+
+      expect(
+        document.querySelector('[aria-label="Position settings"]'),
+      ).not.toBeNull()
+    })
+
+    it('should persist "position" when a position radio item is selected', () => {
+      const rendered = renderDevtools({ initialIsOpen: true })
+
+      fireEvent.keyDown(rendered.getByLabelText('Open settings menu'), {
+        key: 'Enter',
+      })
+
+      const subTrigger = document.querySelector<HTMLElement>(
+        '.tsqd-settings-menu-sub-trigger-position',
+      )
+      expect(subTrigger).not.toBeNull()
+      fireEvent.keyDown(subTrigger!, { key: 'ArrowRight' })
+
+      const topItem = document.querySelector<HTMLElement>(
+        '.tsqd-settings-menu-position-btn-top',
+      )
+      expect(topItem).not.toBeNull()
+      fireEvent.keyDown(topItem!, { key: 'Enter' })
+
+      expect(localStorage.getItem('TanstackQueryDevtools.position')).toBe('top')
+    })
+
+    it('should open "Theme" sub-menu when the sub-trigger is activated', () => {
+      const rendered = renderDevtools({ initialIsOpen: true })
+
+      fireEvent.keyDown(rendered.getByLabelText('Open settings menu'), {
+        key: 'Enter',
+      })
+
+      const themeTrigger = Array.from(
+        document.querySelectorAll<HTMLElement>(
+          '.tsqd-settings-menu-sub-trigger',
+        ),
+      ).find((el) => String(el.textContent).includes('Theme'))
+      expect(themeTrigger).not.toBeUndefined()
+      fireEvent.keyDown(themeTrigger!, { key: 'ArrowRight' })
+
+      expect(
+        document.querySelector('[aria-label="Theme preference"]'),
+      ).not.toBeNull()
+    })
+
+    it('should persist "theme_preference" when a theme radio item is selected', () => {
+      const rendered = renderDevtools({ initialIsOpen: true })
+
+      fireEvent.keyDown(rendered.getByLabelText('Open settings menu'), {
+        key: 'Enter',
+      })
+
+      const themeTrigger = Array.from(
+        document.querySelectorAll<HTMLElement>(
+          '.tsqd-settings-menu-sub-trigger',
+        ),
+      ).find((el) => String(el.textContent).includes('Theme'))
+      expect(themeTrigger).not.toBeUndefined()
+      fireEvent.keyDown(themeTrigger!, { key: 'ArrowRight' })
+
+      const themeMenu = document.querySelector(
+        '[aria-label="Theme preference"]',
+      )
+      const lightItem = Array.from(
+        themeMenu?.querySelectorAll<HTMLElement>('[role="menuitemradio"]') ??
+          [],
+      ).find((el) => String(el.textContent).includes('Light'))
+      expect(lightItem).not.toBeUndefined()
+      fireEvent.keyDown(lightItem!, { key: 'Enter' })
+
+      expect(
+        localStorage.getItem('TanstackQueryDevtools.theme_preference'),
+      ).toBe('light')
+    })
+
+    it('should open "Hide disabled queries" sub-menu when the sub-trigger is activated', () => {
+      const rendered = renderDevtools({ initialIsOpen: true })
+
+      fireEvent.keyDown(rendered.getByLabelText('Open settings menu'), {
+        key: 'Enter',
+      })
+
+      const hideTrigger = document.querySelector<HTMLElement>(
+        '.tsqd-settings-menu-sub-trigger-disabled-queries',
+      )
+      expect(hideTrigger).not.toBeNull()
+      fireEvent.keyDown(hideTrigger!, { key: 'ArrowRight' })
+
+      expect(
+        document.querySelector('[aria-label="Hide disabled queries setting"]'),
+      ).not.toBeNull()
+    })
+
+    it('should persist "hideDisabledQueries" when a hide-disabled radio item is selected', () => {
+      const rendered = renderDevtools({ initialIsOpen: true })
+
+      fireEvent.keyDown(rendered.getByLabelText('Open settings menu'), {
+        key: 'Enter',
+      })
+
+      const hideTrigger = document.querySelector<HTMLElement>(
+        '.tsqd-settings-menu-sub-trigger-disabled-queries',
+      )
+      expect(hideTrigger).not.toBeNull()
+      fireEvent.keyDown(hideTrigger!, { key: 'ArrowRight' })
+
+      const hideItem = document.querySelector<HTMLElement>(
+        '.tsqd-settings-menu-position-btn-hide',
+      )
+      expect(hideItem).not.toBeNull()
+      fireEvent.keyDown(hideItem!, { key: 'Enter' })
+
+      expect(
+        localStorage.getItem('TanstackQueryDevtools.hideDisabledQueries'),
+      ).toBe('true')
+    })
+  })
 })