Skip to content

test({solid,vue}-query/infiniteQueryOptions): add runtime test for 'infiniteQueryOptions'#10406

Merged
sukvvon merged 1 commit intomainfrom
test/solid-vue-query-add-infiniteQueryOptions-runtime-test
Apr 6, 2026
Merged

test({solid,vue}-query/infiniteQueryOptions): add runtime test for 'infiniteQueryOptions'#10406
sukvvon merged 1 commit intomainfrom
test/solid-vue-query-add-infiniteQueryOptions-runtime-test

Conversation

@sukvvon
Copy link
Copy Markdown
Collaborator

@sukvvon sukvvon commented Apr 6, 2026

🎯 Changes

  • Add runtime test for infiniteQueryOptions in solid-query and vue-query
  • Follows the existing pattern from react-query and svelte-query
  • Verifies that infiniteQueryOptions returns the object received as a parameter without any modification

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Release Notes

No user-facing changes in this release. Internal testing infrastructure was enhanced to improve code reliability and maintainability.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 6, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e32895ce-53b3-4473-aa25-c2e5dc354c98

📥 Commits

Reviewing files that changed from the base of the PR and between e919c54 and 5af2e8a.

📒 Files selected for processing (2)
  • packages/solid-query/src/__tests__/infiniteQueryOptions.test.tsx
  • packages/vue-query/src/__tests__/infiniteQueryOptions.test.ts

📝 Walkthrough

Walkthrough

Two new test files added to solid-query and vue-query packages, each verifying that the infiniteQueryOptions function returns the exact same object reference when provided with properly structured options containing queryKey, queryFn, getNextPageParam, and initialPageParam.

Changes

Cohort / File(s) Summary
Test Files for infiniteQueryOptions
packages/solid-query/src/__tests__/infiniteQueryOptions.test.tsx, packages/vue-query/src/__tests__/infiniteQueryOptions.test.ts
New test suites added to verify that infiniteQueryOptions returns the exact same object reference (identity check with toBe) when called with a properly formatted options object.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Poem

🐰✨ A test so small, yet brings delight,
Objects staying true, references held tight,
infinite pages shall never stray,
The bunny's assertions pass the day!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: adding runtime tests for infiniteQueryOptions in solid-query and vue-query packages.
Description check ✅ Passed The description follows the required template structure with all major sections completed: Changes (detailed), Checklist (mostly checked), and Release Impact (marked as dev-only).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch test/solid-vue-query-add-infiniteQueryOptions-runtime-test

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link
Copy Markdown

nx-cloud bot commented Apr 6, 2026

View your CI Pipeline Execution ↗ for commit 5af2e8a

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 2m 3s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 1s View ↗

☁️ Nx Cloud last updated this comment at 2026-04-06 12:45:26 UTC

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 6, 2026

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Apr 6, 2026

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@10406

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@10406

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@10406

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@10406

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@10406

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@10406

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@10406

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@10406

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@10406

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@10406

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@10406

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@10406

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@10406

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@10406

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@10406

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@10406

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@10406

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@10406

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@10406

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@10406

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@10406

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@10406

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@10406

commit: 5af2e8a

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 6, 2026

size-limit report 📦

Path Size
react full 11.98 KB (0%)
react minimal 9.01 KB (0%)

@sukvvon sukvvon merged commit 1a6fdd0 into main Apr 6, 2026
10 checks passed
@sukvvon sukvvon deleted the test/solid-vue-query-add-infiniteQueryOptions-runtime-test branch April 6, 2026 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant