test({solid,svelte}-query): add missing 'initialData' describe nesting in type test files by sukvvon · Pull Request #10412 · TanStack/query

sukvvon · 2026-04-06T14:52:54Z

🎯 Changes

Add missing describe('initialData') nesting in solid-query/useQuery.test-d.tsx and svelte-query/createQuery.test-d.ts
Nest Config object overload, Query key overload, and Query key and func under initialData
Matches react-query/useQuery.test-d.tsx and preact-query/useQuery.test-d.tsx structure

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Tests
- Reorganized type-level test suite structure for improved organization.

…g in type test files

coderabbitai · 2026-04-06T14:53:10Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 98d718a2-ce32-45ea-a562-9f1c7def60e3

📥 Commits

Reviewing files that changed from the base of the PR and between 2a4fc9f and 4e6e0b3.

📒 Files selected for processing (2)

packages/solid-query/src/__tests__/useQuery.test-d.tsx
packages/svelte-query/tests/createQuery.test-d.ts

📝 Walkthrough

Walkthrough

Type-level test files for Solid Query and Svelte Query are reorganized by introducing a top-level describe('initialData', ...) grouping and nesting existing test cases beneath it. The actual test assertions and type expectations remain unchanged.

Changes

Cohort / File(s)	Summary
Type test reorganization `packages/solid-query/src/__tests__/useQuery.test-d.tsx`, `packages/svelte-query/tests/createQuery.test-d.ts`	Introduced top-level `describe('initialData')` block and nested existing test suites (`Config object overload`, `Query key overload`, `Query key and func`) under it. Type assertions and test logic remain unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

test({solid,svelte}-query): fix incorrect 'describe' name from 'initialData' to match file name #10410: Modifies the same test files' top-level describe structure for initialData-related type tests, potentially introducing or further refining the organizational pattern.
test(angular-query-experimental): fix 'describe' nesting and naming in type test files #10411: Makes the same test-structure change—adding a top-level describe('initialData') nesting in both Solid and Svelte query type-test files.

Poem

🐰 Nested tests so neat and tidy,
Initial data grouped up nicely,
Structure reorganized with care,
No logic changed, just files laid bare! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: adding missing 'initialData' describe nesting in type test files for solid-query and svelte-query.
Description check	✅ Passed	The description includes all required template sections with relevant details: changes are clearly listed, the checklist is mostly complete, and release impact is properly marked.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch test/solid-svelte-query-add-initialData-describe-nesting

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

nx-cloud · 2026-04-06T14:53:19Z

View your CI Pipeline Execution ↗ for commit 4e6e0b3

Command	Status	Duration	Result
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	1s	View ↗
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	10s	View ↗

☁️ Nx Cloud last updated this comment at 2026-04-06 14:55:55 UTC

github-actions · 2026-04-06T14:53:52Z

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

pkg-pr-new · 2026-04-06T14:55:45Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@10412

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@10412

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@10412

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@10412

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@10412

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@10412

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@10412

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@10412

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@10412

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@10412

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@10412

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@10412

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@10412

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@10412

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@10412

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@10412

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@10412

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@10412

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@10412

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@10412

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@10412

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@10412

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@10412

commit: 4e6e0b3

github-actions · 2026-04-06T14:55:56Z

size-limit report 📦

Path	Size
react full	11.98 KB (0%)
react minimal	9.01 KB (0%)

test({solid,svelte}-query): add missing 'initialData' describe nestin…

76c619c

…g in type test files

github-actions bot added package: solid-query package: svelte-query labels Apr 6, 2026

ci: apply automated fixes

4e6e0b3

sukvvon self-assigned this Apr 6, 2026

sukvvon merged commit cf82e86 into main Apr 6, 2026
8 checks passed

sukvvon deleted the test/solid-svelte-query-add-initialData-describe-nesting branch April 6, 2026 14:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test({solid,svelte}-query): add missing 'initialData' describe nesting in type test files#10412

test({solid,svelte}-query): add missing 'initialData' describe nesting in type test files#10412
sukvvon merged 2 commits intomainfrom
test/solid-svelte-query-add-initialData-describe-nesting

sukvvon commented Apr 6, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Apr 6, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Uh oh!

nx-cloud bot commented Apr 6, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Apr 6, 2026 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Apr 6, 2026

Uh oh!

github-actions bot commented Apr 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

sukvvon commented Apr 6, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Apr 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Uh oh!

nx-cloud bot commented Apr 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 Changeset Version Preview

Uh oh!

pkg-pr-new bot commented Apr 6, 2026

Uh oh!

github-actions bot commented Apr 6, 2026

size-limit report 📦

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Apr 6, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Apr 6, 2026 •

edited

Loading

nx-cloud bot commented Apr 6, 2026 •

edited

Loading

github-actions bot commented Apr 6, 2026 •

edited

Loading