Skip to content
Merged
8 changes: 7 additions & 1 deletion packages/angular-query-experimental/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,12 @@
"strictStandalone": true,
"strictTemplates": true
},
"include": ["src", "scripts", "test-setup.ts", "*.config.*", "package.json"],
"include": [
"src",
"scripts",
"test-setup.ts",
"*.config.{ts,js,mjs,cjs}",
"package.json"
],
"references": [{ "path": "../query-core" }, { "path": "../query-devtools" }]
}
7 changes: 6 additions & 1 deletion packages/angular-query-persist-client/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,12 @@
"useDefineForClassFields": false,
"target": "ES2022"
},
"include": ["src", "test-setup.ts", "*.config.*", "package.json"],
"include": [
"src",
"test-setup.ts",
"*.config.{ts,js,mjs,cjs}",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🌐 Web query:

Does TypeScript support brace expansion in tsconfig.json includeglobs (e.g.,"*.config.{ts,js,mjs,cjs}")? Please cite official TypeScript documentation or source code behavior.

💡 Result:

No. TypeScript’s tsconfig.json include/exclude glob patterns do not support Bash-style brace expansion like {ts,js,mjs,cjs}. TypeScript documents include as “filenames or patterns” and specifies only wildcard characters , ?, and / for its tsconfig globbing. The official docs list those supported wildcard characters and do not mention brace sets as a supported feature. Additionally, TypeScript’s own issue tracker documents that “curly braces aren't supported in our glob patterns” in the context of tsconfig include patterns. Practical implication: a pattern such as ".config.{ts,js,mjs,cjs}" will not be interpreted as multiple extensions by the TypeScript compiler; you need to spell out separate include patterns (e.g., ".config.ts", ".config.js", etc.) or use other mechanisms (like multiple tsconfig files / tooling) to cover those extensions.

Citations:


Brace expansion is not supported in tsconfig.json include globs—update Line 13 to use explicit patterns.

TypeScript's glob patterns in tsconfig.json support only *, ?, and / wildcards. The pattern "*.config.{ts,js,mjs,cjs}" will not be interpreted as multiple extensions; use separate entries instead to ensure all intended config files are included.

Suggested fix
   "include": [
     "src",
     "test-setup.ts",
-    "*.config.{ts,js,mjs,cjs}",
+    "*.config.ts",
+    "*.config.js",
+    "*.config.mjs",
+    "*.config.cjs",
     "package.json"
   ],
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"*.config.{ts,js,mjs,cjs}",
"include": [
"src",
"test-setup.ts",
"*.config.ts",
"*.config.js",
"*.config.mjs",
"*.config.cjs",
"package.json"
],
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@packages/angular-query-persist-client/tsconfig.json` at line 13, The include
glob in tsconfig.json currently uses brace expansion
("*.config.{ts,js,mjs,cjs}") which TypeScript doesn't support; update the
include array entry to four explicit patterns instead of the brace form (e.g.,
add "*.config.ts", "*.config.js", "*.config.mjs", "*.config.cjs") so the include
in tsconfig.json correctly matches all intended config file extensions.

"package.json"
],
"references": [
{ "path": "../angular-query-experimental" },
{ "path": "../query-persist-client-core" }
Expand Down
2 changes: 1 addition & 1 deletion packages/eslint-plugin-query/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@
"outDir": "./dist-ts",
"rootDir": "."
},
"include": ["src", "*.config.*", "package.json"]
"include": ["src", "*.config.{ts,js,mjs,cjs}", "package.json"]
}
7 changes: 6 additions & 1 deletion packages/preact-query-devtools/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@
"jsx": "react-jsx",
"jsxImportSource": "preact"
},
"include": ["src", "test-setup.ts", "*.config.*", "package.json"],
"include": [
"src",
"test-setup.ts",
"*.config.{ts,js,mjs,cjs}",
"package.json"
],
"references": [{ "path": "../query-devtools" }, { "path": "../preact-query" }]
}
7 changes: 6 additions & 1 deletion packages/preact-query-persist-client/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,12 @@
"jsx": "react-jsx",
"jsxImportSource": "preact"
},
"include": ["src", "test-setup.ts", "*.config.*", "package.json"],
"include": [
"src",
"test-setup.ts",
"*.config.{ts,js,mjs,cjs}",
"package.json"
],
"references": [
{ "path": "../query-persist-client-core" },
{ "path": "../preact-query" }
Expand Down
7 changes: 6 additions & 1 deletion packages/preact-query/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,10 @@
"jsx": "react-jsx",
"jsxImportSource": "preact"
},
"include": ["src", "test-setup.ts", "*.config.*", "package.json"]
"include": [
"src",
"test-setup.ts",
"*.config.{ts,js,mjs,cjs}",
"package.json"
]
}
2 changes: 1 addition & 1 deletion packages/query-async-storage-persister/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@
"outDir": "./dist-ts",
"rootDir": "."
},
"include": ["src", "*.config.*", "package.json"],
"include": ["src", "*.config.{ts,js,mjs,cjs}", "package.json"],
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🌐 Web query:

In TypeScript tsconfig.json, does the includeglob syntax support brace expansion patterns like*.config.{ts,js,mjs,cjs}? Please cite official TypeScript documentation or source references for supported glob tokens.

💡 Result:

No. TypeScript’s tsconfig.json “include” glob syntax does not support brace expansion patterns like *.config.{ts,js,mjs,cjs}. Official TypeScript documentation states that “include”/“exclude” support only the wildcard characters * and ? and the special recursive token /, and it describes those as the supported glob wildcards. It does not mention brace/group expansion as supported. TypeScript’s own source for the include/exclude glob feature also lists supported tokens as , ?, and /, and explicitly notes that character escape sequences and character ranges are not supported—indicating that its glob syntax is intentionally limited rather than full brace-expansion syntax. Additionally, TypeScript maintainers have discussed brace usage not working in tsconfig patterns (e.g., curly braces not supported in glob patterns), corroborating that .{...} style expansion isn’t handled. Supported tokens (from TypeScript docs/source): - * matches zero or more characters (excluding directory separators) - ? matches any one character (excluding directory separators) - / recursively matches any subdirectory Therefore, to include multiple extensions in tsconfig.json, you need separate patterns (e.g., /.ts, /.js, etc.) rather than a single brace-expanded pattern.

Citations:


Update include pattern: brace expansion {ts,js,mjs,cjs} is not supported in TypeScript globs.

TypeScript's tsconfig.json include patterns support only *, ?, and / wildcards. The pattern *.config.{ts,js,mjs,cjs} will be treated literally and won't match any files, silently excluding intended config files from this project.

Use separate patterns instead:

"include": ["src", "*.config.ts", "*.config.js", "*.config.mjs", "*.config.cjs", "package.json"]
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@packages/query-async-storage-persister/tsconfig.json` at line 7, The
tsconfig.json "include" pattern uses unsupported brace expansion
("*.config.{ts,js,mjs,cjs}") so those config files are not matched; update the
"include" array (the include property in tsconfig.json) to list each glob
separately (e.g., "*.config.ts", "*.config.js", "*.config.mjs", "*.config.cjs")
alongside "src" and "package.json" so TypeScript will actually include those
config files.

"references": [{ "path": "../query-persist-client-core" }]
}
7 changes: 6 additions & 1 deletion packages/query-broadcast-client-experimental/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@
"outDir": "./dist-ts",
"rootDir": "."
},
"include": ["src", "test-setup.ts", "*.config.*", "package.json"],
"include": [
"src",
"test-setup.ts",
"*.config.{ts,js,mjs,cjs}",
"package.json"
],
"references": [{ "path": "../query-core" }]
}
2 changes: 1 addition & 1 deletion packages/query-codemods/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@
"outDir": "./dist-ts",
"rootDir": "."
},
"include": ["src", "*.config.*", "package.json"]
"include": ["src", "*.config.{ts,js,mjs,cjs}", "package.json"]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🌐 Web query:

Does TypeScript tsconfig.json includesupport brace expansion patterns like"*.config.{ts,js,mjs,cjs}"? Please answer from official TypeScript docs and list supported wildcard syntax.

💡 Result:

No. TypeScript’s official tsconfig.json include/exclude glob syntax does not support brace expansion patterns like ".config.{ts,js,mjs,cjs}". Supported wildcard syntax for include and exclude in tsconfig.json (per the TypeScript TSConfig Reference): - * matches zero or more characters (excluding directory separators) - ? matches any one character (excluding directory separators) - / matches any directory nested to any level TypeScript’s docs explicitly describe only those wildcard characters for glob patterns in include/exclude, and do not list any support for {a,b} brace expansion. Practical implication: to include multiple extensions, you must use separate patterns (for example, /.config.ts, /*.config.js, etc.) rather than {ts,js,...}.

Citations:


Brace-expansion glob syntax is not supported in TypeScript include patterns.

The pattern "*.config.{ts,js,mjs,cjs}" on Line 7 uses brace expansion, which TypeScript's glob syntax does not support. TypeScript only supports *, ?, and **/ wildcards in include and exclude fields. This means config files matching the intended pattern will not be included or type-checked. Use separate patterns for each extension instead.

Suggested fix
-  "include": ["src", "*.config.{ts,js,mjs,cjs}", "package.json"]
+  "include": [
+    "src",
+    "*.config.ts",
+    "*.config.js",
+    "*.config.mjs",
+    "*.config.cjs",
+    "package.json"
+  ]
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"include": ["src", "*.config.{ts,js,mjs,cjs}", "package.json"]
"include": [
"src",
"*.config.ts",
"*.config.js",
"*.config.mjs",
"*.config.cjs",
"package.json"
]
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@packages/query-codemods/tsconfig.json` at line 7, The include pattern uses
unsupported brace-expansion ("*.config.{ts,js,mjs,cjs}") in the tsconfig
"include" array; replace it with explicit patterns for each extension so
TypeScript will match them (e.g., add separate entries like "*.config.ts",
"*.config.js", "*.config.mjs", "*.config.cjs" or equivalent explicit globs) by
updating the "include" array entry that currently contains
"*.config.{ts,js,mjs,cjs}".

}
2 changes: 1 addition & 1 deletion packages/query-core/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@
"outDir": "./dist-ts",
"rootDir": "."
},
"include": ["src", "*.config.*", "package.json"]
"include": ["src", "*.config.{ts,js,mjs,cjs}", "package.json"]
}
2 changes: 1 addition & 1 deletion packages/query-devtools/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@
"jsx": "preserve",
"jsxImportSource": "solid-js"
},
"include": ["src", "*.config.*", "package.json"],
"include": ["src", "*.config.{ts,js,mjs,cjs}", "package.json"],
"references": [{ "path": "../query-core" }]
}
2 changes: 1 addition & 1 deletion packages/query-persist-client-core/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@
"outDir": "./dist-ts",
"rootDir": "."
},
"include": ["src", "*.config.*", "package.json"],
"include": ["src", "*.config.{ts,js,mjs,cjs}", "package.json"],
"references": [{ "path": "../query-core" }]
}
2 changes: 1 addition & 1 deletion packages/query-sync-storage-persister/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"outDir": "./dist-ts",
"rootDir": "."
},
"include": ["src", "*.config.*", "package.json"],
"include": ["src", "*.config.{ts,js,mjs,cjs}", "package.json"],
"references": [
{ "path": "../query-core" },
{ "path": "../query-persist-client-core" }
Expand Down
2 changes: 1 addition & 1 deletion packages/query-test-utils/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@
"outDir": "./dist-ts",
"rootDir": "."
},
"include": ["src", "*.config.*", "package.json"]
"include": ["src", "*.config.{ts,js,mjs,cjs}", "package.json"]
}
7 changes: 6 additions & 1 deletion packages/react-query-devtools/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@
"rootDir": ".",
"jsx": "react-jsx"
},
"include": ["src", "test-setup.ts", "*.config.*", "package.json"],
"include": [
"src",
"test-setup.ts",
"*.config.{ts,js,mjs,cjs}",
"package.json"
],
"references": [{ "path": "../query-devtools" }, { "path": "../react-query" }]
}
2 changes: 1 addition & 1 deletion packages/react-query-next-experimental/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,6 @@
"rootDir": ".",
"jsx": "react-jsx"
},
"include": ["src", "*.config.*", "package.json"],
"include": ["src", "*.config.{ts,js,mjs,cjs}", "package.json"],
"references": [{ "path": "../react-query" }]
}
7 changes: 6 additions & 1 deletion packages/react-query-persist-client/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,12 @@
"rootDir": ".",
"jsx": "react-jsx"
},
"include": ["src", "test-setup.ts", "*.config.*", "package.json"],
"include": [
"src",
"test-setup.ts",
"*.config.{ts,js,mjs,cjs}",
"package.json"
],
"references": [
{ "path": "../query-persist-client-core" },
{ "path": "../react-query" }
Expand Down
7 changes: 6 additions & 1 deletion packages/react-query/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,10 @@
"rootDir": ".",
"jsx": "react-jsx"
},
"include": ["src", "test-setup.ts", "*.config.*", "package.json"]
"include": [
"src",
"test-setup.ts",
"*.config.{ts,js,mjs,cjs}",
"package.json"
]
Comment thread
coderabbitai[bot] marked this conversation as resolved.
}
2 changes: 1 addition & 1 deletion packages/solid-query-devtools/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@
"jsx": "preserve",
"jsxImportSource": "solid-js"
},
"include": ["src", "*.config.*", "package.json"],
"include": ["src", "*.config.{ts,js,mjs,cjs}", "package.json"],
"references": [{ "path": "../query-devtools" }, { "path": "../solid-query" }]
}
7 changes: 6 additions & 1 deletion packages/solid-query-persist-client/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,12 @@
"jsx": "preserve",
"jsxImportSource": "solid-js"
},
"include": ["src", "test-setup.ts", "*.config.*", "package.json"],
"include": [
"src",
"test-setup.ts",
"*.config.{ts,js,mjs,cjs}",
"package.json"
],
"references": [
{ "path": "../query-persist-client-core" },
{ "path": "../solid-query" }
Expand Down
7 changes: 6 additions & 1 deletion packages/solid-query/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@
"jsx": "preserve",
"jsxImportSource": "solid-js"
},
"include": ["src", "test-setup.ts", "*.config.*", "package.json"],
"include": [
"src",
"test-setup.ts",
"*.config.{ts,js,mjs,cjs}",
"package.json"
],
"references": [{ "path": "../query-core" }]
}
2 changes: 1 addition & 1 deletion packages/svelte-query-devtools/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@
"outDir": "./dist-ts",
"rootDir": "."
},
"include": ["src", "tests", "*.config.*", "package.json"],
"include": ["src", "tests", "*.config.{ts,js,mjs,cjs}", "package.json"],
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🌐 Web query:

Does TypeScript's tsconfig.json "include" glob support brace expansion patterns like "*.config.{ts,js,mjs,cjs}"? Please provide official TypeScript documentation/source references.

💡 Result:

No. TypeScript’s tsconfig.json “include”/“exclude” glob patterns do not support brace expansion syntax like "*.config.{ts,js,mjs,cjs}". Officially, TypeScript documents that it supports only wildcard characters for tsconfig include/exclude patterns: *, ?, and / (and related rules). There is no mention of brace-expansion-style {a,b} patterns. Additionally, TypeScript’s own issue tracker records that “curly braces aren’t supported in our glob patterns”. What to do instead: spell out multiple patterns explicitly, e.g. include entries for *.config.ts, *.config.js, etc., or generate the expanded list with your tooling (since tsconfig itself won’t expand braces).

Citations:


Brace expansion in tsconfig.json include is unsupported; rewrite with explicit patterns.

TypeScript's include glob does not support brace expansion syntax. The pattern "*.config.{ts,js,mjs,cjs}" will not match config files as intended. Instead, list each extension separately.

Suggested fix
-  "include": ["src", "tests", "*.config.{ts,js,mjs,cjs}", "package.json"],
+  "include": [
+    "src",
+    "tests",
+    "*.config.ts",
+    "*.config.js",
+    "*.config.mjs",
+    "*.config.cjs",
+    "package.json"
+  ],
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@packages/svelte-query-devtools/tsconfig.json` at line 7, The tsconfig.json
"include" entry uses unsupported brace expansion ("*.config.{ts,js,mjs,cjs}");
replace that single pattern with explicit glob entries in the "include" array
(e.g., "*.config.ts", "*.config.js", "*.config.mjs", "*.config.cjs") so
TypeScript will actually pick up those config files; update the "include" array
accordingly (referencing the "include" key and the current
"*.config.{ts,js,mjs,cjs}" pattern).

"references": [{ "path": "../query-devtools" }, { "path": "../svelte-query" }]
}
2 changes: 1 addition & 1 deletion packages/svelte-query-persist-client/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"outDir": "./dist-ts",
"rootDir": "."
},
"include": ["src", "tests", "*.config.*", "package.json"],
"include": ["src", "tests", "*.config.{ts,js,mjs,cjs}", "package.json"],
"references": [
{ "path": "../query-persist-client-core" },
{ "path": "../svelte-query" }
Expand Down
2 changes: 1 addition & 1 deletion packages/svelte-query/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@
"outDir": "./dist-ts",
"rootDir": "."
},
"include": ["src", "tests", "*.config.*", "package.json"],
"include": ["src", "tests", "*.config.{ts,js,mjs,cjs}", "package.json"],
"references": [{ "path": "../query-core" }]
}
2 changes: 1 addition & 1 deletion packages/vue-query-devtools/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@
"outDir": "./dist-ts",
"rootDir": "."
},
"include": ["src", "*.config.*", "package.json"],
"include": ["src", "*.config.{ts,js,mjs,cjs}", "package.json"],
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🌐 Web query:

TypeScript tsconfig include glob syntax: are brace patterns like "*.config.{ts,js,mjs,cjs}" supported, or are only "*", "?", and "**/" supported?

💡 Result:

No, brace patterns like ".config.{ts,js,mjs,cjs}" are not supported in TypeScript tsconfig include. Only basic glob patterns "", "?", and "/" are supported, along with special handling for "." patterns where only supported file extensions are considered. To match multiple extensions like ts, js, mjs, cjs, you must list them separately: [".config.ts", ".config.js", ".config.mjs", ".config.cjs"].

Citations:


include uses brace-glob syntax that TypeScript does not support

The pattern *.config.{ts,js,mjs,cjs} uses brace expansion, which TypeScript's include glob does not support. TypeScript only recognizes *, ?, and **/; brace patterns are treated literally and config files won't be included as intended.

Proposed fix
-  "include": ["src", "*.config.{ts,js,mjs,cjs}", "package.json"],
+  "include": [
+    "src",
+    "*.config.ts",
+    "*.config.js",
+    "*.config.mjs",
+    "*.config.cjs",
+    "package.json"
+  ],
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@packages/vue-query-devtools/tsconfig.json` at line 7, The include pattern in
tsconfig.json uses brace expansion ("*.config.{ts,js,mjs,cjs}") which TypeScript
doesn't support; replace that single brace-glob entry in the "include" array
with explicit glob entries such as "*.config.ts", "*.config.js", "*.config.mjs",
and "*.config.cjs" (or a single "*.config.*" if you want a broader match) so the
config files are actually picked up by the TypeScript compiler; update the
include array entry that currently contains the brace pattern accordingly.

"references": [{ "path": "../vue-query" }, { "path": "../query-devtools" }]
}
7 changes: 6 additions & 1 deletion packages/vue-query/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@
"outDir": "./dist-ts",
"rootDir": "."
},
"include": ["src", "test-setup.ts", "*.config.*", "package.json"],
"include": [
"src",
"test-setup.ts",
"*.config.{ts,js,mjs,cjs}",
"package.json"
],
"references": [{ "path": "../query-core" }]
}
Loading