test(query-devtools/DevtoolsComponent): add smoke test for rendering without throwing#10679
Merged
Merged
Conversation
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdds a Vitest + Solid test for DevtoolsComponent that mocks ChangesDevtoolsComponent Test Suite
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
View your CI Pipeline Execution ↗ for commit 22e1de5
☁️ Nx Cloud last updated this comment at |
Contributor
🚀 Changeset Version PreviewNo changeset entries found. Merging this PR will not cause a version bump for any packages. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/query-devtools/src/__tests__/DevtoolsComponent.test.tsx`:
- Around line 14-29: Save the original window.localStorage descriptor before you
override it in the beforeEach, then add an afterEach that restores it (so the
mock doesn't leak between suites). Specifically, capture the original descriptor
(or value) of window.localStorage at the top of the test file or inside the
beforeEach setup, and in afterEach restore via Object.defineProperty(window,
'localStorage', originalDescriptor) or assign the saved value back; reference
the existing beforeEach override and ensure the cleanup runs after each test to
fully revert the mocked localStorage.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: bba7155b-0256-4431-8625-f8eae3dace98
📒 Files selected for processing (1)
packages/query-devtools/src/__tests__/DevtoolsComponent.test.tsx
Contributor
size-limit report 📦
|
sukvvon
force-pushed
the
test/query-devtools-devtools-component-smoke
branch
2 times, most recently
from
bc099da to
853d206
Compare
sukvvon
changed the title
sukvvon
force-pushed
the
test/query-devtools-devtools-component-smoke
branch
from
853d206 to
25d56cf
Compare
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/query-devtools/src/__tests__/DevtoolsComponent.test.tsx`:
- Line 16: The mocked getItem implementation in DevtoolsComponent.test.tsx
currently returns storage[key] || null which converts falsy stored values (like
empty string or "0") into null; update the mock getItem so it returns the actual
stored value when the key exists and only returns null when the key is absent
(e.g., check presence with Object.prototype.hasOwnProperty.call(storage, key) or
key in storage and return storage[key] otherwise null) to match the Storage API
contract.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: b78b156f-8b6e-4b05-bc97-61f96c906356
📒 Files selected for processing (1)
packages/query-devtools/src/__tests__/DevtoolsComponent.test.tsx
sukvvon
force-pushed
the
test/query-devtools-devtools-component-smoke
branch
from
25d56cf to
b5c4305
Compare
sukvvon
force-pushed
the
test/query-devtools-devtools-component-smoke
branch
from
b5c4305 to
3c7572f
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
Add a smoke test for
DevtoolsComponent, the lightweight wrapper that wiresQueryDevtoolsContext,PiPProvider, andThemeContextaround the SolidDevtoolsbody.matchMediaandResizeObserverto satisfy jsdom.solid-transition-groupto bypass a transitive@solid-primitives/transition-groupexportsfield that Vite cannot resolve.localStoragesocreateLocalStoragefrom@solid-primitives/storagedoes not leak across tests.✅ Checklist
🚀 Release Impact
Summary by CodeRabbit