test(query-devtools/Explorer): add tests for 'defaultExpanded' and pagination behavior#10727
Open
sukvvon wants to merge 1 commit into
Open
test(query-devtools/Explorer): add tests for 'defaultExpanded' and pagination behavior#10727sukvvon wants to merge 1 commit into
sukvvon wants to merge 1 commit into
Conversation
…gination behavior
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR adds test coverage for two Explorer component features: validation that ChangesExplorer Component Test Coverage
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
View your CI Pipeline Execution ↗ for commit fc5baa9
☁️ Nx Cloud last updated this comment at |
Contributor
🚀 Changeset Version Preview2 package(s) bumped directly, 23 bumped as dependents. 🟩 Patch bumps
|
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
Extend
Explorer.test.tsxwith tests for props-driven behavior —defaultExpandedand pagination of large arrays (subEntryPages.length > 1branch).Added cases:
"defaultExpanded"(1)should render children eagerly when the label is in "defaultExpanded"— the call siteDevtools.tsxalways passesdefaultExpanded={['Data']}, so this locks the contract that the Data panel renders pre-expanded.pagination(3)should group entries into 100-item pages when the array has more than 100 entriesshould keep the items of a page hidden until the page header is clickedshould reveal the items of a page when the page header is clicked✅ Checklist
pnpm run test:pr.🚀 Release Impact
Summary by CodeRabbit
defaultExpandedbehavior and array pagination functionality, including validation of expanded state rendering and pagination interactions for large arrays.