Skip to content

fix(start): upgrade rsbuild for RSC preview asset serving#7738

Open
SyMind wants to merge 2 commits into
TanStack:mainfrom
SyMind:fix-rsbuild-preview
Open

fix(start): upgrade rsbuild for RSC preview asset serving#7738
SyMind wants to merge 2 commits into
TanStack:mainfrom
SyMind:fix-rsbuild-preview

Conversation

@SyMind

@SyMind SyMind commented Jul 3, 2026

Copy link
Copy Markdown
Contributor
  • Upgrade @rsbuild/core for the RSC rsbuild e2e fixture to 2.1.2.
  • Add an rsbuild preview e2e mode for e2e/react-start/rsc-rsbuild.
  • Add preview-only coverage to verify SSR RSC client assets are served correctly by rsbuild preview.

Summary by CodeRabbit

  • New Features

    • Added a new preview mode for the RSC rsbuild-based React starter, alongside the existing SSR flow.
  • Bug Fixes

    • Updated the build tool (@rsbuild/core) to ^2.1.2 across multiple starters, examples, benchmarks, and end-to-end setups for consistency and compatibility.
  • Tests

    • Updated the Playwright e2e setup to automatically start the correct server command based on the selected preview mode.

@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 1f5e79b6-f8b8-44dc-8285-1b195671ac5f

📥 Commits

Reviewing files that changed from the base of the PR and between f516168 and 145386f.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (6)
  • examples/react/quickstart-rspack-file-based/package.json
  • examples/solid/quickstart-rspack-file-based/package.json
  • packages/react-start/package.json
  • packages/solid-start/package.json
  • packages/start-plugin-core/package.json
  • packages/vue-start/package.json
✅ Files skipped from review due to trivial changes (1)
  • packages/solid-start/package.json
🚧 Files skipped from review as they are similar to previous changes (5)
  • examples/solid/quickstart-rspack-file-based/package.json
  • packages/vue-start/package.json
  • examples/react/quickstart-rspack-file-based/package.json
  • packages/start-plugin-core/package.json
  • packages/react-start/package.json

📝 Walkthrough

Walkthrough

This PR updates @rsbuild/core to ^2.1.2 across workspace package manifests and adds preview-mode support for the e2e/react-start/rsc-rsbuild Playwright setup.

Changes

rsbuild/core bump and rsc preview mode

Layer / File(s) Summary
rsc-rsbuild preview mode and Playwright config
e2e/react-start/rsc-rsbuild/package.json, e2e/react-start/rsc-rsbuild/playwright.config.ts
Adds a preview script, adds a preview Playwright mode entry, and switches the web server command between pnpm preview --port and pnpm start based on MODE.
@rsbuild/core version bumps across package.json files
benchmarks/bundle-size/package.json, e2e/react-router/*/package.json, e2e/react-start/*/package.json, e2e/solid-router/*/package.json, e2e/solid-start/*/package.json, e2e/vue-router/*/package.json, e2e/vue-start/basic/package.json, examples/react/quickstart-rspack-file-based/package.json, examples/solid/quickstart-rspack-file-based/package.json, packages/*/package.json
Updates @rsbuild/core from ^2.0.11 or ^2.0.8 to ^2.1.2 in the listed manifests.

Estimated code review effort: 2 (Simple) | ~10 minutes

Sequence Diagram(s)

sequenceDiagram
  participant Playwright as Playwright runner
  participant Config as playwright.config.ts
  participant Env as process.env.MODE
  participant WebServer as webServer command

  Playwright->>Config: load config
  Config->>Env: read MODE, default 'ssr'
  Config->>WebServer: choose pnpm preview or pnpm start
  Config->>WebServer: set env MODE
Loading

Possibly related issues

  • TanStack/router-monorepo#1: Tracks the same workspace-wide @rsbuild/core version upgrade across package manifests.

Possibly related PRs

  • TanStack/router#7245: Also updates @rsbuild/core version ranges across the repository’s package.json files.
  • TanStack/router#7509: Related to the e2e/react-start/rsc-rsbuild RSBuild/RSC integration and Playwright flow.

Suggested labels: package: react-start, package: solid-start, package: vue-start

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the main change: upgrading rsbuild to support RSC preview asset serving.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

…build-preview

# Conflicts:
#	pnpm-lock.yaml
@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Added@​rsbuild/​core@​2.1.21001008598100

View full report

@socket-security

Copy link
Copy Markdown

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn High
Obfuscated code: npm @emnapi/runtime is 90.0% likely obfuscated

Confidence: 0.90

Location: Package overview

From: pnpm-lock.yamlnpm/nitro@3.0.1-alpha.2npm/@rsbuild/plugin-vue@1.2.7npm/nitro@3.0.260311-betanpm/wrangler@4.75.0npm/@cloudflare/vite-plugin@1.29.1npm/@rsbuild/plugin-react@2.0.0npm/@rsbuild/core@2.1.2npm/@swc-node/register@1.11.1npm/@emnapi/runtime@1.11.1

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/@emnapi/runtime@1.11.1. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant