Skip to content

Commit 3abbb66

Browse files
committed
fix: correct cleanup and test setup
1 parent f7603d5 commit 3abbb66

3 files changed

Lines changed: 4 additions & 4 deletions

File tree

packages/angular-store/src/injectSelector.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,11 +70,11 @@ export function injectSelector<TState, TSelected = NoInfer<TState>>(
7070
equal: options?.compare,
7171
})
7272

73-
effect(() => {
73+
effect((onCleanup) => {
7474
const { unsubscribe } = _source().subscribe((state) => {
7575
slice.set(selector(state))
7676
})
77-
return unsubscribe
77+
onCleanup(unsubscribe)
7878
})
7979

8080
return slice.asReadonly()

packages/angular-store/tests/index.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -557,7 +557,7 @@ describe('_injectStore', () => {
557557
standalone: true,
558558
})
559559
class MyCmp {
560-
private value = _injectStore(store, (state) => state)
560+
protected value = _injectStore(store, (state) => state)
561561

562562
inc() {
563563
this.value.setState((prev: number) => prev + 1)

packages/angular-store/tsconfig.spec.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,6 @@
44
"noEmit": false,
55
"types": ["vitest/globals", "node"]
66
},
7-
"files": ["src/test-setup.ts"],
7+
"files": ["tests/test-setup.ts"],
88
"include": ["tests/**/*.ts"]
99
}

0 commit comments

Comments
 (0)