fix: improve accessibility by adding htmlFor attributes to labels; fix: eslint errors and improve code

Author: LadyBluenotes

scripts/test-npm-cache.ts

@@ -3,11 +3,10 @@
  * Tests that chunks are properly cached and retrieved
  */
 
-import { db } from '../src/db/client'
 import {
   getCachedNpmDownloadChunk,
   setCachedNpmDownloadChunk,
-} from '../src/utils/stats-db.server'
+} from '~/utils/stats-db.server'
 
 async function testCache() {
   console.log('\n' + '='.repeat(80))

src/auth/context.server.ts

@@ -11,7 +11,6 @@ import { OAuthService } from './oauth.server'
 import { SessionService } from './session.server'
 import { createAuthGuards } from './guards.server'
 import {
-  createRepositories,
   DrizzleUserRepository,
   DrizzleOAuthAccountRepository,
   DrizzleCapabilitiesRepository,

src/components/AILibraryHero.tsx

@@ -94,7 +94,7 @@ const MESSAGES = [
   },
 ]
 
-export function AILibraryHero({ project, cta, actions }: AILibraryHeroProps) {
+export function AILibraryHero({}: AILibraryHeroProps) {
   const isDark = useIsDark()
   const strokeColor = isDark ? 'rgba(255, 255, 255, 0.8)' : 'rgba(0, 0, 0, 0.6)'
   const textColor = isDark ? '#ffffff' : '#000000'

src/components/CookieConsent.tsx

@@ -1,5 +1,5 @@
 import { Link } from '@tanstack/react-router'
-import { useCallback, useEffect, useState } from 'react'
+import { useEffect, useState } from 'react'
 
 declare global {
   interface Window {

src/components/DocFeedbackNote.tsx

@@ -298,6 +298,7 @@ export function DocFeedbackNote({
   }
 
   return (
+    // eslint-disable-next-line jsx-a11y/click-events-have-key-events,jsx-a11y/no-static-element-interactions
     <div
       className={twMerge(
         inline ? 'w-full' : 'fixed z-40 w-80 max-w-[calc(100vw-2rem)]',
@@ -334,6 +335,7 @@ export function DocFeedbackNote({
         )}
 
         {/* Header - always visible */}
+        {/* eslint-disable-next-line jsx-a11y/click-events-have-key-events,jsx-a11y/no-static-element-interactions */}
         <div
           className={twMerge(
             `flex flex-col gap-1 p-2 ${colors.header}`,

src/components/FeedFilters.tsx

@@ -176,7 +176,7 @@ export function FeedFilters({
     featured !== undefined ||
     search ||
     (selectedReleaseLevels && selectedReleaseLevels.length > 0) ||
-    (includePrerelease !== undefined && includePrerelease !== true),
+    (includePrerelease !== undefined && !includePrerelease),
   )
 
   // Render filter content (shared between mobile and desktop)
@@ -383,6 +383,7 @@ export function FeedFilters({
           compact
         />
       )}
+      {/* eslint-disable-next-line jsx-a11y/click-events-have-key-events,jsx-a11y/no-static-element-interactions */}
       <div onClick={(e) => e.stopPropagation()} className="flex-shrink-0">
         <FilterSearch
           value={searchInput}

src/components/FeedList.tsx

@@ -58,16 +58,13 @@ interface FeedListProps {
 export function FeedList({
   query,
   infiniteQuery,
-  filters,
   currentPage,
   pageSize,
   onPageChange,
   onPageSizeChange,
   viewMode = 'table',
   expandedIds,
   onExpandedChange,
-  onViewModeChange,
-  onFiltersChange,
   adminActions,
 }: FeedListProps) {
   // For timeline mode, use infinite query

src/components/FeedPage.tsx

@@ -1,7 +1,5 @@
-import { useState, useEffect, useMemo } from 'react'
-import { ReactNode } from 'react'
+import { useState, useEffect } from 'react'
 import { useMounted } from '~/hooks/useMounted'
-import { Footer } from '~/components/Footer'
 import { FeedList } from '~/components/FeedList'
 import { FeedFilters as FeedFiltersComponent } from '~/components/FeedFilters'
 import { useFeedQuery } from '~/hooks/useFeedQuery'
@@ -15,7 +13,6 @@ import {
   getFeedFacetCountsQueryOptions,
   type FeedFilters,
 } from '~/queries/feed'
-import { twMerge } from 'tailwind-merge'
 
 // Re-export FeedFilters as FeedFiltersState for backwards compatibility
 export type FeedFiltersState = FeedFilters
@@ -235,31 +232,6 @@ export function FeedPage({
   const currentPage = effectiveFilters.page ?? 1
   const pageSize = effectiveFilters.pageSize ?? 50
 
-  // Convert FeedFiltersState to FeedFilters format
-  const feedFilters = useMemo(
-    () => ({
-      entryTypes: normalizeFilter(effectiveFilters.entryTypes),
-      libraries: normalizeFilter(effectiveFilters.libraries),
-      partners: normalizeFilter(effectiveFilters.partners),
-      tags: normalizeFilter(effectiveFilters.tags),
-      releaseLevels: normalizeFilter(effectiveFilters.releaseLevels) as any,
-      includePrerelease: effectiveFilters.includePrerelease,
-      featured: effectiveFilters.featured,
-      search: effectiveFilters.search,
-      includeHidden: adminActions !== undefined,
-    }),
-    [
-      effectiveFilters.entryTypes,
-      effectiveFilters.libraries,
-      effectiveFilters.partners,
-      effectiveFilters.tags,
-      effectiveFilters.releaseLevels,
-      effectiveFilters.includePrerelease,
-      effectiveFilters.featured,
-      effectiveFilters.search,
-      adminActions,
-    ],
-  )
 
   return (
     <div className="p-2 sm:p-4 pb-0 flex flex-col max-w-full gap-2 sm:gap-4 relative">

src/components/FeedPageLayout.tsx

@@ -14,7 +14,6 @@ import {
   getFeedFacetCountsQueryOptions,
   type FeedFilters,
 } from '~/queries/feed'
-import { twMerge } from 'tailwind-merge'
 import { Spinner } from '~/components/Spinner'
 
 // Re-export FeedFilters as FeedFiltersState for backwards compatibility
@@ -211,7 +210,6 @@ function FeedPageLayoutContent({ children }: { children?: ReactNode }) {
     feedQuery,
     currentPage,
     pageSize,
-    filters = {},
     onPageChange,
     onPageSizeChange,
     viewMode = 'table',
@@ -222,31 +220,6 @@ function FeedPageLayoutContent({ children }: { children?: ReactNode }) {
     adminActions,
   } = useFeedPageLayout()
 
-  // Convert FeedFiltersState to FeedFilters format
-  const feedFilters = React.useMemo(() => {
-    if (!filters) {
-      return {
-        includeHidden: adminActions !== undefined,
-      }
-    }
-
-    const normalizeFilter = <T,>(value: T[] | undefined): T[] | undefined => {
-      return value && value.length > 0 ? value : undefined
-    }
-
-    return {
-      entryTypes: normalizeFilter(filters.entryTypes),
-      libraries: normalizeFilter(filters.libraries),
-      partners: normalizeFilter(filters.partners),
-      tags: normalizeFilter(filters.tags),
-      releaseLevels: normalizeFilter(filters.releaseLevels) as any,
-      includePrerelease: filters.includePrerelease,
-      featured: filters.featured,
-      search: filters.search,
-      includeHidden: adminActions !== undefined,
-    }
-  }, [filters, adminActions])
-
   return (
     <main className="flex-1 min-w-0 relative flex flex-col">
       <FeedList

src/components/FeedbackModerationFilters.tsx

@@ -171,7 +171,10 @@ export function FeedbackModerationFilters({
       >
         <div className="space-y-3">
           <div>
-            <label className="block text-xs font-medium text-gray-700 dark:text-gray-300 mb-1">
+            <label
+              htmlFor="date-from"
+              className="block text-xs font-medium text-gray-700 dark:text-gray-300 mb-1"
+            >
               From
             </label>
             <input
@@ -182,7 +185,10 @@ export function FeedbackModerationFilters({
             />
           </div>
           <div>
-            <label className="block text-xs font-medium text-gray-700 dark:text-gray-300 mb-1">
+            <label
+              htmlFor="date-to"
+              className="block text-xs font-medium text-gray-700 dark:text-gray-300 mb-1"
+            >
               To
             </label>
             <input