fix: avoid lazy search modal chunk cycle

Author: tannerlinsley

src/routes/__root.tsx

@@ -19,12 +19,9 @@ const LazyRouterDevtools = React.lazy(() =>
 import { NotFound } from '~/components/NotFound'
 import { DefaultCatchBoundary } from '~/components/DefaultCatchBoundary'
 import { SearchProvider, useSearchContext } from '~/contexts/SearchContext'
+import { SearchModal } from '~/components/SearchModal'
 import { ToastProvider } from '~/components/ToastProvider'
 import { LoginModalProvider } from '~/contexts/LoginModalContext'
-
-const LazySearchModal = React.lazy(() =>
-  import('~/components/SearchModal').then((m) => ({ default: m.SearchModal })),
-)
 import { Spinner } from '~/components/Spinner'
 import { ThemeProvider, useHtmlClass } from '~/components/ThemeProvider'
 import { Navbar } from '~/components/Navbar'
@@ -210,8 +207,7 @@ function ShellComponent({ children }: { children: React.ReactNode }) {
 }
 
 function SearchHotkeyController() {
-  const { isOpen, openSearch } = useSearchContext()
-  const [hasOpenedSearch, setHasOpenedSearch] = React.useState(false)
+  const { openSearch } = useSearchContext()
 
   React.useEffect(() => {
     const handleGlobalKeyDown = (event: KeyboardEvent) => {
@@ -220,7 +216,6 @@ function SearchHotkeyController() {
       if (event.key.toLowerCase() !== 'k') return
 
       event.preventDefault()
-      setHasOpenedSearch(true)
       openSearch()
     }
 
@@ -230,19 +225,7 @@ function SearchHotkeyController() {
     }
   }, [openSearch])
 
-  React.useEffect(() => {
-    if (isOpen) {
-      setHasOpenedSearch(true)
-    }
-  }, [isOpen])
-
-  if (!hasOpenedSearch) return null
-
-  return (
-    <React.Suspense fallback={null}>
-      <LazySearchModal />
-    </React.Suspense>
-  )
+  return <SearchModal />
 }
 
 function IdleGtmLoader() {