Skip to content

Commit 7d32728

Browse files
committed
gpt review
1 parent dc8c525 commit 7d32728

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

src/blog/tanstack-router-signal-graph.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ Before this refactor, `useMatch` subscribed through the big router store and the
8888
useRouterState({
8989
select: (state) => {
9090
const match = state.matches.find((m) => m.routeId === routeId)
91-
/* select from one match */
91+
return /* select from one match */
9292
}
9393
})
9494

@@ -190,7 +190,7 @@ Our benchmarks isolate client-side navigation cost on a synthetic rerender-heavy
190190
<figure>
191191
<img src="/blog-assets/tanstack-router-signal-graph/client-side-nav-react.png" alt="">
192192
<figcaption>
193-
This graph shows the duration of 10 navigations going from 70ms on <code>main</code> (grey) to 45ms on <code>refactor-signals</code> (blue).
193+
This graph shows the duration of 10 navigations on <code>main</code> (grey) and on <code>refactor-signals</code> (blue).
194194
</figcaption>
195195
</figure>
196196
@@ -199,7 +199,7 @@ This graph shows the duration of 10 navigations going from 70ms on <code>main</c
199199
<figure>
200200
<img src="/blog-assets/tanstack-router-signal-graph/client-side-nav-solid.png" alt="">
201201
<figcaption>
202-
This graph shows the duration of 10 navigations going from 120ms on <code>main</code> (grey) to 80ms on <code>refactor-signals</code> (blue).
202+
This graph shows the duration of 10 navigations on <code>main</code> (grey) and on <code>refactor-signals</code> (blue).
203203
</figcaption>
204204
</figure>
205205
@@ -208,7 +208,7 @@ This graph shows the duration of 10 navigations going from 120ms on <code>main</
208208
<figure>
209209
<img src="/blog-assets/tanstack-router-signal-graph/client-side-nav-vue.png" alt="">
210210
<figcaption>
211-
This graph shows the duration of 10 navigations going from 75ms on <code>main</code> (grey) to 60ms on <code>refactor-signals</code> (blue).
211+
This graph shows the duration of 10 navigations on <code>main</code> (grey) and on <code>refactor-signals</code> (blue).
212212
</figcaption>
213213
</figure>
214214
@@ -225,7 +225,7 @@ There is also a bundle-size tradeoff. In our synthetic bundle-size benchmarks, m
225225
#### React
226226
227227
<figure>
228-
<img src="/blog-assets/tanstack-router-signal-graph/bundle-size-history-react.png" alt="A graph the history of the bundle size of a synthetic tanstack/react-router app, gaining 1KiB gzipped with this latest change">
228+
<img src="/blog-assets/tanstack-router-signal-graph/bundle-size-history-react.png" alt="A graph of the history of the bundle size of a synthetic tanstack/react-router app, gaining 1KiB gzipped with this latest change">
229229
<figcaption>
230230
Only relative changes matter in this benchmark, they are based on arbitrary apps and absolute sizes are not representative.
231231
</figcaption>
@@ -234,7 +234,7 @@ Only relative changes matter in this benchmark, they are based on arbitrary apps
234234
#### Solid
235235
236236
<figure>
237-
<img src="/blog-assets/tanstack-router-signal-graph/bundle-size-history-solid.png" alt="A graph the history of the bundle size of a synthetic tanstack/solid-router app, shedding 1KiB gzipped with this latest change">
237+
<img src="/blog-assets/tanstack-router-signal-graph/bundle-size-history-solid.png" alt="A graph of the history of the bundle size of a synthetic tanstack/solid-router app, shedding 1KiB gzipped with this latest change">
238238
<figcaption>
239239
Only relative changes matter in this benchmark, they are based on arbitrary apps and absolute sizes are not representative.
240240
</figcaption>
@@ -243,7 +243,7 @@ Only relative changes matter in this benchmark, they are based on arbitrary apps
243243
#### Vue
244244
245245
<figure>
246-
<img src="/blog-assets/tanstack-router-signal-graph/bundle-size-history-vue.png" alt="A graph the history of the bundle size of a synthetic tanstack/vue-router app, gaining 1KiB gzipped with this latest change">
246+
<img src="/blog-assets/tanstack-router-signal-graph/bundle-size-history-vue.png" alt="A graph of the history of the bundle size of a synthetic tanstack/vue-router app, gaining 1KiB gzipped with this latest change">
247247
<figcaption>
248248
Only relative changes matter in this benchmark, they are based on arbitrary apps and absolute sizes are not representative.
249249
</figcaption>

0 commit comments

Comments
 (0)