fix: replace blog ISO dates with readable dates#631
Closed
LeCarbonator wants to merge 1 commit intoTanStack:mainfrom
Closed
fix: replace blog ISO dates with readable dates#631LeCarbonator wants to merge 1 commit intoTanStack:mainfrom
LeCarbonator wants to merge 1 commit intoTanStack:mainfrom
Conversation
👷 Deploy request for tanstack pending review.Visit the deploys page to approve it
|
Author
|
Looks like I made a duplicate of #630 . |
Contributor
|
@LeCarbonator please don't kill my first PR to OSS 🥹 |
Author
|
You're good @dandaka . I think your PR solves it in a better way than mine anyways. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A wrongly formatted string caused the date formatter to fall back to ISO dates:
This PR changes the formatting strings to be
MMM d, yyyyinstead ofMMM dd, yyyyfor a readable date string.(Image from local environment)