-
-
Notifications
You must be signed in to change notification settings - Fork 316
fix docs #801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
fix docs #801
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
3259b34
fix?
LadyBluenotes 12dd0e6
fix: add stale cache handling to fetchCached function
LadyBluenotes a6229f4
fix: update cache control headers and enable staleOnError in fetchCached
LadyBluenotes 54d3370
fix: enhance example loading with fallback handling and availability …
LadyBluenotes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stale fallback does not suppress repeated upstream failures.
When fallback is used, the stale value is returned but not written back to
docCache. After TTL expiry, each request still re-hitsopts.fn()and fails again, which can amplify external outages.Proposed fix
} catch (error) { if (opts.staleOnError && docStaleCache.has(opts.key)) { + const staleValue = docStaleCache.get(opts.key) as T + // Short rehydrate window to avoid hammering failing upstreams + docCache.set(opts.key, staleValue, { + ttl: Math.min(opts.ttl, 30_000), + }) console.warn( `[fetchCached] Serving stale value for key '${opts.key}' after fetch error`, ) - return docStaleCache.get(opts.key) as T + return staleValue } throw error }📝 Committable suggestion
🤖 Prompt for AI Agents