Skip to content

feat(perf): update deps #836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tannerlinsley merged 3 commits into from
Apr 20, 2026
Merged

feat(perf): update deps #836

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3e36a90
feat(perf): swap React for @tanstack/dom-vite shim
tannerlinsley Apr 19, 2026
8a00018
chore(deps): bump @tanstack/dom-vite to 0.1.0-alpha.3
tannerlinsley Apr 19, 2026
9771d0d
feat: bump @tanstack/dom-vite to 0.1.0-alpha.4 + alias runtime-specif…
tannerlinsley Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .oxlintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@
".tanstack-start",
".netlify",
"public",
"convex/.temp"
"convex/.temp",
".claude"
],
"rules": {
"no-array-constructor": "error",
Expand Down
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"build": "vite build",
"start": "vite start",
"start:prod": "pnpm run with-env node scripts/run-built-server.mjs",
"lint": "oxlint --type-aware",
"lint": "oxlint --type-aware --disable-nested-config",
"format": "oxfmt --write",
"db:generate": "drizzle-kit generate",
"db:migrate": "drizzle-kit migrate",
Expand Down Expand Up @@ -122,6 +122,7 @@
"@playwright/test": "^1.59.0",
"@shikijs/transformers": "^4.0.2",
"@tanstack/devtools-vite": "^0.6.0",
"@tanstack/dom-vite": "0.1.0-alpha.3",
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Apr 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🌐 Web query:

Is @tanstack/dom-vite@0.1.0-alpha.3 published on npm, and what changed from 0.1.0-alpha.2 (especially SSR/client handling of raw REACT_LAZY_TYPE children)?

💡 Result:

No, @tanstack/dom-vite@0.1.0-alpha.3 is not published on npm. Extensive searches across npm registry, TanStack repositories, GitHub, and related TanStack Vite plugins (like @tanstack/devtools-vite, @tanstack/vite-config, @tanstack/start-vite-plugin) returned no evidence of this package or version existing. No changelog or mentions of changes from alpha.2 to alpha.3, including SSR/client handling of REACT_LAZY_TYPE children, were found. The package name may be a misremembered or unpublished/internal TanStack project.

Citations:

🏁 Script executed:

# Find vite.config file and check its imports
fd -e ts -e js -e mts -e mjs "vite.config" | head -5

Repository: TanStack/tanstack.com

Length of output: 79

🏁 Script executed:

# Also search for any references to `@tanstack/dom-vite` in the codebase
rg "@tanstack/dom-vite" --type ts --type js

Repository: TanStack/tanstack.com

Length of output: 128

🏁 Script executed:

cat -n vite.config.ts | head -30

Repository: TanStack/tanstack.com

Length of output: 1513

Remove non-existent package dependency

Line 125 adds @tanstack/dom-vite@0.1.0-alpha.3, but this package and version do not exist on npm. While vite.config.ts imports tanstackDom from @tanstack/dom-vite (line 3), the specified version is not published. Adding this to package.json will cause npm install to fail. Either use a published version of this package, find the correct package name, or remove the dependency if it's not needed for this build.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@package.json` at line 125, The dependency entry "@tanstack/dom-vite":
"0.1.0-alpha.3" is invalid (package/version not published) and will break
installs; remove or replace it in package.json and update any imports
accordingly — either change the dependency to a published package/version or
delete the entry and then remove or adjust the import of tanstackDom in
vite.config.ts (the import statement referencing `@tanstack/dom-vite`) so the
build uses a correct package name or no import at all.

"@tanstack/react-devtools": "^0.10.2",
"@tanstack/react-query-devtools": "^5.99.0",
"@types/hast": "^3.0.4",
Expand Down
50 changes: 50 additions & 0 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions vite.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { sentryTanstackStart } from '@sentry/tanstackstart-react/vite'
import { defineConfig } from 'vite'
import { tanstackDom } from '@tanstack/dom-vite'
import contentCollections from '@content-collections/vite'
import { devtools as tanstackDevtools } from '@tanstack/devtools-vite'
import { tanstackStart } from '@tanstack/react-start/plugin/vite'
Expand Down Expand Up @@ -102,6 +103,12 @@ export default defineConfig({
'discord-interactions',
// Don't pre-bundle CLI so we always get fresh changes during dev
...(isDev ? ['@tanstack/cli'] : []),
// `use client` libraries that plugin-rsc pre-bundles inconsistently
// across client/ssr/rsc envs when combined with our React shim — each
// env resolves `react` to a different target, so the optimizer's hash
// diverges. Excluding from optimize keeps resolution deterministic per
// env and silences the 50k+ "inconsistently optimized" warning flood.
'lucide-react',
],
},
build: {
Expand Down Expand Up @@ -168,6 +175,7 @@ export default defineConfig({
},
},
plugins: [
tanstackDom(),
...(isDev ? [tanstackDevtools()] : []),
tanstackStart({
rsc: {
Expand Down
Loading