Fixed ComboBox::OnSelect not being emitted when selecting the item which is already currently active from the drop-down.

binary1248 · binary1248 · commit 00f943da83a3 · 2015-10-10T21:28:07.000+02:00
diff --git a/src/SFGUI/ComboBox.cpp b/src/SFGUI/ComboBox.cpp
@@ -307,7 +307,7 @@ void ComboBox::HandleMouseButtonEvent( sf::Mouse::Button button, bool press, int
 
 		auto emit_select = false;
 
-		if( ( m_highlighted_item != NONE ) && ( m_active_item != m_highlighted_item ) ) {
+		if( m_highlighted_item != NONE ) {
 			m_active_item = m_highlighted_item;
 			emit_select = true;
 		}

Original file line number	Diff line number	Diff line change
`@@ -307,7 +307,7 @@ void ComboBox::HandleMouseButtonEvent( sf::Mouse::Button button, bool press, int`
`307`	`307`
`308`	`308`	`auto emit_select = false;`
`309`	`309`
`310`		`- if( ( m_highlighted_item != NONE ) && ( m_active_item != m_highlighted_item ) ) {`
	`310`	`+ if( m_highlighted_item != NONE ) {`
`311`	`311`	`m_active_item = m_highlighted_item;`
`312`	`312`	`emit_select = true;`
`313`	`313`	`}`