Merge pull request #21 from TankerHQ/dm/drop-old-pythons

Drop support for old Python versions (2.7, 3.4)

Author: dmerejkowsky

.github/workflows/checks.yml

@@ -22,36 +22,6 @@ jobs:
       - name: Run tests
         run: dmenv run -- pytest
 
-  python34:
-    runs-on: ubuntu-16.04
-    steps:
-      - uses: actions/checkout@v1
-      - name: Set up Python 3.4
-        uses: actions/setup-python@v1
-        with:
-          python-version: 3.4
-      - name: Install dmenv
-        uses: TankerHQ/dmenv-install-action@v1.0.0
-        with:
-          dmenv-version: 0.20.0
-      - name: Prepare project for development
-        run: dmenv install
-      - name: Run tests
-        run: dmenv run -- pytest
-
-  python2:
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v1
-      - name: Set up Python 2.7
-        uses: actions/setup-python@v1
-        with:
-          python-version: 2.7
-      - name: Install dependencies
-        run: pip install -r requirements.lock
-      - name: Run tests
-        run: pytest
-
   coverage:
     runs-on: ubuntu-latest
     steps:

Changelog.rst

@@ -1,3 +1,9 @@
+1.2.2
+===
+
+* Drop Python2 support
+* Drop Python 3.4 support
+
 1.2.1
 ===
 

setup.py

@@ -15,17 +15,8 @@ def get_long_description():
     author="Kontrol SAS",
     packages=find_packages(),
     install_requires=["PyNaCl"],
-    extras_require={
-        "dev": [
-            "codecov",
-            "pytest",
-            "pytest-cov",
-            "twine",
-        ],
-    },
+    extras_require={"dev": ["codecov", "pytest", "pytest-cov", "twine"]},
     classifiers=[
-        "Programming Language :: Python :: 2.7",
-        "Programming Language :: Python :: 3.4",
         "Programming Language :: Python :: 3.5",
         "Programming Language :: Python :: 3.6",
         "Programming Language :: Python :: 3.7",

tankersdk_identity/__init__.py

@@ -20,7 +20,6 @@ def _hash_user_id(app_id, user_id):
 
 def _generate_app_id(app_secret):
     public_key = app_secret[APP_SECRET_SIZE - APP_PUBLIC_KEY_SIZE:APP_SECRET_SIZE]
-    # A bit convoluted, to make it work with python 2.7
     to_hash = bytes(bytearray([APP_CREATION_NATURE] + [0] * AUTHOR_SIZE)) + public_key
     return tankersdk_identity.crypto.generichash(to_hash, size=BLOCK_HASH_SIZE)