feat: remove get_device_list

Author: francisco-tanker

cffi_defs.h

@@ -239,23 +239,10 @@ typedef struct tanker_verification_options tanker_verification_options_t;
 typedef struct tanker_encrypt_options tanker_encrypt_options_t;
 typedef struct tanker_sharing_options tanker_sharing_options_t;
 typedef struct tanker_log_record tanker_log_record_t;
-typedef struct tanker_device_list_elem tanker_device_list_elem_t;
-typedef struct tanker_device_list tanker_device_list_t;
 typedef struct tanker_verification_method_list
     tanker_verification_method_list_t;
 typedef struct tanker_attach_result tanker_attach_result_t;
 
-struct tanker_device_list
-{
-  tanker_device_list_elem_t* devices;
-  uint32_t count;
-};
-
-struct tanker_device_list_elem
-{
-  char const* device_id;
-};
-
 struct tanker_verification_method_list
 {
   tanker_verification_method_t* methods;
@@ -409,8 +396,6 @@ enum tanker_status tanker_status(tanker_t* tanker);
 
 tanker_future_t* tanker_device_id(tanker_t* session);
 
-tanker_future_t* tanker_get_device_list(tanker_t* session);
-
 tanker_future_t* tanker_generate_verification_key(tanker_t* session);
 
 tanker_future_t* tanker_set_verification_method(
@@ -452,8 +437,6 @@ tanker_future_t* tanker_verify_provisional_identity(
 
 void tanker_free_buffer(void const* buffer);
 
-void tanker_free_device_list(tanker_device_list_t* list);
-
 void tanker_free_verification_method_list(
     tanker_verification_method_list_t* list);
 

tankersdk/tanker.py

@@ -480,22 +480,6 @@ def get(self) -> CData:
         return self._c_verification_list
 
 
-class Device:
-    """An element of the list returned by `tanker.get_device_list()`
-
-    :ivar device_id: The id of the device
-
-    """
-
-    def __init__(self, device_id: str):
-        self.device_id = device_id
-
-    @classmethod
-    def from_c(cls, c_device_list_elem: CData) -> "Device":
-        device_id = ffihelpers.c_string_to_str(c_device_list_elem.device_id)
-        return cls(device_id)
-
-
 class InputStream(typing_extensions.Protocol):
     async def read(self, size: int) -> bytes:
         ...
@@ -915,29 +899,6 @@ async def device_id(self) -> str:
         tankerlib.tanker_free_buffer(c_str)
         return res
 
-    async def get_device_list(self) -> List[Device]:
-        """Get the list of devices owned by the current user
-
-        :returns: a list of :py:class`Device` instances
-        """
-        warnings.warn(
-            'The "get_device_list" method is deprecated, it will be removed in the future',
-            DeprecationWarning,
-        )
-
-        c_future = tankerlib.tanker_get_device_list(self.c_tanker)
-        c_voidp = await ffihelpers.handle_tanker_future(c_future)
-        c_list = ffi.cast("tanker_device_list_t*", c_voidp)
-        count = c_list.count
-        c_devices = c_list.devices
-        res = []
-        for i in range(count):
-            c_device_list_elem = c_devices[i]
-            device_description = Device.from_c(c_device_list_elem)
-            res.append(device_description)
-        tankerlib.tanker_free_device_list(c_list)
-        return res
-
     def get_resource_id(self, encrypted_data: bytes) -> str:
         """Get resource ID from `encrypted` data"""
         c_expected = tankerlib.tanker_get_resource_id(

test/test_tanker.py

@@ -804,17 +804,6 @@ async def test_add_device(tmp_path: Path, app: Dict[str, str]) -> None:
     await phone.stop()
 
 
-@pytest.mark.asyncio
-async def test_get_device_list(tmp_path: Path, app: Dict[str, str]) -> None:
-    _, laptop, phone = await create_two_devices(tmp_path, app)
-    laptop_id = await laptop.device_id()
-    phone_id = await phone.device_id()
-
-    actual_list = await phone.get_device_list()
-    actual_ids = [x.device_id for x in actual_list]
-    assert set(actual_ids) == {laptop_id, phone_id}
-
-
 @pytest.mark.asyncio
 async def test_must_verify_identity_on_second_device(
     tmp_path: Path, app: Dict[str, str]