Fix Update Changelog workflow push failure#26
Merged
Merged
Conversation
…mitish target_commitish can be a raw commit SHA instead of a branch name, which broke git-auto-commit-action's push.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update Changelogworkflow (triggered onrelease: released) failed because it pushed togithub.event.release.target_commitish, which can be a raw commit SHA rather than a branch name.git-auto-commit-actionthen tried to push to a branch named after that SHA and git rejected it with "not a full refname."refand the commit action'sbranchto usegithub.event.repository.default_branchinstead, so the changelog update always targets a real branch.v2.4.1changelog entry that failed to commit during the broken run.See the failing run: https://github.com/TappNetwork/Filament-Forum/actions/runs/28719111134/job/85165569236
Test plan
Update Changelogworkflow succeeds and pushes the CHANGELOG.md update tomain