Skip to content

Fix CI compatibility for Excel 4 and Laravel CSRF middleware#101

Merged
swilla merged 4 commits into
4.xfrom
fix-failing-ci-action
Apr 28, 2026
Merged

Fix CI compatibility for Excel 4 and Laravel CSRF middleware#101
swilla merged 4 commits into
4.xfrom
fix-failing-ci-action

Conversation

@swilla

@swilla swilla commented Apr 28, 2026

Copy link
Copy Markdown
Member

What changed

  • Bumped maatwebsite/excel in composer.json from ^3.1 to ^4.0 to align with tapp/filament-form-builder v4.3.3.
  • Updated panel middleware from VerifyCsrfToken to PreventRequestForgery in LmsPanelProvider for current Laravel compatibility.

Why

This branch addresses CI and dependency compatibility issues after the Form Builder Excel 4.x support release. These updates ensure dependency resolution succeeds and the panel middleware uses the supported framework class.

Made with Cursor


Note

Low Risk
Small dependency bump and middleware class selection change; main risk is runtime incompatibility if the CSRF middleware class resolution behaves differently across supported Laravel versions.

Overview
Bumps maatwebsite/excel from ^3.1 to ^4.0 to resolve dependency/CI compatibility with newer integrations.

Updates LmsPanelProvider to use Laravel’s newer PreventRequestForgery middleware when available, falling back to VerifyCsrfToken via a small csrfMiddleware() helper for cross-version support.

Reviewed by Cursor Bugbot for commit 2d20198. Bugbot is set up for automated code reviews on this repo. Configure here.

Align dependency requirements with form-builder v4.3.3 by requiring Laravel Excel 4.x, and switch to PreventRequestForgery middleware for current Laravel compatibility.

Made-with: Cursor

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit b862d73. Configure here.

Comment thread src/LmsPanelProvider.php
swilla and others added 3 commits April 28, 2026 06:26
Use VerifyCsrfToken in the panel middleware stack so the package remains compatible with both Laravel 12 and 13.

Made-with: Cursor
Resolve the panel CSRF middleware class at runtime so Laravel 13 uses PreventRequestForgery while Laravel 12 still falls back to VerifyCsrfToken without triggering deprecation analysis.

Made-with: Cursor
@swilla swilla merged commit 5f10bed into 4.x Apr 28, 2026
1 check passed
@swilla swilla deleted the fix-failing-ci-action branch April 28, 2026 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant