Import Common Cartridge and SCORM packages#105
Open
swilla wants to merge 16 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9c51df1. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
imsmanifest.xml, build courses/lessons/steps from cartridge structure, and extract Articulate Storyline slide content into document steps where possible.filament-lms:import-cartridgesArtisan command (sync or queued), with completion notifications and config undercommon_cartridge_import.Test plan
vendor/bin/pest tests/Feature/CommonCartridgeImportTest.php tests/Feature/ImportCartridgesCommandTest.php tests/Feature/ScormPackageServingTest.phpscorm_package_*columns onlms_documents)filament-lms:import-cartridges --file=... --sync) and verify SCORM content loads in a document stepMade with Cursor
Note
High Risk
Large feature touching authenticated package serving, client-side SCORM bridges, and completion rules that affect course progress records.
Overview
Adds Common Cartridge / SCORM ZIP import (admin upload +
filament-lms:import-cartridgesCLI) that builds courses from manifests or Articulateframe.xml, retains extracted packages on documents, and can turn Storyline slides into steps/tests.Imported package courses can run in embedded player mode with
completion_modenative, SCORM 1.2 (in-pageAPIbridge +ScormProgressService), or HTML5 (player postMessage, session minimums, guarded exit/complete). AuthenticatedScormPackageControllerserves package files (path traversal checks, SVG CSP);ScormCommitControllerrecords progress.Filament/LMS UX: course fields for embedded player + completion mode, launch-step-only navigation, full-width player CSS, document steps iframe SCORM packages,
LmsTestFormShowcard-style MCQ radios, andStep::getRenderedText()sanitization for imported HTML.Reviewed by Cursor Bugbot for commit 188c2e2. Bugbot is set up for automated code reviews on this repo. Configure here.