Trim newlines from machine ID file read on linux + support plain sha256 digest#30
Open
jmif wants to merge 2 commits into
Open
Trim newlines from machine ID file read on linux + support plain sha256 digest#30jmif wants to merge 2 commits into
jmif wants to merge 2 commits into
Conversation
jmif
changed the title
jmif
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A newline character is read from the machine ID file on Linux and this newline is included in the hash of the ID, changing its value. This PR trims the
hwidresult before returning to remove the newline.There are likely some backwards compatibility issues to consider here as this will change the machine IDs that are output from this library.