Add option to add aria-label attribute#375
Conversation
|
In the latest commit 7a6dcf0 my IDE in auto formatting make some changes in spaces, lines or convert asterisks to hyphen. I will be back with the fix to keep only the change to the document I want to apply about ariaLabel. |
|
Hello @th3c0r, I apologize for my very delayed reply on this one. Good catch! Accessibility is a top priority for autoComplete.js, and adding support for I have this on my radar and will be addressing it as part of the upcoming v11 release, where accessibility is getting a broader overhaul. Your PR will be used as a reference for this specific improvement. I will be publishing the v11 release plan soon, so stay connected for updates. Thanks for your valuable contribution, much appreciated! Have a nice day, cheers! :) |
|
@TarekRaafat Thank you for taking a look at the issue I originally submitted and @th3c0r created the solution for it. We appreciate it. Thank you! 508 is very important and anyway we can make the web more accessible the better for everyone! With all of that said, do you think there is any possibility to get this merged into v10 ? I originally reported this 4 yrs ago so would love it if we could get this into the version that we are using now. |
|
Hello @robbiegod, Thanks for following up on this, and apologies for any confusion from my earlier comment. Good news on both fronts. The
So you will not need to wait for v11 to get this. The v10.3.0 release is close, and the broader WAI-ARIA You can track the full plan here: ROADMAP.md Thanks for following up on this and for your patience over the years, it really does mean a lot. Accessibility is a top priority for autoComplete.js and contributions and feedback like yours are what keep moving it forward.
Have a nice day, cheers! :) |
Allow the users to add the aria-label option to the wrapper if wrapper exists, or to the main input element.
This fix the issue #372