Update Safe Routes to School.json - #50
Conversation
…is an additional instance of a feature
uw-amy-bordenave
left a comment
There was a problem hiding this comment.
Thank you for improving the pictures links, @shockwave656!
Have you run the /Review-Quest-Definition quests\prod\Safe Routes to School\Safe Routes to School.json prompt? This will return a review of the quest definition that highlights possible issues. Like any AI output, you can't trust it implicitly; however, it's very helpful for finding potential issues.
Example output, which I checked and verified that the majority of the feedback does identify needed changes:
Review summary
The quest definition is valid against the schema:
- File:
quests/prod/Safe Routes to School/Safe Routes to School.json- Schema: v3.0.0
- Questions: 184 across 5 element types
- Validator result: Passed
- Duplicate quest IDs/tags: None
- Missing dependency targets: None
- Dependency cycles: None
- Image URL syntax: Valid
Findings
1. Critical: many “additional instance” questions are not gated
There are 65 questions tagged with
_additional; 51 do not havequest_answer_dependency. Their titles say they should only be answered for an additional feature instance, but the schema will expose them unconditionally.Examples:
1018,1020,1026,1028,1030,1032,1034,10362016,2019,2023,2025,2027,2029,2035,2037,2039,20413013,3019,3023,3025,3027,3029,3031,3033,3037,3039,3045,3047,3049,3051,3055,3057,3059,3061,30634009,4011,4014,4018,4020,40225010,5012,5014,5016,5018,5020,5022,5024This is inconsistent with existing paired questions such as
1021/1022,3040/3041, and5011/5012patterns. Add dependencies to the appropriate primary-instance or feature-presence question, or remove the “additional instance” wording if these are intentionally always shown.2. Important: curb-ramp additional measurements lack the primary ramp dependency
The primary curb-ramp measurements are gated by question
5001, but the additional versions are not:
5012— ramp width5014— running slope5016— cross slope5018— landing width5020— landing depth5022— side-flare slope5024— surface materialThey should likely retain the same
5001dependency as their corresponding “home” questions, in addition to whatever mechanism identifies the additional instance.3. Important: driveway questions are not conditionally gated
The following questions ask about driveways but are always visible:
1029— driveway count1030— additional driveway count1031/1032— driveway-level path1033/1034— widest driveway
1031provides anN/A (No driveways)answer, but the count and width questions do not. Consider either:
- adding a consistent “no driveways” option/dependency strategy, or
- gating follow-up questions based on
1029 > 0if the dependency system supports numeric comparisons.4. Important:
1013has conflicting MultipleChoice sentinel valuesQuestion
1013includes both:
none_observed_or_knownunable_to_determinealongside many selectable conditions. A MultipleChoice control may allow combinations such as:
none_observed_or_known+leaf_fallunable_to_determine+flooding_or_drainageThese sentinel choices should normally be mutually exclusive with substantive answers. The current v3 schema does not express that constraint.
5. Suggestion: numeric units should be standardized
Most sidewalk and buffer measurements use feet, while curb-ramp measurements use inches:
1007,1023,1024,1033,1034: feet5011–5020: inchesThis may be intentional, but it increases field-user error risk. Consider standardizing units or making the unit especially prominent in both the title and description.
6. Suggestion: wording and data type mismatch
Question
3022/3023areExclusiveChoicequestions titled “How many landing pads,” but the answers are categories such as “All three doors” and “Front door only.” A title such as “Which boarding positions have landing pads?” would better match the data.Recommended priority
- Fix missing dependencies for the 51
_additionalquestions.- Gate the curb-ramp additional measurements consistently with the primary ramp questions.
- Resolve sentinel behavior in MultipleChoice questions, especially
1013.- Decide how zero/unknown driveway measurements should be represented.
- Re-run the validator after changes; the current validator will not detect these semantic issues.


The quests have been updated to reflect feedback from Anat - the biggest change for the quests is that they are now based on what we have for the KCM Walk Audit quest form, though there have been some edits made here that aren't present in the KCM Walk Audit quest form.