Fix double-JSON.parse() call

Author: jeffmaki

pages/dashboard.vue

@@ -136,11 +136,8 @@ const currentWorkspaceTdeiRoles = computed(() =>
     : [],
 );
 
-for (const w of workspaces) {
-  if (w.tdeiMetadata && w.tdeiMetadata.length > 0) {
-    w.tdeiMetadata = JSON.parse(w.tdeiMetadata);
-  }
-}
+// `tdeiMetadata` is already parsed into an object by `normalizeWorkspace`
+// (in `getMyWorkspaces`), so no per-workspace re-parse is needed here.
 
 onMounted(() => {
   watch(currentWorkspace, (val) => {

pages/workspace/[id]/export/tdei.vue

@@ -266,7 +266,8 @@ if (canExport && !eligibleProjectGroups.some(pg => pg.tdei_project_group_id ===
   workspace.tdeiProjectGroupId = eligibleProjectGroups[0]!.tdei_project_group_id;
 }
 
-const oldMetadata = workspace.tdeiMetadata ? JSON.parse(workspace.tdeiMetadata) : {};
+// Already parsed into an object by `normalizeWorkspace` in `getWorkspace`.
+const oldMetadata = (workspace.tdeiMetadata as any) ?? {};
 
 const datasetName = ref(workspace.title);
 const datasetVersion = ref(oldMetadata.metadata?.dataset_detail?.version);

services/workspaces.ts

@@ -30,11 +30,29 @@ export function compareWorkspaceCreatedAtDesc(a: Workspace, b: Workspace) {
   return b.createdAt.getTime() - a.createdAt.getTime();
 }
 
+/**
+ * The API is inconsistent about `tdeiMetadata`: some responses send it as a
+ * JSON-encoded string, others as an already-parsed object. Tolerate both (and
+ * malformed values) so we never call `JSON.parse` on a non-string — doing so
+ * coerces the object to "[object Object]" and throws a SyntaxError.
+ */
+function parseTdeiMetadata(value: Workspace['tdeiMetadata']): unknown {
+  if (value == null || value === '') return {};
+  if (typeof value !== 'string') return value;
+
+  try {
+    return JSON.parse(value);
+  }
+  catch {
+    return {};
+  }
+}
+
 function normalizeWorkspace(workspace: Workspace): Workspace {
   return {
     ...workspace,
     createdAt: new Date(workspace.createdAt),
-    tdeiMetadata: JSON.parse(workspace.tdeiMetadata || '{}'),
+    tdeiMetadata: parseTdeiMetadata(workspace.tdeiMetadata) as Workspace['tdeiMetadata'],
   };
 }
 

test/unit/services/workspaces.test.ts

@@ -33,6 +33,29 @@ describe('WorkspacesClient.getMyWorkspaces', () => {
     expect(workspaces[0]!.createdAt.toISOString()).toBe('2026-01-15T12:00:00.000Z');
   });
 
+  // Regression: the API sends `tdeiMetadata` inconsistently — sometimes a
+  // JSON-encoded string, sometimes an already-parsed object. Blindly calling
+  // JSON.parse() on the object form coerces it to "[object Object]" and throws
+  // `SyntaxError: "[object Object]" is not valid JSON`, which used to blow up
+  // the dashboard's <script setup>. Normalize must tolerate every form.
+  it.each([
+    ['a JSON-encoded string', '{"metadata":{"foo":"bar"}}', { metadata: { foo: 'bar' } }],
+    ['an already-parsed object', { metadata: { foo: 'bar' } }, { metadata: { foo: 'bar' } }],
+    ['null', null, {}],
+    ['an empty string', '', {}],
+    ['a malformed JSON string', '{not json', {}]
+  ])('parses tdeiMetadata when the API returns %s', async (_label, raw, expected) => {
+    server.use(
+      http.get(`${TEST_API_BASE}workspaces/mine`, () => {
+        return HttpResponse.json([{ id: 1, title: 'W', createdAt: '2026-01-15T12:00:00.000Z', tdeiMetadata: raw }]);
+      })
+    );
+
+    const [workspace] = await makeClient().getMyWorkspaces();
+
+    expect(workspace!.tdeiMetadata).toEqual(expected);
+  });
+
   it('throws a WorkspacesClientError on a non-2xx response', async () => {
     // Per-test override: make the endpoint fail. Reset automatically afterEach.
     server.use(