Linter

Author: jeffmaki

playwright.config.ts

@@ -27,7 +27,11 @@ export default defineConfig({
   fullyParallel: true,
   forbidOnly: !!process.env.CI,
   retries: process.env.CI ? 2 : 0,
-  reporter: process.env.CI ? 'github' : 'list',
+  // In CI: 'github' annotates the Actions log, and 'html' writes the
+  // playwright-report/ dir that the CI workflow uploads as an artifact.
+  reporter: process.env.CI
+    ? [['github'], ['html', { open: 'never' }]]
+    : 'list',
   // The Nuxt dev server compiles routes lazily on first hit, so a cold parallel
   // request can take several seconds to render. A roomy expect timeout absorbs
   // that without masking real failures. (Run E2E against `nuxt build && preview`

services/export/tdei.ts

@@ -103,6 +103,8 @@ export class TdeiExporter {
   }
 
   async _exportOswToTdei(workspace: Workspace, metadata: any): Promise<string> {
+    const tdeiServiceId = this._requireServiceId(workspace);
+
     this._context.status = status.exportOsm;
     const osm = await this._osmClient.exportWorkspaceXml(workspace.id);
 
@@ -113,7 +115,7 @@ export class TdeiExporter {
     const jobId = await this._tdeiClient.uploadOswDataset(
       (await this._filterNonexistentDataset(workspace.tdeiRecordId)),
       workspace.tdeiProjectGroupId,
-      workspace.tdeiServiceId!,
+      tdeiServiceId,
       oswZip,
       { dataset_detail: metadata }
     );
@@ -124,6 +126,8 @@ export class TdeiExporter {
   }
 
   async _exportPathwaysToTdei(workspace: Workspace, metadata: any): Promise<string> {
+    const tdeiServiceId = this._requireServiceId(workspace);
+
     this._context.status = status.exportOsm;
     const elements = await this._osmClient.getWorkspaceData(workspace.id);
     const derivedFromDatasetId = await this._filterNonexistentDataset(workspace.tdeiRecordId);
@@ -136,7 +140,7 @@ export class TdeiExporter {
     const jobId = await this._tdeiClient.uploadPathwaysDataset(
       derivedFromDatasetId,
       workspace.tdeiProjectGroupId,
-      workspace.tdeiServiceId!,
+      tdeiServiceId,
       csvZip,
       { dataset_detail: metadata }
     );
@@ -146,6 +150,19 @@ export class TdeiExporter {
     return jobId
   }
 
+  // The TDEI upload endpoints require a service id to build the request URL.
+  // Validate it up front so we fail fast with a clear message instead of
+  // sending `undefined` onward to the service layer.
+  _requireServiceId(workspace: Workspace): string {
+    if (!workspace.tdeiServiceId) {
+      throw new Error(
+        `Workspace ${workspace.id} has no TDEI service id; cannot export to TDEI.`
+      );
+    }
+
+    return workspace.tdeiServiceId;
+  }
+
   async _filterNonexistentDataset(tdeiRecordId: string | undefined): Promise<string | undefined> {
     if (!tdeiRecordId) {
       return undefined;

test/e2e/contract.ts

@@ -134,18 +134,27 @@ export function recordContract(page: Page) {
         // Response body
         const resDef = op.responses?.[String(c.status)] ?? op.responses?.default;
         const resSchema = resDef?.content?.['application/json']?.schema;
-        if (resSchema && c.contentType.includes('application/json') && c.resText) {
-          try {
-            const v = validatorFor(resSchema, `${match.key}|${c.method}|res|${c.status}`);
-            if (!v(JSON.parse(c.resText))) {
+        // Validate any response that claims application/json, even with an empty
+        // body: an empty/missing body where the spec expects JSON is a violation,
+        // not something to skip (gating on c.resText hid that case).
+        if (resSchema && c.contentType.includes('application/json')) {
+          if (!c.resText) {
+            out.push({ method: c.method, path: c.recordedPath, status: c.status, where: 'response',
+              message: 'expected an application/json response body but it was empty' });
+          }
+          else {
+            try {
+              const v = validatorFor(resSchema, `${match.key}|${c.method}|res|${c.status}`);
+              if (!v(JSON.parse(c.resText))) {
+                out.push({ method: c.method, path: c.recordedPath, status: c.status, where: 'response',
+                  message: ajv.errorsText(v.errors) });
+              }
+            }
+            catch (e) {
               out.push({ method: c.method, path: c.recordedPath, status: c.status, where: 'response',
-                message: ajv.errorsText(v.errors) });
+                message: `response body not valid JSON: ${(e as Error).message}` });
             }
           }
-          catch (e) {
-            out.push({ method: c.method, path: c.recordedPath, status: c.status, where: 'response',
-              message: `response body not valid JSON: ${(e as Error).message}` });
-          }
         }
       }
       return out;

test/e2e/dashboard.spec.ts

@@ -1,6 +1,6 @@
 import { test, expect, seedAuthenticatedSession, seedProjectGroupSelection } from './fixtures';
 import { recordContract } from './contract';
-import { projectGroups, PROJECT_GROUP_ID } from '../mocks/fixtures';
+import { projectGroups, PROJECT_GROUP_ID, TEST_API_BASE } from '../mocks/fixtures';
 
 // Generated from the @test outline in pages/dashboard.vue.
 //
@@ -21,8 +21,8 @@ test.describe('dashboard', () => {
   // (The populated WorkspaceResponse shape is also asserted at the unit level.)
   test('makes no new-API calls that violate the OpenAPI spec', async ({ page }) => {
     await seedAuthenticatedSession(page);
-    await page.route('**/workspaces/mine', EMPTY);
-    await page.route('**/project-group-roles/**', EMPTY);
+    await page.route(`${TEST_API_BASE}workspaces/mine`, EMPTY);
+    await page.route(`${TEST_API_BASE}tdei-user/project-group-roles/**`, EMPTY);
 
     const contract = recordContract(page);
     await page.goto('/dashboard');
@@ -34,8 +34,8 @@ test.describe('dashboard', () => {
   // @test e2e: the page renders with a simulated API response with no project groups
   test('shows the empty notice when the user has no project groups', async ({ page }) => {
     await seedAuthenticatedSession(page);
-    await page.route('**/workspaces/mine', EMPTY);
-    await page.route('**/project-group-roles/**', EMPTY);
+    await page.route(`${TEST_API_BASE}workspaces/mine`, EMPTY);
+    await page.route(`${TEST_API_BASE}tdei-user/project-group-roles/**`, EMPTY);
 
     await page.goto('/dashboard');
 
@@ -46,8 +46,8 @@ test.describe('dashboard', () => {
   test('shows the empty notice when the selected project group has no workspaces', async ({ page }) => {
     await seedAuthenticatedSession(page);
     await seedProjectGroupSelection(page, { id: PROJECT_GROUP_ID, name: 'Puget Sound' });
-    await page.route('**/workspaces/mine', EMPTY); // group exists, but no workspaces in it
-    await page.route('**/project-group-roles/**', route => route.fulfill({ json: projectGroups }));
+    await page.route(`${TEST_API_BASE}workspaces/mine`, EMPTY); // group exists, but no workspaces in it
+    await page.route(`${TEST_API_BASE}tdei-user/project-group-roles/**`, route => route.fulfill({ json: projectGroups }));
 
     await page.goto('/dashboard');
 

test/e2e/export-index.spec.ts

@@ -131,7 +131,9 @@ test.describe('workspace export landing page', () => {
 
     release();
 
-    // Ready state: the button is replaced by a "Save" link.
+    // Ready state: the button is replaced by a "Save" link. Assert the stable
+    // link text/visibility only — its href is a volatile blob: URL, so we don't
+    // ARIA-snapshot it (file-based aria snapshots capture the blob URL exactly).
     const save = page.getByRole('link', { name: /Save/ });
     await expect(save).toBeVisible();
 

test/e2e/export-index.spec.ts-snapshots/workspace-export-landing-page-the-Download-flo-801cf--clicking-Save-downloads-the-file-snapshots-3.aria.yml

@@ -245,10 +245,10 @@ test('an API error shows an error message and a Try again button that resets the
   await stubPageLoad(page, [eligibleProjectGroup]);
   await stubServices(page);
 
-  await page.route('**/osm/workspaces/1/bbox.json', route =>
+  await page.route('**/osm/api/0.6/workspaces/1/bbox.json', route =>
     route.fulfill({ json: { min_lat: 47.6, min_lon: -122.34, max_lat: 47.62, max_lon: -122.32 } })
   );
-  await page.route('**/osm/map?**', route =>
+  await page.route('**/osm/api/0.6/map?**', route =>
     route.fulfill({ body: '<osm></osm>', contentType: 'application/xml' })
   );
   await page.route('**/osw/convert', route => route.fulfill({ body: 'job-1', contentType: 'text/plain' }));

test/e2e/export-tdei.spec.ts

@@ -1,4 +1,4 @@
 - alert:
   - heading " An error occurred:" [level=5]
-  - paragraph: "Unexpected error: TypeError: Failed to fetch (api.test)"
+  - paragraph: "TDEI rejected the upload: Internal server error"
   - button "Try again"

test/e2e/export-tdei.spec.ts-snapshots/an-API-error-shows-an-error-message-and-a-Try-again-button-that-resets-the-form-1.aria.yml

@@ -1,6 +1,6 @@
 import { test as base, expect } from '@playwright/test';
 import type { Page } from '@playwright/test';
-import { myWorkspaces, USER_ID } from '../mocks/fixtures';
+import { myWorkspaces, USER_ID, TEST_API_BASE } from '../mocks/fixtures';
 
 // The display name shown in the navbar for the seeded session.
 export const TEST_USER = { subject: USER_ID, displayName: 'Tester' };
@@ -42,12 +42,12 @@ export async function seedProjectGroupSelection(page: Page, group: { id: string;
 // test flag.
 export const test = base.extend({
   page: async ({ page }, use) => {
-    await page.route('**/workspaces/mine', route =>
+    await page.route(`${TEST_API_BASE}workspaces/mine`, route =>
       route.fulfill({ json: myWorkspaces })
     );
 
     // Add further stubs here as flows need them, e.g.:
-    // await page.route('**/workspaces/ws-1', route => route.fulfill({ json: ... }))
+    // await page.route(`${TEST_API_BASE}workspaces/ws-1`, route => route.fulfill({ json: ... }))
 
     await use(page);
   }

test/e2e/fixtures.ts

@@ -1,5 +1,5 @@
 import { test, expect, seedAuthenticatedSession } from './fixtures';
-import { aWorkspace, USER_ID } from '../mocks/fixtures';
+import { aWorkspace, USER_ID, TEST_API_BASE } from '../mocks/fixtures';
 
 // Generated from the @test outline in pages/workspace/[id]/teams/[teamId].vue
 // (the "Join Team" page).
@@ -56,14 +56,14 @@ const joinedUser = {
 
 // Stub the three top-level awaits. `members` controls join state.
 async function stubPageLoad(page: Page, members: object[]) {
-  await page.route(`**/workspaces/${WORKSPACE_ID}`, route =>
+  await page.route(`${TEST_API_BASE}workspaces/${WORKSPACE_ID}`, route =>
     route.fulfill({ json: aWorkspace })
   );
-  await page.route(`**/workspaces/${WORKSPACE_ID}/teams/${TEAM_ID}`, route =>
+  await page.route(`${TEST_API_BASE}workspaces/${WORKSPACE_ID}/teams/${TEAM_ID}`, route =>
     route.fulfill({ json: team })
   );
   // GET lists members; POST (joinTeam) returns the joining User. Same URL.
-  await page.route(`**/workspaces/${WORKSPACE_ID}/teams/${TEAM_ID}/members`, (route) => {
+  await page.route(`${TEST_API_BASE}workspaces/${WORKSPACE_ID}/teams/${TEAM_ID}/members`, (route) => {
     if (route.request().method() === 'POST') {
       return route.fulfill({ json: joinedUser });
     }