Skip to content

Commit 78d9309

Browse files
committed
Remove editor load fail test
1 parent 5bfd83e commit 78d9309

3 files changed

Lines changed: 5 additions & 24 deletions

File tree

CLAUDE.md

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -190,9 +190,8 @@ would have to be enforced by the backend / changeset-validation flow.
190190

191191
## Test status
192192

193-
The e2e suite currently passes aside from **7 intentionally-skipped tests**: 6
194-
`test.fixme` dashboard flows blocked by maplibre/external-editor rendering, plus
195-
the edit "editor fails to load" test (disabled per its page outline — the page
196-
has no editor-load-failure UI yet). Some heavy authed pages (e.g.
197-
`settings/members`) can flake under high parallelism (the lazy-compile issue
198-
above) — run serially (`--workers=1`) for deterministic results.
193+
The e2e suite currently passes aside from **6 intentionally-skipped tests**: 6
194+
`test.fixme` dashboard flows blocked by maplibre/external-editor rendering. Some
195+
heavy authed pages (e.g. `settings/members`) can flake under high parallelism
196+
(the lazy-compile issue above) — run serially (`--workers=1`) for deterministic
197+
results.

pages/workspace/[id]/edit.vue

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
// @test e2e: loading this page successfully loads the Rapid editor with the workspace data, and shows the editor UI (playwright snapshot this)
33
// @test e2e: loading this page with each. value of the "editor" query param (e.g. rapid vs rapid3) loads the correct editor version (playwright snapshot each version's UI)
44
// @test e2e: loading this page with the "osw" datatype query param loads the OpenSidewalks editor, and without it loads the Pathways editor (playwright snapshot each editor's UI)
5-
// @test e2e (disable this test for now): if the editor fails to load, an error message is shown (playwright snapshot this)
65
// @test e2e: validate that all the API calls used on this page match the Swagger spec (https://new-api.workspaces-stage.sidewalks.washington.edu/openapi.json)
76

87
<template>

test/e2e/edit.spec.ts

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -175,23 +175,6 @@ test.describe('workspace edit (editor host)', () => {
175175
await expect(page.locator('.editorContainer')).toMatchAriaSnapshot();
176176
});
177177

178-
// @test e2e (disable this test for now): if the editor fails to load, an error message is shown (playwright snapshot this)
179-
// Disabled per the page outline: the page has no editor-load-failure UI yet.
180-
test.fixme('shows an error message when the editor fails to load', async ({ page }) => {
181-
await seedAuthenticatedSession(page);
182-
await stubAllEditors(page);
183-
// Make the chosen editor's script fail to load.
184-
await page.unroute('**/rapid/rapid.js');
185-
await page.route('**/rapid/rapid.js', route => route.abort());
186-
187-
await page.goto('/workspace/1/edit?datatype=osw&editor=rapid');
188-
189-
// The page should surface a user-facing error when the editor can't load.
190-
const error = page.getByText(/fail|error|could ?n.t|unable/i);
191-
await expect(error).toBeVisible();
192-
await expect(page.locator('.editorContainer')).toMatchAriaSnapshot();
193-
});
194-
195178
// @test e2e: validate that all the API calls used on this page match the Swagger spec
196179
test('all API calls conform to the OpenAPI spec', async ({ page }) => {
197180
await seedAuthenticatedSession(page);

0 commit comments

Comments
 (0)