-
Notifications
You must be signed in to change notification settings - Fork 1
Bug fixes: Improve Task Workflows, Project Permissions, Pagination, and UI Consistency #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shweta2101
wants to merge
12
commits into
develop
Choose a base branch
from
bugfix-4077-tasks-limit
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
09d46f8
Area unit toggle, task editor & permission updates
shweta2101 50d9b42
Add task editor panels, area toggle, and composables
shweta2101 dedfec9
Fix changeset attach race and TDEI role fetch
shweta2101 c39d302
Remove per-item action buttons and z-index hacks
shweta2101 aa71f91
fixed text editor
shweta2101 6c1236d
Merge branch 'develop' into bugfix-4077-tasks-limit
shweta2101 661622b
Refactor theme/UI, paging and role handling
shweta2101 b005bc6
removed unnecessary commit
shweta2101 25915ae
Protect lead role and update role UI
shweta2101 10007cb
minor text change added
shweta2101 ef1288f
Mark image/table tools active; improve skip error
shweta2101 7f41165
Add workspace/project role-based access doc
shweta2101 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,90 @@ | ||
| <template> | ||
| <div | ||
| class="area-unit-toggle" | ||
| :class="`area-unit-toggle-${size}`" | ||
| role="group" | ||
| :aria-label="label" | ||
| > | ||
| <button | ||
| v-for="option in AREA_UNIT_OPTIONS" | ||
| :key="option.value" | ||
| class="area-unit-toggle-option" | ||
| :class="{ 'area-unit-toggle-option-active': areaDisplayUnit === option.value }" | ||
| type="button" | ||
| :aria-pressed="areaDisplayUnit === option.value" | ||
| :disabled="disabled" | ||
| @click="areaDisplayUnit = option.value" | ||
| > | ||
| {{ option.label }} | ||
| </button> | ||
| </div> | ||
| </template> | ||
|
|
||
| <script setup lang="ts"> | ||
| import { AREA_UNIT_OPTIONS, type AreaDisplayUnit } from '~/util/area'; | ||
|
|
||
| interface Props { | ||
| disabled?: boolean; | ||
| label: string; | ||
| size?: 'sm' | 'md'; | ||
| } | ||
|
|
||
| withDefaults(defineProps<Props>(), { | ||
| disabled: false, | ||
| size: 'sm', | ||
| }); | ||
|
|
||
| const areaDisplayUnit = defineModel<AreaDisplayUnit>({ required: true }); | ||
| </script> | ||
|
|
||
| <style lang="scss" scoped> | ||
| @import "~/assets/scss/theme.scss"; | ||
|
|
||
| .area-unit-toggle { | ||
| display: inline-flex; | ||
| padding: 0.15rem; | ||
| background: rgba($text-navy, 0.06); | ||
| border: 1px solid rgba($text-navy, 0.12); | ||
| border-radius: 0.45rem; | ||
| } | ||
|
|
||
| .area-unit-toggle-option { | ||
| min-width: 2.8rem; | ||
| padding: 0.3rem 0.45rem; | ||
| color: $secondary; | ||
| font-size: 0.78rem; | ||
| font-weight: 700; | ||
| line-height: 1; | ||
| background: transparent; | ||
| border: 0; | ||
| border-radius: 0.32rem; | ||
| } | ||
|
|
||
| .area-unit-toggle-md { | ||
| padding: 0.2rem; | ||
| border-radius: 0.55rem; | ||
| } | ||
|
|
||
| .area-unit-toggle-md .area-unit-toggle-option { | ||
| min-width: 3.25rem; | ||
| padding: 0.35rem 0.55rem; | ||
| font-size: 0.85rem; | ||
| border-radius: 0.4rem; | ||
| } | ||
|
|
||
| .area-unit-toggle-option:hover:not(:disabled), | ||
| .area-unit-toggle-option:focus-visible { | ||
| color: $text-navy; | ||
| } | ||
|
|
||
| .area-unit-toggle-option:focus-visible { | ||
| outline: 0; | ||
| box-shadow: 0 0 0 0.2rem rgba($primary, 0.16); | ||
| } | ||
|
|
||
| .area-unit-toggle-option-active { | ||
| color: $text-navy; | ||
| background: $white; | ||
| box-shadow: $box-shadow-sm; | ||
| } | ||
| </style> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.