Bounce rules with id as param

Author: tatevikg1

src/Endpoint/BouncesClient.php

@@ -106,31 +106,31 @@ public function upsertRegex(array $data): array
     }
 
     /**
-     * Get a bounce regex rule by its hash.
+     * Get a bounce regex rule by its id.
      *
-     * GET /api/v2/bounces/regex/{regexHash}
+     * GET /api/v2/bounces/regex/{ruleId}
      *
-     * @param string $regexHash The regex hash
+     * @param int $ruleId The regex id
      * @return array The regex data
      * @throws ApiException If an API error occurs
      */
-    public function getRegexByHash(string $regexHash): array
+    public function getOne(int $ruleId): array
     {
-        return $this->client->get('bounces/regex/' . rawurlencode($regexHash));
+        return $this->client->get('bounces/regex/' . $ruleId);
     }
 
     /**
-     * Delete a bounce regex rule by its hash.
+     * Delete a bounce regex rule by its id.
      *
-     * DELETE /api/v2/bounces/regex/{regexHash}
+     * DELETE /api/v2/bounces/regex/{ruleId}
      *
-     * @param string $regexHash The regex hash
+     * @param int $ruleId The regex id
      * @return array Empty response on success
      * @throws ApiException If an API error occurs
      */
-    public function deleteRegexByHash(string $regexHash): array
+    public function delete(int $ruleId): array
     {
-        return $this->client->delete('bounces/regex/' . rawurlencode($regexHash));
+        return $this->client->delete('bounces/regex/' . $ruleId);
     }
 
     /**

tests/Endpoint/BouncesClientTest.php

@@ -41,13 +41,13 @@ public function testCanUpsertGetAndDeleteRegex(): void
         $this->assertIsArray($created);
 
         // If service returns regex_hash, try fetch + delete
-        if (isset($created['regex_hash']) && is_string($created['regex_hash'])) {
-            $hash = $created['regex_hash'];
-            $fetched = $this->bouncesClient->getRegexByHash($hash);
+        if (isset($created['id']) && is_int($created['id'])) {
+            $ruleId = $created['id'];
+            $fetched = $this->bouncesClient->getOne($ruleId);
             $this->assertIsArray($fetched);
 
             // Delete may return empty array (204)
-            $deleted = $this->bouncesClient->deleteRegexByHash($hash);
+            $deleted = $this->bouncesClient->delete($ruleId);
             $this->assertIsArray($deleted);
         }