Fix Advanced Module offset reset on parameter refresh#126
Open
havokentity wants to merge 1 commit into
Open
Conversation
The serialized m_advancedModuleOffset was only applied via the
AdvancedModulePosition setter. Three other call sites passed
Vector2.zero, so any internal event (state toggles, focus changes,
parameter refreshes) would wipe the configured X/Y offset and snap
the Advanced Module back to the corner origin.
- Add public AdvancedModuleOffset getter on GraphyManager.
- Replace Vector2.zero with the serialized offset in:
* GraphyManager.SetModulePosition(ModuleType.ADVANCED, ...)
* G_AdvancedData.UpdateParameters()
* G_AdvancedData.RefreshParameters()
havokentity
force-pushed
the
fix/advanced-module-offset
branch
from
aaddeba to
90f2e76
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
m_advancedModuleOffsetwas only applied via theAdvancedModulePositionsetter. Three other call sites passedVector2.zero, wiping the configured X/Y offset on state toggles, focus changes, and parameter refreshes — so the Advanced Module would appear at the correct position on boot but snap back to the corner origin on any internal event.AdvancedModuleOffsetgetter onGraphyManager(the field was private with no accessor) and replaced the three hardcodedVector2.zeroarguments with the serialized offset.Changes
Runtime/GraphyManager.cs— addAdvancedModuleOffsetgetter; fixSetModulePosition(ModuleType.ADVANCED, …).Runtime/Advanced/G_AdvancedData.cs— fixUpdateParameters()andRefreshParameters().Test plan
m_advancedModuleOffsetto a non-zero value in the inspector.SetModuleModefrom a script — position retained.m_graphModuleOffset) continue to behave correctly — their code path was not touched.