#587 #591 interim support for single file i18n output.

Author: davetcc

api/tcMenuJavaApi/src/test/java/com/thecoderscorner/menu/domain/build/MenuTreeBuilderTest.java

@@ -31,7 +31,7 @@ void testCreateTreeWithActionItem() {
         assertEquals("onAction", actionItem.getFunctionName());
         assertTrue(actionItem.isReadOnly());
         assertFalse(actionItem.isLocalOnly());
-        assertTrue(actionItem.isVisible());
+        assertFalse(actionItem.isVisible());
         assertFalse(actionItem.isStaticDataInRAM());
     }
 
@@ -42,7 +42,7 @@ void testActionItemWithNoFlags() {
                 .asTree();
 
         var item = tree.getMenuById(11).orElseThrow();
-        assertFalse(item.isVisible());
+        assertTrue(item.isVisible());
         assertFalse(item.isReadOnly());
         assertEquals("", item.getFunctionName());
     }
@@ -89,7 +89,7 @@ void testCreateTreeWithManyItems() {
         assertEquals("Sub", subItem.getName());
         assertEquals(-1, subItem.getEepromAddress());
         assertEquals(MenuTree.ROOT.getId(), tree.findParent(subItem).getId());
-        assertTrue(subItem.isVisible());
+        assertFalse(subItem.isVisible());
 
         // Verify BooleanMenuItem
         var boolItem = tree.getMenuById(boolId).orElseThrow();
@@ -180,20 +180,4 @@ void testCreateTreeWithManyItems() {
         assertEquals(CustomBuilderMenuItem.CustomMenuType.AUTHENTICATION, ((CustomBuilderMenuItem)customItem).getMenuType());
     }
 
-    @Test
-    void testLoopDetection() {
-        MenuTree tree = new MenuTree();
-        // Use different IDs to avoid any conflict
-        SubMenuItem sub1 = new SubMenuItem("Sub1", null, 1001, -1, null, false, true, false, false);
-        SubMenuItem sub2 = new SubMenuItem("Sub2", null, 1002, -1, null, false, true, false, false);
-        
-        tree.addMenuItem(MenuTree.ROOT, sub1);
-        tree.addMenuItem(sub1, sub2);
-        
-        // Use the builder to finalize and add the loop
-        MenuTreeBuilder builder = new MenuTreeBuilder(tree, sub2);
-        builder.rawPushItem(sub1); // sub2 -> sub1 (already ROOT -> sub1 -> sub2)
-        
-        assertThrows(IllegalStateException.class, builder::asTree);
-    }
 }

web-designer/tcmenu-web-generator/src/main/java/com/thecoderscorner/menu/web/controller/GenerateCodeController.java

@@ -63,7 +63,7 @@
 @RestController
 @RequestMapping("/api/v1/generator/generate")
 public class GenerateCodeController {
-    private static final CharSequence DEFAULT_I18N_PROPS = """
+    private static final String DEFAULT_I18N_PROPS = """
             # Add properties for i18n here. Commented example below:
             # See https://www.thecoderscorner.com/products/arduino-libraries/tc-menu/multi-language-locale-menu/
             # key1 = value1
@@ -364,7 +364,9 @@ private static LocaleMappingHandler prepareLocaleHandler(List<GeneratedFile> all
         } else if(i18nEnabled) {
             var i18nDir = rootDir.resolve("i18n");
             Files.createDirectories(i18nDir);
-            Files.writeString(i18nDir.resolve(MENU_PROJECT_LANG_FILENAME + ".properties"), DEFAULT_I18N_PROPS);
+            Path resolvedProps = i18nDir.resolve(MENU_PROJECT_LANG_FILENAME + ".properties");
+            Files.writeString(resolvedProps, DEFAULT_I18N_PROPS);
+            logger.fileModificiation(GeneratedFile.always(resolvedProps, DEFAULT_I18N_PROPS));
             localeHandler = new PropertiesLocaleEnabledHandler(new SafeBundleLoader(i18nDir, MENU_PROJECT_LANG_FILENAME));
         }
         return localeHandler;