Rehabilitate CI, upgrade to syn@2#542
Closed
tamird wants to merge 4 commits into
Closed
Conversation
``` TRYBUILD=overwrite cargo test ```
Author
|
@TeXitoi I think you might need to enable github actions from the repo settings. |
tamird
force-pushed
the
syn2
branch
9 times, most recently
from
a27d75e to
50c3b09
Compare
Remove feature clap/lints; no longer supported:
```
error[E0557]: feature has been removed
-->
/Users/tamird/.cargo/registry/src/index.crates.io-6f17d22bba15001f/clap-2.33.4/src/lib.rs:536:40
|
536 | #![cfg_attr(feature = "lints", feature(plugin))]
| ^^^^^^ feature has been
removed
|
= note: plugins are no longer supported
```
Bump MSRV as forced by dependencies.
Owner
|
Sorry for not responding in so much time. I think syn upgrade, while meaningful, is too risky in term of back compatibility. If you want to avoid depending on syn v1, better to upgrade to clap_derive. Also, this paw thing might be a breaking change. The github action is quite nice, but regarding the number of MR I have, I think that’s not really critical. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See individual commits. Extracted from #536 minus the regression.