Add hosted-provider smoke env gate and acceptance test

Author: johnteee

docs/acceptance.md

@@ -14,7 +14,8 @@ TeaAgent acceptance tests live under `tests/acceptance/` and verify user-facing
 - Long-running worker flow: background worker start, list, show, log tail, and stop lifecycle.
 - Workspace edit flow: hash-anchored read/edit, git status, test command execution, git diff inspection, and final diff summary.
 - Live provider conformance flow: provider checks are skipped unless an explicit environment gate is set, preventing accidental live API calls in CI.
+- Hosted-provider smoke flow: `model smoke --live-env-var` skips live adapter calls unless CI explicitly sets the gate to `1`.
 
 ## Next User Stories
 
-- Expand acceptance coverage for external hosted-provider runs when CI secrets are intentionally provisioned.
+- Define the next product-facing acceptance story beyond safe provider gates, such as release packaging smoke or IDE command flow.

teaagent/cli/_handlers/_model.py

@@ -2,6 +2,7 @@
 
 import argparse
 import json
+import os
 from typing import Any
 
 from teaagent.llm import LLMMessage, LLMRequest, available_providers
@@ -14,6 +15,16 @@ def model_providers(_args: argparse.Namespace) -> int:
 
 
 def model_smoke(args: argparse.Namespace) -> int:
+    live_env_var = getattr(args, 'live_env_var', None)
+    if live_env_var is not None and os.environ.get(live_env_var) != '1':
+        print_json(
+            {
+                'provider': args.provider,
+                'skipped': True,
+                'reason': f'gated by env {live_env_var}=1',
+            }
+        )
+        return 0
     adapter = args._adapter_factory(args.provider, model=args.model)  # type: ignore[attr-defined]
     response = adapter.complete(
         LLMRequest(

teaagent/cli/_model_parsers.py

@@ -27,6 +27,11 @@ def register(
     smoke.add_argument(
         '--max-tokens', type=int, default=32, help='Maximum output tokens.'
     )
+    smoke.add_argument(
+        '--live-env-var',
+        default=None,
+        help='Skip smoke call unless this environment variable is set to 1.',
+    )
     smoke.set_defaults(func=handlers['smoke'])
 
     conformance = subs.add_parser(

tests/acceptance/test_model_smoke_gating_flow.py

@@ -0,0 +1,66 @@
+from __future__ import annotations
+
+import io
+import json
+import os
+import unittest
+from contextlib import redirect_stdout
+from unittest.mock import patch
+
+from conftest import FakeAdapter
+
+from teaagent.cli import main
+
+
+class ModelSmokeGatingFlowAcceptanceTests(unittest.TestCase):
+    def test_smoke_skips_without_required_env_and_does_not_call_provider(self) -> None:
+        def fail_factory(provider: str, model: str | None = None) -> object:
+            raise AssertionError(f'provider should not be called: {provider}')
+
+        output = io.StringIO()
+        with redirect_stdout(output):
+            exit_code = main(
+                [
+                    'model',
+                    'smoke',
+                    'gpt',
+                    '--live-env-var',
+                    'TEAAGENT_ACCEPT_HOSTED_SMOKE',
+                ],
+                _adapter_factory=fail_factory,
+            )
+        payload = json.loads(output.getvalue())
+
+        self.assertEqual(exit_code, 0)
+        self.assertTrue(payload['skipped'])
+        self.assertEqual(payload['provider'], 'gpt')
+        self.assertIn('TEAAGENT_ACCEPT_HOSTED_SMOKE', payload['reason'])
+
+    def test_smoke_runs_when_required_env_is_set(self) -> None:
+        adapter = FakeAdapter(['ok'])
+        output = io.StringIO()
+        with (
+            patch.dict(os.environ, {'TEAAGENT_ACCEPT_HOSTED_SMOKE': '1'}),
+            redirect_stdout(output),
+        ):
+            exit_code = main(
+                [
+                    'model',
+                    'smoke',
+                    'gpt',
+                    '--live-env-var',
+                    'TEAAGENT_ACCEPT_HOSTED_SMOKE',
+                ],
+                _adapter_factory=lambda _provider, model=None: adapter,
+            )
+        payload = json.loads(output.getvalue())
+
+        self.assertEqual(exit_code, 0)
+        self.assertEqual(payload['provider'], 'fake')
+        self.assertEqual(payload['model'], 'fake-model')
+        self.assertEqual(payload['content'], 'ok')
+        self.assertNotIn('skipped', payload)
+
+
+if __name__ == '__main__':
+    unittest.main()