fix(test): correct TUI patch target, apply ruff format across 81 files

- Fix patch target 'teaagent.tui.__init__.explain_skill_activation'
  -> 'teaagent.tui.explain_skill_activation' (__init__ resolves to
  module method-wrapper, not the package, causing AttributeError)
- Same fix for discover_skill_index patch target
- Run ruff format across the 81 files that had formatting drift
  (pre-existing from daily-driver patch; blocking CI format check)

Constraint: targeted fix, single test
Tested: 4/4 TuiSkillPanelTests pass, ruff format --check clean
Confidence: high

Author: johnteee

scripts/detect_stale_plans.py

@@ -18,36 +18,24 @@
 from pathlib import Path
 
 _REPO_ROOT = Path(__file__).resolve().parents[1]
-_PLANS_DIR = _REPO_ROOT / "docs" / "plans"
+_PLANS_DIR = _REPO_ROOT / 'docs' / 'plans'
 
 # Patterns for date markers
 _DATE_LAST_UPDATED = re.compile(
-    r"Last (?:updated|reviewed):\s*(\d{4}-\d{2}-\d{2})", re.IGNORECASE
-)
-_DATE_AS_OF = re.compile(
-    r"#\s+(?:As of|)\s*(\d{4}-\d{2}-\d{2})", re.IGNORECASE
-)
-_DATE_TITLE = re.compile(
-    r"^#\s+.*?(\d{4}-\d{2}-\d{2})", re.IGNORECASE
+    r'Last (?:updated|reviewed):\s*(\d{4}-\d{2}-\d{2})', re.IGNORECASE
 )
+_DATE_AS_OF = re.compile(r'#\s+(?:As of|)\s*(\d{4}-\d{2}-\d{2})', re.IGNORECASE)
+_DATE_TITLE = re.compile(r'^#\s+.*?(\d{4}-\d{2}-\d{2})', re.IGNORECASE)
 _DATE_FRONTMATTER = re.compile(
-    r"last_(?:audit|reviewed|updated):\s*(\d{4}-\d{2}-\d{2})", re.IGNORECASE
-)
-_DATE_INLINE = re.compile(
-    r"^Date:\s*(\d{4}-\d{2}-\d{2})", re.IGNORECASE | re.MULTILINE
-)
-_DATE_IN_FILENAME = re.compile(
-    r"(\d{4}-\d{2}-\d{2})\.md$"
+    r'last_(?:audit|reviewed|updated):\s*(\d{4}-\d{2}-\d{2})', re.IGNORECASE
 )
+_DATE_INLINE = re.compile(r'^Date:\s*(\d{4}-\d{2}-\d{2})', re.IGNORECASE | re.MULTILINE)
+_DATE_IN_FILENAME = re.compile(r'(\d{4}-\d{2}-\d{2})\.md$')
 _SUPERSESSION_NOTE = re.compile(
-    r"Supersession note[,:]?\s*(\d{4}-\d{2}-\d{2})", re.IGNORECASE
-)
-_SUPERSEDED_KEYWORD = re.compile(
-    r"\b[sS]upersed(?:ed|es)\b"
-)
-_HISTORICAL_KEYWORD = re.compile(
-    r"\bhistorical(?: evidence|)\b", re.IGNORECASE
+    r'Supersession note[,:]?\s*(\d{4}-\d{2}-\d{2})', re.IGNORECASE
 )
+_SUPERSEDED_KEYWORD = re.compile(r'\b[sS]upersed(?:ed|es)\b')
+_HISTORICAL_KEYWORD = re.compile(r'\bhistorical(?: evidence|)\b', re.IGNORECASE)
 
 STALE_DAYS = 90
 
@@ -56,10 +44,17 @@ def _extract_date(text: str) -> datetime | None:
     """Extract the most recent date from text using known patterns."""
     dates: list[datetime] = []
 
-    for pattern in (_DATE_LAST_UPDATED, _DATE_AS_OF, _DATE_TITLE, _DATE_FRONTMATTER, _DATE_INLINE, _SUPERSESSION_NOTE):
+    for pattern in (
+        _DATE_LAST_UPDATED,
+        _DATE_AS_OF,
+        _DATE_TITLE,
+        _DATE_FRONTMATTER,
+        _DATE_INLINE,
+        _SUPERSESSION_NOTE,
+    ):
         for match in pattern.finditer(text):
             try:
-                dt = datetime.strptime(match.group(1), "%Y-%m-%d").replace(
+                dt = datetime.strptime(match.group(1), '%Y-%m-%d').replace(
                     tzinfo=timezone.utc
                 )
                 dates.append(dt)
@@ -87,18 +82,18 @@ def scan_plans(
     now = datetime.now(timezone.utc)
     cutoff = now - timedelta(days=stale_days)
 
-    md_files = sorted(plans_dir.rglob("*.md"))
+    md_files = sorted(plans_dir.rglob('*.md'))
 
     for path in md_files:
         rel = path.relative_to(_REPO_ROOT)
         try:
-            text = path.read_text(encoding="utf-8")
+            text = path.read_text(encoding='utf-8')
         except Exception:
-            issues.append(f"{rel}: cannot read file")
+            issues.append(f'{rel}: cannot read file')
             continue
 
         # Skip ticket-plans directory (task execution ledgers, not strategic plans)
-        if "ticket-plans" in str(path):
+        if 'ticket-plans' in str(path):
             continue
 
         date = _extract_date(text)
@@ -107,7 +102,7 @@ def scan_plans(
             fn_match = _DATE_IN_FILENAME.search(path.name)
             if fn_match:
                 with suppress(ValueError):
-                    date = datetime.strptime(fn_match.group(1), "%Y-%m-%d").replace(
+                    date = datetime.strptime(fn_match.group(1), '%Y-%m-%d').replace(
                         tzinfo=timezone.utc
                     )
         has_supersession = _has_supersession_note(text)
@@ -116,9 +111,9 @@ def scan_plans(
         if date is None and not has_supersession and not is_historical:
             # Undated file
             issues.append(
-                f"{rel}: no date marker found (Last updated/reviewed, "
-                f"supersession note, or historical label). Add a date or "
-                f"mark as superseded."
+                f'{rel}: no date marker found (Last updated/reviewed, '
+                f'supersession note, or historical label). Add a date or '
+                f'mark as superseded.'
             )
         elif date is not None and date < cutoff:
             # Stale file
@@ -130,44 +125,42 @@ def scan_plans(
                 pass
             else:
                 issues.append(
-                    f"{rel}: last updated {date.strftime('%Y-%m-%d')} "
-                    f"({(now - date).days} days ago, threshold {stale_days}d). "
-                    f"Add a supersession note or update the document."
+                    f'{rel}: last updated {date.strftime("%Y-%m-%d")} '
+                    f'({(now - date).days} days ago, threshold {stale_days}d). '
+                    f'Add a supersession note or update the document.'
                 )
 
         if check_review_dates and date and date < (now - timedelta(days=180)):
             issues.append(
-                f"{rel}: review date {date.strftime('%Y-%m-%d')} is "
-                f"older than 180 days. Refresh or add supersession note."
+                f'{rel}: review date {date.strftime("%Y-%m-%d")} is '
+                f'older than 180 days. Refresh or add supersession note.'
             )
 
     return issues
 
 
 def main() -> int:
-    parser = argparse.ArgumentParser(
-        description="Detect stale plans in docs/plans/"
-    )
+    parser = argparse.ArgumentParser(description='Detect stale plans in docs/plans/')
     parser.add_argument(
-        "--plans-dir",
+        '--plans-dir',
         default=str(_PLANS_DIR),
-        help="Directory to scan for plan files",
+        help='Directory to scan for plan files',
     )
     parser.add_argument(
-        "--stale-days",
+        '--stale-days',
         type=int,
         default=STALE_DAYS,
-        help=f"Days after which a plan is considered stale (default: {STALE_DAYS})",
+        help=f'Days after which a plan is considered stale (default: {STALE_DAYS})',
     )
     parser.add_argument(
-        "--check-review-dates",
-        action="store_true",
-        help="Also flag files with review dates older than 180 days",
+        '--check-review-dates',
+        action='store_true',
+        help='Also flag files with review dates older than 180 days',
     )
     parser.add_argument(
-        "--verbose",
-        action="store_true",
-        help="Show informational messages for superseded-but-stale files",
+        '--verbose',
+        action='store_true',
+        help='Show informational messages for superseded-but-stale files',
     )
 
     args = parser.parse_args()
@@ -179,15 +172,15 @@ def main() -> int:
     )
 
     if not issues:
-        print("No stale plans detected.")
+        print('No stale plans detected.')
         return 0
 
     for issue in issues:
-        print(f"STALE: {issue}")
+        print(f'STALE: {issue}')
 
-    print(f"\n{len(issues)} stale plan(s) detected.")
+    print(f'\n{len(issues)} stale plan(s) detected.')
     return 1
 
 
-if __name__ == "__main__":
+if __name__ == '__main__':
     raise SystemExit(main())