fix: TASK-005 review F-C/F-D — redact webhook URL in doctor config; tolerate malformed numeric env

Closes the two remaining documented residuals from the doctor-config review.

F-C: automation_webhook_url's value is now redacted in the `doctor config` view
(a webhook URL can embed a token in its path/query). Scoped to this command via
a local credential-endpoint set — the global redaction policy is unchanged — and
the source/provenance is still shown.

F-D: a malformed numeric env var (e.g. TEAAGENT_DAILY_COST_CAP_CENTS=abc) is now
ignored in resolve_config_provenance instead of raising. The override falls back
to the prior layer (default/config) rather than crashing every command, and the
retained source makes the no-op visible in `doctor config`. Because
load_workspace_defaults is derived from the resolver, it is hardened too (the old
code crashed here).

- teaagent/ergonomics/workspace_defaults.py: try/except around numeric coercion.
- teaagent/cli/_handlers/_doctor.py: redact automation_webhook_url value.
- Tests: malformed-env fallback (resolver + load_workspace_defaults); webhook-URL
  value redacted with source preserved.
- Spec: all review findings marked resolved.

Constraint: F-C redaction is command-scoped (no global policy change); F-D changes malformed-input handling from crash to graceful fallback (no change to valid-input behavior); load_workspace_defaults valid-value output unchanged.
Tested: tests/test_workspace_defaults_toml.py 25 passed (incl. new F-C/F-D tests); mypy clean.
Not-tested: full suite not run on 3.12 (hypothesis missing in 3.14 sandbox).
Confidence: high
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Author: johnteee

docs/generated/docs-inventory.md

@@ -562,7 +562,7 @@ Do not edit this file manually — regenerate instead.
 | `strategy/agent-ecosystem-core-values-2026-06-05.md` | archive | 12861 | `23194f9dc611` |
 | `strategy/competitive-analysis-and-positioning-2026-06-06.md` | archive | 67553 | `7c78b145750a` |
 | `strategy/daily-driver-roadmap-rationale-2026-06-04.md` | archive | 5053 | `3b6cdeed6d2e` |
-| `strategy/harness-first-direction-2026-06-13.md` | constitution | 20826 | `b4a9469900b8` |
+| `strategy/harness-first-direction-2026-06-13.md` | constitution | 21044 | `b04cf7200ba3` |
 | `strategy/implementation-roadmap-with-effort-impact-2026-06-06.md` | archive | 58270 | `fb0af11ee7a6` |
 | `strategy/malleable-governed-agent-harness-2026-06-03.md` | archive | 15446 | `eccbc0177490` |
 | `strategy/phase-0-to-phase-1-outlook-2026-06-04.md` | archive | 5314 | `374a502902b6` |

docs/strategy/harness-first-direction-2026-06-13.md

@@ -320,11 +320,14 @@ spine-wide.
 - **Review fix (F-A):** provenance distinguishes the shell environment
   (`env:VAR`) from the workspace env file (`env-file:.teaagent/env`); a var set
   in both is attributed to the shell, which wins. (Initially both were
-  mislabeled `env:` — defeating the point for env-file values.) Residuals,
-  documented not fixed: `automation_webhook_url` is not redacted (could embed a
-  token; consistent with existing redaction policy); a malformed numeric env var
-  raises in both `resolve_config_provenance` and `load_workspace_defaults`
-  (pre-existing, unchanged behavior).
+  mislabeled `env:` — defeating the point for env-file values.)
+- **Review fixes (F-C, F-D):** `automation_webhook_url` value is now redacted in
+  the `doctor config` view (it can embed a token), scoped to that command so the
+  global redaction policy is unchanged; its source is still shown. A malformed
+  numeric env var (e.g. `TEAAGENT_DAILY_COST_CAP_CENTS=abc`) is now ignored —
+  the override falls back to the prior layer instead of crashing every command,
+  and the retained `default`/`config` source makes the no-op visible. All review
+  findings resolved.
 
 ### TASK-006: RunEvent taxonomy ADR + M0 dual-write spike
 - Goal: ADR for event schema; spine emitting alongside audit on the proof scenario.

teaagent/cli/_handlers/_doctor.py

@@ -382,6 +382,12 @@ def doctor_config(args: argparse.Namespace) -> int:
     root = Path(getattr(args, 'root', '.')).resolve()
     prov = resolve_config_provenance(root)
 
+    # Credential-bearing endpoints whose VALUE is redacted in this view even
+    # though the key name is not a generic secret marker (a webhook URL can
+    # embed a token in its path/query). Scoped to this command — not a change to
+    # the global redaction policy. Source/provenance is still shown.
+    _credential_endpoint_keys = {'automation_webhook_url'}
+
     # A list of entries (not a dict keyed by config key): the doctor JSON sink
     # redacts dict VALUES whose KEY is sensitive, which would collapse a
     # secret-keyed entry to a string and lose its provenance. Keying on neutral
@@ -390,7 +396,8 @@ def doctor_config(args: argparse.Namespace) -> int:
     for key in sorted(prov):
         entry = prov[key]
         value = entry['value']
-        if _is_sensitive_key(key) and value not in (None, ''):
+        redact = _is_sensitive_key(key) or key in _credential_endpoint_keys
+        if redact and value not in (None, ''):
             value = _REDACTED
         config.append({'key': key, 'value': value, 'source': entry['source']})
 

teaagent/ergonomics/workspace_defaults.py

@@ -200,8 +200,17 @@ def _env_source(env_name: str) -> str:
 
     for key, (env_name, coerce) in _ENV_ONLY.items():
         raw = os.environ.get(env_name)
-        if raw:
-            prov[key] = {'value': coerce(raw), 'source': _env_source(env_name)}
+        if not raw:
+            continue
+        try:
+            value = coerce(raw)
+        except (ValueError, TypeError):
+            # Malformed env value (e.g. TEAAGENT_DAILY_COST_CAP_CENTS=abc):
+            # ignore the override and fall back to the prior layer rather than
+            # crashing every command. The retained source (default/config) makes
+            # it visible in `doctor config` that the env var did not take effect.
+            continue
+        prov[key] = {'value': value, 'source': _env_source(env_name)}
 
     return prov
 

tests/test_workspace_defaults_toml.py

@@ -302,6 +302,50 @@ def test_resolve_config_provenance_distinguishes_env_file_from_shell(
     }
 
 
+def test_resolve_config_provenance_ignores_malformed_numeric_env(
+    tmp_path: Path, monkeypatch: pytest.MonkeyPatch
+) -> None:
+    """A malformed numeric env var is ignored (falls back), not a crash (F-D)."""
+    from teaagent.ergonomics.workspace_defaults import (
+        load_workspace_defaults,
+        resolve_config_provenance,
+    )
+
+    monkeypatch.setenv('TEAAGENT_DAILY_COST_CAP_CENTS', 'not-a-number')
+
+    prov = resolve_config_provenance(tmp_path)
+    assert prov['daily_cost_cap_cents']['value'] == 0  # default, override ignored
+    assert prov['daily_cost_cap_cents']['source'] == 'default'
+    # load_workspace_defaults (derived) must also not crash.
+    assert load_workspace_defaults(tmp_path)['daily_cost_cap_cents'] == 0
+
+
+def test_doctor_config_redacts_webhook_url(
+    tmp_path: Path, monkeypatch: pytest.MonkeyPatch, capsys: pytest.CaptureFixture[str]
+) -> None:
+    """The webhook URL value is redacted (may embed a token) but its source is
+    still shown (F-C)."""
+    import argparse
+    import json
+
+    from teaagent.cli._handlers._doctor import doctor_config
+
+    monkeypatch.setenv(
+        'TEAAGENT_AUTOMATION_WEBHOOK_URL', 'https://example.com/hook?token=abc123secret'
+    )
+    rc = doctor_config(argparse.Namespace(root=str(tmp_path)))
+    assert rc == 0
+
+    cfg = {e['key']: e for e in json.loads(capsys.readouterr().out)['config']}
+    assert 'abc123secret' not in json.dumps(cfg)
+    assert cfg['automation_webhook_url']['value'] != (
+        'https://example.com/hook?token=abc123secret'
+    )
+    assert cfg['automation_webhook_url']['source'] == (
+        'env:TEAAGENT_AUTOMATION_WEBHOOK_URL'
+    )
+
+
 def test_load_workspace_defaults_matches_provenance_values(
     tmp_path: Path, monkeypatch: pytest.MonkeyPatch
 ) -> None: