Potential fix for code scanning alert no. 5: Clear-text logging of sensitive information#10
Merged
Conversation
…nsitive information Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
johnteee
added a commit
that referenced
this pull request
May 29, 2026
…gate. Load peer_relay_urls and local_relay_base_url from .teaagent/config.json, add WAN deployment guide and config template, and record Dependabot #10 resolution steps with full pre-commit verification notes. Constraint: Dependabot dismiss requires GitHub UI or authenticated gh API. Tested: TEAAGENT_PRECOMMIT_FULL=1 pre-commit (all hooks passed); uv run pytest -q (2641 passed). Confidence: high Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/TeaEntityLab/teaAgent/security/code-scanning/5
To fix this safely without changing functionality, avoid printing dynamic error text from sensitive OAuth key-ring handling directly. Instead, print a fixed, non-sensitive user-facing message at the call site and (optionally) keep the detailed text only for internal handling. In this snippet, the best minimal change is in
mcp_serve_commandaround lines 26–28: replaceprint(error, file=sys.stderr)with a constant message such as"Invalid OAuth key ring configuration.".This preserves control flow and exit behavior (
return 1) while ensuring no potentially sensitive content is emitted to logs/stderr, even if_load_key_ringis later modified to include sensitive context.Suggested fixes powered by Copilot Autofix. Review carefully before merging.