Round 89: freeze 00-core Human Review required/exempt sets

johnteee · johnteee · commit 6dd08dbc5d1f · 2026-06-25T16:48:50.000+08:00
Codify CORE_HUMAN_REVIEW_REQUIRED and CORE_HUMAN_REVIEW_EXEMPT in
test_core_prompts_eval_harness.py with partition and detection parity
tests. Add GLOSSARY playbook step 21 and sync panel/governance docs
through Round 89 (options FT–FW).
diff --git a/README.md b/README.md
@@ -21,7 +21,7 @@ Full library docs: [reflective-prompt-library/README.md](reflective-prompt-libra
 ## Governance
 
 - **Contributing:** [CONTRIBUTING.md](CONTRIBUTING.md) — quality gates, routing maintenance (R8–R12), `make all`
-- **Panel record:** [multi-agent-panel-consensus](reflective-prompt-library/plans/multi-agent-panel-consensus-2026-06-25.md) — six-lens Socratic consensus (Rounds 1–88)
+- **Panel record:** [multi-agent-panel-consensus](reflective-prompt-library/plans/multi-agent-panel-consensus-2026-06-25.md) — six-lens Socratic consensus (Rounds 1–89)
 - **Operator playbook:** [GLOSSARY.md](reflective-prompt-library/GLOSSARY.md) — Governance Maintenance Playbook
 
 The repository contains:
diff --git a/reflective-prompt-library/GLOSSARY.md b/reflective-prompt-library/GLOSSARY.md
@@ -337,7 +337,7 @@ Curated top-of-cheatsheet summary of high-confusion routing traps (ROUTE-002 hol
 
 ## Governance Maintenance Playbook / 治理維護手冊
 
-Ongoing upkeep after panel close (Rounds 1–88). Not agent instructions — operator checklist.
+Ongoing upkeep after panel close (Rounds 1–89). Not agent instructions — operator checklist.
 
 **Operational test:** Before router tuning, add fresh ROUTE-002/003 holdout phrases; run `make all`; record decisions in `PROJECT_KNOWLEDGE.md` Decision Index when governance surface changes.
 
@@ -361,3 +361,4 @@ Ongoing upkeep after panel close (Rounds 1–88). Not agent instructions — ope
 18. When adding or editing composable prompts (`02-engineering`–`06-repo`) with `## Human Review`, keep preamble escalation routed to `reflective-risk` and run Human Review guards in `test_*_prompts_eval_harness.py` (exact heading match via `prompt_eval_helpers.py`).
 19. When editing Human Review guards, use `prompt_eval_helpers.assert_human_review_preamble` in all `test_*_prompts_eval_harness.py` files (thinking lenses + composable categories).
 20. When adding or editing risk-bearing `00-core/` prompts with `## Human Review`, keep preamble escalation routed to `reflective-risk` and run `test_core_prompts_eval_harness.py` Human Review guards via `prompt_eval_helpers.py`.
+21. When editing `00-core/` Human Review coverage, keep `CORE_HUMAN_REVIEW_REQUIRED` and `CORE_HUMAN_REVIEW_EXEMPT` in `test_core_prompts_eval_harness.py` aligned with preamble `## Human Review` sections; run core HR parity tests.
diff --git a/reflective-prompt-library/PROJECT_KNOWLEDGE.md b/reflective-prompt-library/PROJECT_KNOWLEDGE.md
@@ -73,6 +73,7 @@ deferred promotions are recurrence-gated — see [panel backlog](plans/multi-age
 ## Decision Index
 
 - 2026-06-25 Round 85 panel — composable prompt Primary workflow surface preamble guards (`test_*_prompts_eval_harness.py`) + Supporting-lens exemption → [record](plans/multi-agent-panel-consensus-2026-06-25.md)
+- 2026-06-25 Round 89 panel — `00-core` Human Review required/exempt set parity (`CORE_HUMAN_REVIEW_REQUIRED` / `CORE_HUMAN_REVIEW_EXEMPT`) → [record](plans/multi-agent-panel-consensus-2026-06-25.md)
 - 2026-06-25 Round 88 panel — `00-core` Human Review preamble guards on risk-bearing prompts + `test_core_prompts_eval_harness.py` → [record](plans/multi-agent-panel-consensus-2026-06-25.md)
 - 2026-06-25 Round 87 panel — Human Review helper DRY + GLOSSARY playbook step repair → [record](plans/multi-agent-panel-consensus-2026-06-25.md)
 - 2026-06-25 Round 86 panel — composable Human Review preamble guards + `reflective-risk` routing alignment → [record](plans/multi-agent-panel-consensus-2026-06-25.md)
diff --git a/reflective-prompt-library/README.md b/reflective-prompt-library/README.md
@@ -30,7 +30,7 @@ Pick **Strictness L1–L6** first (`skills/reflective-dispatch/SKILL.md`, [GLOSS
 
 ## Governance Panel Record
 
-Multi-agent Socratic consensus on project goals and the nine skills (Rounds 1–88, options A–FS) is recorded in [plans/multi-agent-panel-consensus-2026-06-25.md](plans/multi-agent-panel-consensus-2026-06-25.md). Run `make all` before claiming routing or governance changes are verified.
+Multi-agent Socratic consensus on project goals and the nine skills (Rounds 1–89, options A–FW) is recorded in [plans/multi-agent-panel-consensus-2026-06-25.md](plans/multi-agent-panel-consensus-2026-06-25.md). Run `make all` before claiming routing or governance changes are verified.
 
 ## Directory Map
 
diff --git a/reflective-prompt-library/plans/QUALITY_GATES_SUMMARY.md b/reflective-prompt-library/plans/QUALITY_GATES_SUMMARY.md
@@ -384,4 +384,4 @@ Phase 1 quality-gate tooling and documentation are **complete**. Routing consist
 - ✅ Benchmark fixture gate plus optional manual benchmark runs
 - ✅ Research-backed design decisions
 
-The project is positioned to grow sustainably with quality discipline built in from the start. **No open implementation blockers** remain from panel Rounds 1–88; work is recurrence-gated maintenance per playbook. The next measurable quality target is **holdout expansion before router tuning** and optional manual baseline-vs-skill benchmark runs — not shipping new core skills without promotion evidence.
+The project is positioned to grow sustainably with quality discipline built in from the start. **No open implementation blockers** remain from panel Rounds 1–89; work is recurrence-gated maintenance per playbook. The next measurable quality target is **holdout expansion before router tuning** and optional manual baseline-vs-skill benchmark runs — not shipping new core skills without promotion evidence.
diff --git a/reflective-prompt-library/plans/multi-agent-panel-consensus-2026-06-25.md b/reflective-prompt-library/plans/multi-agent-panel-consensus-2026-06-25.md
@@ -2498,3 +2498,44 @@ User directive (repeat): review prompts, plans, skills, and Socratic/critical-th
 
 **Resealed 2026-06-25** after **Round 88** (options FP–FS). Full prompt library now has Human Review preamble guards on thinking lenses (R81), composable prompts (R86), and risk-bearing `00-core` prompts (R88). Holdout expansion remains recurrence-gated maintenance.
 
+---
+
+## Round 89 — `00-core` Human Review required/exempt set parity (2026-06-25)
+
+**Options FT–FW** | Six-lens panel (Opus, Codex, Gemini, Composer, Sakana, GLM)
+
+### Round 89 options
+
+| ID | Proposal | Verdict |
+| --- | --- | --- |
+| FT | Frozen `CORE_HUMAN_REVIEW_REQUIRED` / `CORE_HUMAN_REVIEW_EXEMPT` sets + pytest parity in `test_core_prompts_eval_harness.py` | **Agree** |
+| FU | GLOSSARY playbook step 21 + governance sync | **Agree** |
+| FV | ROUTE holdout expansion | **Defer** |
+| FW | Router / tenth skill / benchmark CI | **Reject** |
+
+### Round 89 verdict table
+
+| ID | Option | Verdict | Action |
+| --- | --- | --- | --- |
+| FT | Core HR set parity | **Agree** | codify 6 required + 3 exempt opener prompts |
+| FU | Playbook + docs | **Agree** | step 21; panel round 89 sync |
+| FV | Holdout expansion | **Defer** | maintenance |
+| FW | Router/tenth skill/benchmark CI | **Reject** | no change |
+
+**All roles agree.**
+
+## Implemented Changes (Round 89)
+
+- `plans/tests/test_core_prompts_eval_harness.py`: `CORE_HUMAN_REVIEW_REQUIRED`, `CORE_HUMAN_REVIEW_EXEMPT`, partition + detection parity tests
+- `GLOSSARY.md`: playbook Rounds 1–89; step 21 for core HR required/exempt sets
+- `QUALITY_GATES_SUMMARY.md`: core HR set parity note; panel Rounds 1–89; 560+ pytest floor
+- `PROJECT_KNOWLEDGE.md`: Decision Index Round 89 entry
+- `README.md`, `reflective-prompt-library/README.md`, `test_readme_governance.py`: panel round 89 sync
+
+## Verification (Round 89)
+
+- `make all`: pytest + ROUTE-001/002/003 100%
+
+## Panel status (updated)
+
+**Resealed 2026-06-25** after **Round 89** (options FT–FW). `00-core` Human Review coverage is now explicit via frozen required/exempt sets; full library HR contract parity closed (thinking R81, composable R86, core R88–R89). Holdout expansion remains recurrence-gated maintenance.
diff --git a/reflective-prompt-library/plans/tests/test_core_prompts_eval_harness.py b/reflective-prompt-library/plans/tests/test_core_prompts_eval_harness.py
@@ -9,7 +9,11 @@
 sys.path.insert(0, str(Path(__file__).parent))
 
 from eval_harness import EvalHarness  # noqa: E402
-from prompt_eval_helpers import assert_human_review_preamble, prompts_with_human_review  # noqa: E402
+from prompt_eval_helpers import (  # noqa: E402
+    assert_human_review_preamble,
+    has_human_review_preamble,
+    prompts_with_human_review,
+)
 
 CORE_DIR = Path(__file__).parent.parent.parent / "00-core"
 REPO_ROOT = str(Path(__file__).parent.parent.parent.parent)
@@ -23,6 +27,20 @@
 )
 
 CORE_PROMPTS = tuple(sorted(CORE_DIR.glob("*.md")))
+CORE_HUMAN_REVIEW_REQUIRED = frozenset({
+    "core-full.md",
+    "core-minimal.md",
+    "core-short.md",
+    "custom-instruction-en.md",
+    "custom-instruction-zh.md",
+    "important-task-full.md",
+})
+CORE_HUMAN_REVIEW_EXEMPT = frozenset({
+    "daily-minimal.md",
+    "global-controller.md",
+    "master-prompt.md",
+})
+
 CORE_PROMPTS_WITH_HUMAN_REVIEW = prompts_with_human_review(CORE_PROMPTS)
 
 
@@ -76,3 +94,24 @@ def test_core_prompts_have_primary_workflow_surfaces_line():
 def test_core_prompt_has_human_review_section(prompt_path: Path):
     """Risk-bearing 00-core prompts declare Human Review escalation outside zh-TW templates."""
     assert_human_review_preamble(prompt_path)
+
+
+def test_core_human_review_required_set_matches_detection():
+    """Frozen required set must match prompts that declare ## Human Review in preambles."""
+    detected = {p.name for p in CORE_PROMPTS_WITH_HUMAN_REVIEW}
+    assert detected == CORE_HUMAN_REVIEW_REQUIRED
+
+
+def test_core_human_review_exempt_prompts_have_no_preamble_section():
+    """L1 opener prompts keep Human Review cues in fenced templates only."""
+    for name in CORE_HUMAN_REVIEW_EXEMPT:
+        assert not has_human_review_preamble(CORE_DIR / name), (
+            f"{name} should not declare ## Human Review in preamble (exempt opener)"
+        )
+
+
+def test_core_human_review_sets_partition_core_prompts():
+    """Required + exempt sets must cover all 00-core prompts without overlap."""
+    all_names = {p.name for p in CORE_PROMPTS}
+    assert CORE_HUMAN_REVIEW_REQUIRED | CORE_HUMAN_REVIEW_EXEMPT == all_names
+    assert not CORE_HUMAN_REVIEW_REQUIRED & CORE_HUMAN_REVIEW_EXEMPT
diff --git a/reflective-prompt-library/plans/tests/test_glossary_structure.py b/reflective-prompt-library/plans/tests/test_glossary_structure.py
@@ -30,10 +30,10 @@ def test_round_boundary_terms_present(glossary_text: str):
         assert heading in glossary_text, f"missing glossary section: {heading}"
 
 
-def test_maintenance_playbook_references_round_88(glossary_text: str):
+def test_maintenance_playbook_references_round_89(glossary_text: str):
     playbook = glossary_text.split("## Governance Maintenance Playbook", 1)[1]
-    assert "Rounds 1–88" in playbook
-    assert "Rounds 1–87" not in playbook and "Rounds 1-87" not in playbook
+    assert "Rounds 1–89" in playbook
+    assert "Rounds 1–88" not in playbook and "Rounds 1-88" not in playbook
 
 
 
@@ -43,7 +43,7 @@ def test_maintenance_playbook_steps_on_separate_lines(glossary_text: str):
     assert re.search(r"guards\.\d+\.", playbook) is None, (
         "playbook steps merged without newline between numbers"
     )
-    for step in ("17.", "18.", "19.", "20."):
+    for step in ("17.", "18.", "19.", "20.", "21."):
         assert step in playbook
 
 
diff --git a/reflective-prompt-library/plans/tests/test_readme_governance.py b/reflective-prompt-library/plans/tests/test_readme_governance.py
@@ -10,8 +10,8 @@
 METHODOLOGY_MAP_EN = Path(__file__).parent.parent.parent / "METHODOLOGY_MAP.md"
 SKILL_MAP = Path(__file__).parent.parent.parent / "skills" / "skill-map.md"
 
-CURRENT_PANEL_ROUND = "88"
-CURRENT_PANEL_OPTIONS = "A–FS"
+CURRENT_PANEL_ROUND = "89"
+CURRENT_PANEL_OPTIONS = "A–FW"
 
 
 @pytest.fixture(scope="module")
