Debug overhaul#38
Draft
Michael-Foley wants to merge 10 commits into
Draft
Conversation
added 2 commits
February 14, 2025 15:51
…inding values easier in telemetry; got rid of redundant names inside of some sub tables
davidorser
previously approved these changes
Feb 16, 2025
Contributor
There was a problem hiding this comment.
The architecture looks pretty good. I'm tempted to try to use an enforced hierarchy for names of the table values. (e.g., RobotSubSystemName/Arm-PosCMD). The sub-table looks like a great place to put it. Though this may have some unforeseen drawbacks.
Besides that, things look good but there are a lot of changes here, so I'm sure I didn't really think through everything. We definitely need to be careful when deploying this and look for bugs.
| self.table = ( | ||
| NetworkTableInstance.getDefault() | ||
| .getTable("telemetry") | ||
| .getSubTable("Elevator Subsystem") |
Contributor
There was a problem hiding this comment.
What do you think about replacing "Elevator Subsystem" with self.__class__.__name__ ?? If we have multiple objects of the same type it would get messy. I'm not sure I'm sold on this...
added 7 commits
February 25, 2025 10:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A better telemetry system is needed so I added sub tables to each item so that it is easier to find in shuffleboard. Some redundant names were removed because which motor would be known based on the sub table it is in. Debug switches were added to each subsystem. The global debug flag was removed from the robotHAL file. Each motor controller now has its own debug flag.