Skip to content

[fix] #202 브랜드 마커 선택 시 줌 레벨 MapViewModel에 적용#203

Merged
Ojongseok merged 9 commits into
developfrom
fix/#202-map_zoom_level_viewmodel
Apr 23, 2026
Merged

[fix] #202 브랜드 마커 선택 시 줌 레벨 MapViewModel에 적용#203
Ojongseok merged 9 commits into
developfrom
fix/#202-map_zoom_level_viewmodel

Conversation

@Ojongseok

@Ojongseok Ojongseok commented Apr 23, 2026

Copy link
Copy Markdown
Member

🔗 관련 이슈

📙 작업 설명

🧪 테스트 내역

  • "포토부스 마커" 선택
  • "포토부스 상세 카드" 선택
  • "현위치" 버튼 선택
  • 가까운 "네컷 사진 브랜드" 선택

📸 스크린샷 또는 시연 영상

기능 미리보기
카메라 이동
KakaoTalk_Video_2026-04-23-22-07-55.mp4

💬 추가 설명 or 리뷰 포인트

  • 없음

Summary by CodeRabbit

릴리스 노트

  • 새로운 기능
    • 포토부스 마커 선택 시 지도가 해당 위치로 카메라를 이동하고, 최적화된 줌 레벨을 자동으로 적용하여 더 나은 보기 환경을 제공합니다.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@Ojongseok Ojongseok added the fix label Apr 23, 2026
@github-actions
github-actions Bot requested a review from ikseong00 April 23, 2026 12:46
@Ojongseok
Ojongseok marked this pull request as draft April 23, 2026 12:47
@coderabbitai

coderabbitai Bot commented Apr 23, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@Ojongseok has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 32 minutes and 4 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 32 minutes and 4 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: b79e8baf-e24b-428e-a3b8-296c45e4ce1f

📥 Commits

Reviewing files that changed from the base of the PR and between 1f83dc2 and cd26cd8.

📒 Files selected for processing (1)
  • feature/map/impl/src/main/java/com/neki/android/feature/map/impl/MapViewModel.kt

Walkthrough

MapViewModel의 handleClickPhotoBoothMarker 메서드에서 카메라 이동 시 zoomLevel 파라미터를 명시적으로 MapConst.MARKER_SELECTED_ZOOM_LEVEL로 전달하여 마커 선택 시 줌 레벨이 올바르게 적용되도록 수정했습니다.

Changes

Cohort / File(s) Summary
마커 클릭 줌 레벨 수정
feature/map/impl/src/main/java/com/neki/android/feature/map/impl/MapViewModel.kt
사진 부스 마커 클릭 핸들러에서 MoveCameraToPosition 호출 시 zoomLevel 파라미터를 MapConst.MARKER_SELECTED_ZOOM_LEVEL로 명시적으로 지정

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 마커 클릭할 때 줌이 쏙 들어와,
레벨이 제대로 담겨 있어,
작은 한 줄이 큰 변화를 주니,
지도는 이제 완벽해 보여! 🗺️✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed 제목은 이슈 #202를 명시하고 품질관리 마커 선택 시 줌 레벨을 MapViewModel에 적용하는 주요 변경사항을 명확하게 설명합니다.
Linked Issues check ✅ Passed MapViewModel의 handleClickPhotoBoothMarker에서 MoveCameraToPosition 호출 시 zoomLevel 파라미터를 추가하여 이슈 #202의 요구사항을 충족합니다.
Out of Scope Changes check ✅ Passed 변경사항은 MapViewModel.kt의 사진부스 마커 클릭 처리 부분에만 국한되며, 다른 클릭 핸들러나 상태 업데이트는 변경되지 않아 범위 내입니다.
Description check ✅ Passed PR 설명이 템플릿의 주요 섹션을 충실히 따르고 있으며, 관련 이슈, 작업 설명, 테스트 내역, 스크린샷이 모두 포함되어 있습니다.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/#202-map_zoom_level_viewmodel

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Ojongseok
Ojongseok removed the request for review from ikseong00 April 23, 2026 12:47
@Ojongseok
Ojongseok marked this pull request as ready for review April 23, 2026 13:14
@Ojongseok
Ojongseok requested a review from ikseong00 April 23, 2026 13:14

@ikseong00 ikseong00 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋습니당 👍

@Ojongseok
Ojongseok merged commit b667c57 into develop Apr 23, 2026
4 checks passed
@Ojongseok
Ojongseok deleted the fix/#202-map_zoom_level_viewmodel branch May 25, 2026 07:49
Ojongseok added a commit that referenced this pull request May 25, 2026
…model

[fix] #202 브랜드 마커 선택 시 줌 레벨 MapViewModel에 적용
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[fix] 브랜드 마커 선택 시 줌 레벨이 MapViewModel에 미적용

2 participants