[refactor] #226 5차 지도 UX 개선#229
Merged
Merged
Conversation
…_ZOOM 15 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- CloseButton을 CloseButton.kt에서 MapCircleButton.kt로 통합 - PhotoBoothFavoriteButton → ShowFavoritePhotoBoothButton으로 리네임 - CardFavoriteButton, CardDirectionButton 추가 (isFavorite 버그 수정 포함) - PhotoBoothDetailContent: 즐겨찾기 버튼을 카드 외부에서 내부로 이동 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough지도 폴리곤 조회 결과의 즐겨찾기 동기화, 클러스터링 기준 조정, 즐겨찾기 패널 애니메이션, 공통 버튼 구성, 상세 카드 내 즐겨찾기 버튼 배치가 변경되었습니다. Changes지도 즐겨찾기 및 UX 개편
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested labels: Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@feature/map/impl/src/main/java/com/neki/android/feature/map/impl/component/AnchoredDraggablePanel.kt`:
- Around line 313-317: Extract the spring stiffness value and damping-ratio
conversion inputs from the animateItem placementSpec into clearly named
constants, then compute dampingRatio from those constants using the existing ζ =
c / (2√(km)) formula with unit mass. Update the spring call in
AnchoredDraggablePanel to reference the named constants and preserve the current
behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 74f3c069-ce22-4ae2-99d5-82ae904944dd
📒 Files selected for processing (6)
feature/map/impl/src/main/java/com/neki/android/feature/map/impl/MapViewModel.ktfeature/map/impl/src/main/java/com/neki/android/feature/map/impl/cluster/ClustererConst.ktfeature/map/impl/src/main/java/com/neki/android/feature/map/impl/component/AnchoredDraggablePanel.ktfeature/map/impl/src/main/java/com/neki/android/feature/map/impl/component/CloseButton.ktfeature/map/impl/src/main/java/com/neki/android/feature/map/impl/component/MapCircleButton.ktfeature/map/impl/src/main/java/com/neki/android/feature/map/impl/component/PhotoBoothDetailContent.kt
💤 Files with no reviewable changes (1)
- feature/map/impl/src/main/java/com/neki/android/feature/map/impl/component/CloseButton.kt
ikseong00
approved these changes
Jul 13, 2026
Comment on lines
+6
to
+7
| const val MAX_CLUSTERING_ZOOM = 15 // 클러스터링 종료 줌 레벨 (이 이상이면 개별 마커 표시) | ||
| const val MAX_SCREEN_DISTANCE = 150.0 // 클러스터로 묶이는 최대 화면 거리 (px) |
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 관련 이슈
📙 작업 설명
MapCircleButton기반으로CurrentLocationButton,ShowFavoritePhotoBoothButton, 닫기 버튼 컴포넌트 통합 리팩토링 (CloseButton제거)이 지역 재검색후 즐겨찾기 마커가 폴리곤 영역 이탈 시 지도에 남아있는 버그 수정 (favorite필드 동기화 누락)📸 스크린샷 또는 시연 영상
KakaoTalk_Video_2026-07-13-01-57-41.mp4
💬 추가 설명 or 리뷰 포인트
Summary by CodeRabbit
새로운 기능
개선 사항